From: Ian Campbell <Ian.Campbell@citrix.com>
To: Frediano Ziglio <frediano.ziglio@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/7] vgabios: Fix size computation overflow
Date: Fri, 4 May 2012 15:26:49 +0100 [thread overview]
Message-ID: <1336141609.7535.2.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <7CE799CC0E4DE04B88D5FDF226E18AC2CDE9E24CDB@LONPMAILBOX01.citrite.net>
On Fri, 2012-05-04 at 15:18 +0100, Frediano Ziglio wrote:
> On Fri, 2012-05-04 at 15:12 +0100, Ian Campbell wrote:
> > On Fri, 2012-05-04 at 13:36 +0100, Frediano Ziglio wrote:
> > > Remove an overflow computing width x height x bit which does
> > > not fit into a 16 bits. I wrote a routine to multiple these value
> > > and get the size required for framebuffer in segment unit (64k).
> >
> > Couldn't this be done in C using a suitably wide temporary variable?
> >
>
> I'd like :(
>
> BCC compiler used need some function which are not linked by BIOS.
In which case
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2012-05-04 14:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 12:36 [PATCH 0/7] VGA BIOS patches Frediano Ziglio
2012-05-04 12:36 ` [PATCH 1/7] vgabios: Output to Qemu debug port instead of using Bochs one Frediano Ziglio
2012-05-04 14:04 ` Ian Campbell
2012-05-04 12:36 ` [PATCH 2/7] vgabios: Does not define cur_mode if not required Frediano Ziglio
2012-05-04 12:36 ` [PATCH 3/7] vgabios: Fix size computation overflow Frediano Ziglio
2012-05-04 14:12 ` Ian Campbell
2012-05-04 14:18 ` Frediano Ziglio
2012-05-04 14:26 ` Ian Campbell [this message]
2012-05-04 14:45 ` Frediano Ziglio
2012-05-04 14:47 ` Frediano Ziglio
2012-05-04 14:48 ` Frediano Ziglio
2012-05-04 12:36 ` [PATCH 4/7] vgabios: Report mode not supported getting mode informations Frediano Ziglio
2012-05-04 14:18 ` Ian Campbell
2012-05-04 12:36 ` [PATCH 5/7] vgabios: Reduce stack usage " Frediano Ziglio
2012-05-04 12:36 ` [PATCH 6/7] vgabios: Check if mode is currently supported as vesa specifications Frediano Ziglio
2012-05-04 12:36 ` [PATCH 7/7] vgabios: Make Windows 8 support greater resolutions Frediano Ziglio
2012-05-04 14:19 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2012-05-01 13:52 VGABIOS patches Frediano Ziglio
2012-05-01 13:52 ` [PATCH 3/7] vgabios: Fix size computation overflow Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336141609.7535.2.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=frediano.ziglio@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).