From: Dario Faggioli <raistlin@linux.it>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xl: introduce specific VCPU to PCPU mapping in config file
Date: Mon, 14 May 2012 12:08:25 +0200 [thread overview]
Message-ID: <1336990105.28326.12.camel@Solace> (raw)
In-Reply-To: <1336983290.31817.4.camel@zakaz.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1483 bytes --]
On Mon, 2012-05-14 at 09:14 +0100, Ian Campbell wrote:
> > Damn! I forgot to update the doc (xl manual) accordingly!
>
> That was going to be my first comment ;-)
>
:-)
> It would also be useful if the commit message mentions the impact on the
> existing syntax -- I'm not sure if this is changing the behaviour of an
> existing xl syntax or adding a whole new one (maybe the docs will answer
> that).
>
From since when I added the `cpus=xxx` support to xl (back in February
and righ because it was a missing feature wrt to xm) it was using both:
cpus="2, 3"
and
cpus=["2", "3"]
to do the same thing, i.e., bind all the vcpus of the guest to the pcpus
#2 and #3 of the host.
On the other hand xm/xend do/did the following:
cpus="2, 3" --> bind all vcpus to pcpus #2 and #3
cpus=["2", "3"] --> bind vcpu #0 to pcpu #3 and vcpu #1 to pcpu #3
So, yes and no. :-) The point is using both syntax for he same thing in
xl hasn't been a good choice at all at that time, and this changest is
fixing that, other than improving xl-xm compatibility.
I hope I've clarified that here, and yes, I'll add something about this
in the commit message.
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-05-14 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 23:20 [PATCH] xl: introduce specific VCPU to PCPU mapping in config file Dario Faggioli
2012-05-11 23:23 ` Dario Faggioli
2012-05-13 8:35 ` Dario Faggioli
2012-05-14 8:14 ` Ian Campbell
2012-05-14 10:08 ` Dario Faggioli [this message]
2012-05-14 8:19 ` Ian Campbell
2012-05-14 17:03 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336990105.28326.12.camel@Solace \
--to=raistlin@linux.it \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).