From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xl: introduce specific VCPU to PCPU mapping in config file Date: Mon, 14 May 2012 12:08:25 +0200 Message-ID: <1336990105.28326.12.camel@Solace> References: <20943633a63e0691272b.1336778417@Solace> <1336778609.27081.1.camel@Abyss> <1336898139.2612.1.camel@Abyss> <1336983290.31817.4.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7447410111136253433==" Return-path: In-Reply-To: <1336983290.31817.4.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============7447410111136253433== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-gAauRNc41a9BOePnSCr0" --=-gAauRNc41a9BOePnSCr0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2012-05-14 at 09:14 +0100, Ian Campbell wrote: > > Damn! I forgot to update the doc (xl manual) accordingly! >=20 > That was going to be my first comment ;-) >=20 :-) > It would also be useful if the commit message mentions the impact on the > existing syntax -- I'm not sure if this is changing the behaviour of an > existing xl syntax or adding a whole new one (maybe the docs will answer > that). >=20 =46rom since when I added the `cpus=3Dxxx` support to xl (back in February and righ because it was a missing feature wrt to xm) it was using both: cpus=3D"2, 3" and cpus=3D["2", "3"] to do the same thing, i.e., bind all the vcpus of the guest to the pcpus #2 and #3 of the host. On the other hand xm/xend do/did the following: cpus=3D"2, 3" --> bind all vcpus to pcpus #2 and #3 cpus=3D["2", "3"] --> bind vcpu #0 to pcpu #3 and vcpu #1 to pcpu #3 So, yes and no. :-) The point is using both syntax for he same thing in xl hasn't been a good choice at all at that time, and this changest is fixing that, other than improving xl-xm compatibility. I hope I've clarified that here, and yes, I'll add something about this in the commit message. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-gAauRNc41a9BOePnSCr0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk+w2ZkACgkQk4XaBE3IOsShbgCfahROGC/KexbI80dkSmlufnRv r0AAnA8HVOjLE4En7C/At8QJdrBYuWOn =Byde -----END PGP SIGNATURE----- --=-gAauRNc41a9BOePnSCr0-- --===============7447410111136253433== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7447410111136253433==--