From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] xl: introduce specific VCPU to PCPU mapping in config file Date: Mon, 14 May 2012 19:03:49 +0200 Message-ID: <1337015029.28326.51.camel@Solace> References: <0953e429ec0a517b247f.1336987609@Solace> <1336988060.31817.51.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2820221027594701527==" Return-path: In-Reply-To: <1336988060.31817.51.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============2820221027594701527== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-LlGY/ZyS9jvFR6tOtWLY" --=-LlGY/ZyS9jvFR6tOtWLY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2012-05-14 at 10:34 +0100, Ian Campbell wrote: > On Mon, 2012-05-14 at 10:26 +0100, Dario Faggioli wrote: > > xm supports the following syntax (in the config file) for > > specific VCPU to PCPU mapping: > >=20 > > cpus =3D ["2", "3"] # VCPU0 runs on CPU2, VCPU1 runs on CPU3 > >=20 > > Allow for the same in xl. > >=20 > > Signed-off-by: Dario Faggioli > >=20 > > ... > > + > > +=3Ditem "0-3,5,^1" > > + > > +To allow all the vcpus of the guest to run on cpus 0,2,3,5. > > + > > +=3Ditem [2, 3] >=20 > Is this [2, 3] or ["2", "3"] as you used in the commit message? (would > it be confusing the make those distinct, represent the current xl > behaviour and xm behaviour respectively?) >=20 Well, tools/examples/xmexample.hvm says xm supports `cpus=3D["2", "3"]`, while on xl both syntax (with or without the inner `"`) are recognized by xlu_get_list[item](). TBH, I don't think it's worth distinguishing between the two, especially considering we have the string syntax (i.e., `cpus=3D"2,3") to achieve the current behaviour. > I think you missed my review on the v1 code when preparing this posting > (we probably passed in mid-air)? >=20 Indeed! :-) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-LlGY/ZyS9jvFR6tOtWLY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk+xOvUACgkQk4XaBE3IOsSrDACeL5p8jIJmgzInxl+JmNBsBNuI O/4AoIsE2WDup5FlugW6VW8tjKszTAfO =otes -----END PGP SIGNATURE----- --=-LlGY/ZyS9jvFR6tOtWLY-- --===============2820221027594701527== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2820221027594701527==--