From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] libxl: Introduce LIBXL_DOMAIN_TYPE_INVALID to make gcc happy Date: Fri, 18 May 2012 16:48:12 +0200 Message-ID: <1337352492.16815.22.camel@Solace> References: <4FB63171.3020102@amd.com> <4FB63EB6.10803@amd.com> <1337351445.16815.19.camel@Solace> <1337351979.22316.123.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0400893146491601329==" Return-path: In-Reply-To: <1337351979.22316.123.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Christoph Egger , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============0400893146491601329== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-CnQ89MowekbvzfL0+pRD" --=-CnQ89MowekbvzfL0+pRD Content-Type: multipart/mixed; boundary="=-kYTSgcfiC/j89ttp4czq" --=-kYTSgcfiC/j89ttp4czq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-05-18 at 15:39 +0100, Ian Campbell wrote: > > Which actually seems to be right: > >=20 > > $ grep LIBXL_DOMAIN_TYPE_INVALID tools/* -R > > tools/libxl/libxl_dm.c: case LIBXL_DOMAIN_TYPE_INVALID: > > tools/libxl/libxl_dm.c: case LIBXL_DOMAIN_TYPE_INVALID: > > tools/libxl/libxl_dom.c: return LIBXL_DOMAIN_TYPE_INVALID; > > tools/libxl/libxl_dom.c: return LIBXL_DOMAIN_TYPE_INVALID; > > tools/libxl/libxl.c: case LIBXL_DOMAIN_TYPE_INVALID: > >=20 > > Am I missing something? >=20 > This should be defined in tools/libxl/libxl_types.idl but the patch > doesn't seem to add it. >=20 Yep, I'm adding it myself with the attached patch, but I'm now getting this: _libxl_types.c: In function =E2=80=98libxl_domain_build_info_dispose=E2=80= =99: _libxl_types.c:91:5: error: enumeration value =E2=80=98LIBXL_DOMAIN_TYPE_IN= VALID=E2=80=99 not handled in switch [-Werror=3Dswitch] _libxl_types.c: In function =E2=80=98libxl_domain_build_info_init_type=E2= =80=99: _libxl_types.c:284:5: error: enumeration value =E2=80=98LIBXL_DOMAIN_TYPE_I= NVALID=E2=80=99 not handled in switch [-Werror=3Dswitch] testidl.c: In function =E2=80=98libxl_domain_build_info_rand_init=E2=80=99: testidl.c:366:5: error: enumeration value =E2=80=98LIBXL_DOMAIN_TYPE_INVALI= D=E2=80=99 not handled in switch [-Werror=3Dswitch] _libxl_types.c: In function =E2=80=98libxl_domain_build_info_gen_json=E2=80= =99: _libxl_types.c:1713:5: error: enumeration value =E2=80=98LIBXL_DOMAIN_TYPE_= INVALID=E2=80=99 not handled in switch [-Werror=3Dswitch] cc1: all warnings being treated as errors :-O Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-kYTSgcfiC/j89ttp4czq Content-Disposition: attachment; filename="DOMAIN_TYPE_INVALID.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="DOMAIN_TYPE_INVALID.patch"; charset="UTF-8" ZGlmZiAtciA5YmJjNDA1OWMyZDEgdG9vbHMvbGlieGwvbGlieGxfdHlwZXMuaWRsDQotLS0gYS90 b29scy9saWJ4bC9saWJ4bF90eXBlcy5pZGwJRnJpIE1heSAxOCAxNjozMTowOSAyMDEyICswMjAw DQorKysgYi90b29scy9saWJ4bC9saWJ4bF90eXBlcy5pZGwJRnJpIE1heSAxOCAxNjo0NzoxNyAy MDEyICswMjAwDQpAQCAtMzAsNiArMzAsNyBAQCBNZW1LQiA9IFVJbnQoNjQsIGluaXRfdmFsID0g IkxJQlhMX01FTUtCDQogIw0KIA0KIGxpYnhsX2RvbWFpbl90eXBlID0gRW51bWVyYXRpb24oImRv bWFpbl90eXBlIiwgWw0KKyAgICAoLTEsICJJTlZBTElEIiksDQogICAgICgxLCAiSFZNIiksDQog ICAgICgyLCAiUFYiKSwNCiAgICAgXSkNCg== --=-kYTSgcfiC/j89ttp4czq-- --=-CnQ89MowekbvzfL0+pRD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk+2YSwACgkQk4XaBE3IOsQrfACeOb7pXiCk3Zm2N+REkN/uAGkB +o0AnAmqKX1eWoT3ElXnpF7N2tS57/1u =wChA -----END PGP SIGNATURE----- --=-CnQ89MowekbvzfL0+pRD-- --===============0400893146491601329== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0400893146491601329==--