From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1 of 3] Support of getting scheduler defaults Date: Wed, 23 May 2012 12:18:49 +0200 Message-ID: <1337768329.27368.66.camel@Solace> References: <56c50b3f6cc3eb1de8b8.1337678212@nehalem1> <1337689344.10118.92.camel@zakaz.uk.xensource.com> <4FBB86AE.7010908@ts.fujitsu.com> <1337689975.10118.102.camel@zakaz.uk.xensource.com> <4FBB8D92.8050800@ts.fujitsu.com> <1337694056.10118.128.camel@zakaz.uk.xensource.com> <1337698766.10118.139.camel@zakaz.uk.xensource.com> <1337730401.27368.38.camel@Solace> <4FBC76E3.5020602@ts.fujitsu.com> <1337757720.27368.58.camel@Solace> <1337758867.3991.6.camel@dagon.hellion.org.uk> <4FBCA39F.4090408@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3770827227748036578==" Return-path: In-Reply-To: <4FBCA39F.4090408@ts.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross Cc: George Dunlap , "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============3770827227748036578== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-8N4SXkL8xGwlvjZZ+6dW" --=-8N4SXkL8xGwlvjZZ+6dW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2012-05-23 at 10:45 +0200, Juergen Gross wrote: > >> Not sure, I think Ian's patch fixes that: > > I thought so to! >=20 > It fixes the original error. >=20 Yep, that was what I was looking at ... > >> So it has to be something else... >=20 > Oh yes: >=20 > + > + if (scinfo->period !=3D LIBXL_SCHED_DOMAIN_PARAM_PERIOD_DEFAULT) > + period =3D scinfo->period * 1000000; > + if (scinfo->slice !=3D LIBXL_SCHED_DOMAIN_PARAM_SLICE_DEFAULT) > + period =3D scinfo->slice * 1000000; > + if (scinfo->latency !=3D LIBXL_SCHED_DOMAIN_PARAM_LATENCY_DEFAULT) > + period =3D scinfo->latency * 1000000; > + if (scinfo->extratime !=3D LIBXL_SCHED_DOMAIN_PARAM_EXTRATIME_DEFAUL= T) > + period =3D scinfo->extratime; > + if (scinfo->weight !=3D LIBXL_SCHED_DOMAIN_PARAM_WEIGHT_DEFAULT) > + period =3D scinfo->weight; >=20 > Regardless which parameter was changed, it is always 'period' which is se= t > to the changed value. >=20 ... And completely ignored this! :-P However, I'm still having some issues (even after fixing this)! I'll keep looking at this, testing the series Ian just sent and let you know. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-8N4SXkL8xGwlvjZZ+6dW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk+8uYkACgkQk4XaBE3IOsQK/gCfR0jD74EgfJCRB6D46Zr0I+fh XEYAnin2kT9r7gllSyuUMgbiT6WHDDMT =y+DZ -----END PGP SIGNATURE----- --=-8N4SXkL8xGwlvjZZ+6dW-- --===============3770827227748036578== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3770827227748036578==--