From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 3 of 3] libxl: make it possible to explicitly specify default sched params Date: Wed, 23 May 2012 13:12:40 +0200 Message-ID: <1337771560.27368.69.camel@Solace> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2395295213865740947==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: George Dunlap , Juergen Gross , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============2395295213865740947== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-glEe9mAgoWRtyM+uXCi/" --=-glEe9mAgoWRtyM+uXCi/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2012-05-23 at 10:26 +0100, Ian Campbell wrote: > # HG changeset patch > # User Ian Campbell > # Date 1337764865 -3600 > # Node ID b6221bcdf9a9045b49a2ddd7877602788f657bad > # Parent 7d8428388b775a0b26cf88f89ec8f99f5fc8ce25 > libxl: make it possible to explicitly specify default sched params >=20 > To do so we define a descriminating value which is never a valid real val= ue for > each parameter. >=20 > While there: >=20 > - removed libxl_sched_*_domain in favour of libxl_sched_params. > - use this new functionality for the various xl commands which set sched > parameters, which saves an explicit read-modify-write in xl. > - removed call of xc_domain_getinfolist from a few functions which weren= 't > actually using the result (looks like a cut and paste error) > - fix xl which was setting period for a variety of different config keys= . >=20 > Signed-off-by: Ian Campbell >=20 Might be my fault, but I can't get this patch to build: xl_cmdimpl.c:4365:47: error: unknown type name =E2=80=98libxl_sched_credit_= domain=E2=80=99 xl_cmdimpl.c: In function =E2=80=98sched_credit_domain_output=E2=80=99: xl_cmdimpl.c:4401:5: error: unknown type name =E2=80=98libxl_sched_credit_d= omain=E2=80=99 xl_cmdimpl.c:4408:5: error: implicit declaration of function =E2=80=98sched= _credit_domain_get=E2=80=99 [-Werror=3Dimplicit-function-declaration] xl_cmdimpl.c:4415:15: error: request for member =E2=80=98weight=E2=80=99 in= something not a structure or union xl_cmdimpl.c:4416:15: error: request for member =E2=80=98cap=E2=80=99 in so= mething not a structure or union xl_cmdimpl.c:4418:5: error: implicit declaration of function =E2=80=98libxl= _sched_credit_domain_dispose=E2=80=99 [-Werror=3Dimplicit-function-declarat= ion] xl_cmdimpl.c: At top level: xl_cmdimpl.c:4444:16: error: unknown type name =E2=80=98libxl_sched_credit2= _domain=E2=80=99 xl_cmdimpl.c:4456:16: error: unknown type name =E2=80=98libxl_sched_credit2= _domain=E2=80=99 xl_cmdimpl.c: In function =E2=80=98sched_credit2_domain_output=E2=80=99: xl_cmdimpl.c:4471:5: error: unknown type name =E2=80=98libxl_sched_credit2_= domain=E2=80=99 xl_cmdimpl.c:4478:5: error: implicit declaration of function =E2=80=98sched= _credit2_domain_get=E2=80=99 [-Werror=3Dimplicit-function-declaration] xl_cmdimpl.c:4485:15: error: request for member =E2=80=98weight=E2=80=99 in= something not a structure or union xl_cmdimpl.c:4487:5: error: implicit declaration of function =E2=80=98libxl= _sched_credit2_domain_dispose=E2=80=99 [-Werror=3Dimplicit-function-declara= tion] xl_cmdimpl.c: At top level: xl_cmdimpl.c:4492:16: error: unknown type name =E2=80=98libxl_sched_sedf_do= main=E2=80=99 xl_cmdimpl.c:4504:16: error: unknown type name =E2=80=98libxl_sched_sedf_do= main=E2=80=99 ... ... It seems like there are some leftovers of the old libxl_sched_{credit,...}_domain in xl_cmdimpl.c ... Perhaps a missing add/refresh on our side? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-glEe9mAgoWRtyM+uXCi/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk+8xigACgkQk4XaBE3IOsQHigCfS4N4GUzocXn8Cy1pPeaEKO07 EHQAoIzUj4HAkPcdOxk7yfQK4BZRev1i =rHMf -----END PGP SIGNATURE----- --=-glEe9mAgoWRtyM+uXCi/-- --===============2395295213865740947== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2395295213865740947==--