From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <raistlin@linux.it>
Subject: Re: [PATCH] libxl: Introduce LIBXL_DOMAIN_TYPE_INVALID
 to make gcc happy
Date: Wed, 23 May 2012 13:17:38 +0200
Message-ID: <1337771858.27368.72.camel@Solace>
References: <4FB63171.3020102@amd.com> <4FB63EB6.10803@amd.com>
	<1337351445.16815.19.camel@Solace>
	<1337351979.22316.123.camel@zakaz.uk.xensource.com>
	<1337352492.16815.22.camel@Solace>
	<1337352958.22316.126.camel@zakaz.uk.xensource.com>
	<20412.49592.945171.764646@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5275636891221188973=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20412.49592.945171.764646@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org


--===============5275636891221188973==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-8MOunInv5B8wVmcmNYDz"


--=-8MOunInv5B8wVmcmNYDz
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2012-05-23 at 11:53 +0100, Ian Jackson wrote:
> And the upside of making it be an enum is precisely
>=20
> > On Fri, 2012-05-18 at 15:48 +0100, Dario Faggioli wrote:
> > > _libxl_types.c: In function =E2=80=98libxl_domain_build_info_dispose=
=E2=80=99:
> > > _libxl_types.c:91:5: error: enumeration value =E2=80=98LIBXL_DOMAIN_T=
YPE_INVALID=E2=80=99 not handled in switch [-Werror=3Dswitch]
>=20
> these warnings, which are alerting us to call sites with broken error
> handling.
>=20
I agree, and I can sue try looking at those call sites and see what it
takes to add a proper 'case' or 'default' clause in there if you think
that to be the way to go...

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-8MOunInv5B8wVmcmNYDz
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAk+8x1IACgkQk4XaBE3IOsT1BACdGgZTwToLB2D+2xcmFJ5ZQ5iv
XkYAoJDTjSzudq0tc0d8qOjqmeQ0zMRj
=dSW1
-----END PGP SIGNATURE-----

--=-8MOunInv5B8wVmcmNYDz--



--===============5275636891221188973==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5275636891221188973==--