xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com
Subject: [PATCH 3/4] xen/hvc: Check HVM_PARAM_CONSOLE_[EVTCHN|PFN] for correctness.
Date: Wed, 23 May 2012 13:47:01 -0400	[thread overview]
Message-ID: <1337795222-29946-4-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1337795222-29946-1-git-send-email-konrad.wilk@oracle.com>

We need to make sure that those parameters are setup to be correct.
As such the value of 0 is deemed invalid and we find that we
bail out. The hypervisor sets by default all of them to be zero
and when the hypercall is done does a simple:

 a.value = d->arch.hvm_domain.params[a.index];

Which means that if the Xen toolstack forgot to setup the proper
HVM_PARAM_CONSOLE_EVTCHN, we would get the default value of 0
and use that.

CC: stable@kernel.org
Fixes-Oracle-Bug: 14091238
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/tty/hvc/hvc_xen.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
index 3277f0e..5fb1cb9 100644
--- a/drivers/tty/hvc/hvc_xen.c
+++ b/drivers/tty/hvc/hvc_xen.c
@@ -216,12 +216,12 @@ static int xen_hvm_console_init(void)
 		return 0;
 
 	r = hvm_get_parameter(HVM_PARAM_CONSOLE_EVTCHN, &v);
-	if (r < 0)
+	if (r < 0 || v == 0)
 		goto err;
 	info->evtchn = v;
 	v = 0;
 	r = hvm_get_parameter(HVM_PARAM_CONSOLE_PFN, &v);
-	if (r < 0)
+	if (r < 0 || v == 0)
 		goto err;
 	mfn = v;
 	info->intf = ioremap(mfn << PAGE_SHIFT, PAGE_SIZE);
-- 
1.7.7.5

  parent reply	other threads:[~2012-05-23 17:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 17:46 [PATCH] bug-fixes to hvc-xen driver in v3.4 (and earlier) Konrad Rzeszutek Wilk
2012-05-23 17:46 ` [PATCH 1/4] xen/hvc: Collapse error logic Konrad Rzeszutek Wilk
2012-05-24 10:33   ` Stefano Stabellini
2012-05-23 17:47 ` [PATCH 2/4] xen/hvc: Fix error cases around HVM_PARAM_CONSOLE_PFN Konrad Rzeszutek Wilk
2012-05-24 10:47   ` [Xen-devel] " Stefano Stabellini
2012-05-24 17:31     ` Konrad Rzeszutek Wilk
2012-05-24 18:18       ` Konrad Rzeszutek Wilk
2012-05-23 17:47 ` Konrad Rzeszutek Wilk [this message]
2012-05-24 10:51   ` [PATCH 3/4] xen/hvc: Check HVM_PARAM_CONSOLE_[EVTCHN|PFN] for correctness Stefano Stabellini
2012-05-24 18:24     ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-25  9:13       ` Stefano Stabellini
2012-05-23 17:47 ` [PATCH 4/4] xen/events: Add WARN_ON when quick lookup found invalid type Konrad Rzeszutek Wilk
2012-05-24 10:58   ` [Xen-devel] " Stefano Stabellini
2012-05-24 17:29     ` Konrad Rzeszutek Wilk
2012-05-24 18:28     ` Konrad Rzeszutek Wilk
2012-05-25  9:18       ` Stefano Stabellini
2012-05-25  9:19         ` Stefano Stabellini
2012-05-25 13:42           ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337795222-29946-4-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).