xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <raistlin@linux.it>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Juergen Gross <juergen.gross@ts.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3 of 3] libxl: make it possible to explicitly specify default sched params
Date: Thu, 24 May 2012 11:15:04 +0200	[thread overview]
Message-ID: <1337850904.13601.2.camel@Solace> (raw)
In-Reply-To: <1337849534.7229.8.camel@zakaz.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 1218 bytes --]

On Thu, 2012-05-24 at 09:52 +0100, Ian Campbell wrote:
> > Might be my fault, but I can't get this patch to build:
> > 
> > xl_cmdimpl.c:4365:47: error: unknown type name ‘libxl_sched_credit_domain’
> > xl_cmdimpl.c: In function ‘sched_credit_domain_output’:
> > xl_cmdimpl.c:4401:5: error: unknown type name ‘libxl_sched_credit_domain’
> 
> My local version definitely doesn't use this type name any more and I
> can see the hunk in the patch which renamed the use in that function to
> libxl_sched_domain_params.
>
Mmm... You're ight, looking at the patch here in the message, the
xl_cmdimpl.c hunks are there. This is not the case of my `hg mimport'-ed
version. Strange. :-/

>  Did you get rejects when you applied perhaps?
> 
Nope, but the imported patch has some garbage at the end... Not sue
whether that is normal o not with `hg mimport'. :-O

Anyway, sorry for bothering, I'll give it another try!
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2012-05-24  9:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23  9:26 [PATCH 0 of 3] libxl: make it possible to explicitly specify default sched params Ian Campbell
2012-05-23  9:26 ` [PATCH 1 of 3] libxl: add internal function to get a domain's scheduler Ian Campbell
2012-05-23 19:47   ` George Dunlap
2012-05-24  8:55     ` Ian Campbell
2012-05-24  9:16       ` Dario Faggioli
2012-05-23  9:26 ` [PATCH 2 of 3] libxl: rename libxl_sched_params to libxl_sched_domain_params Ian Campbell
2012-05-23 19:49   ` George Dunlap
2012-05-23  9:26 ` [PATCH 3 of 3] libxl: make it possible to explicitly specify default sched params Ian Campbell
2012-05-23 10:51   ` Ian Jackson
2012-05-23 11:12   ` Dario Faggioli
2012-05-24  8:52     ` Ian Campbell
2012-05-24  9:15       ` Dario Faggioli [this message]
2012-05-23 19:28   ` George Dunlap
2012-05-23 19:34     ` George Dunlap
2012-05-23 21:19     ` Dario Faggioli
2012-05-24  9:13       ` Ian Campbell
2012-05-24  9:36         ` Dario Faggioli
2012-05-24 13:57     ` Ian Jackson
2012-05-24 14:02       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337850904.13601.2.camel@Solace \
    --to=raistlin@linux.it \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=juergen.gross@ts.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).