From: Dario Faggioli <raistlin@linux.it>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>,
Roger Pau Monne <roger.pau@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v3] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID
Date: Thu, 24 May 2012 16:51:55 +0200 [thread overview]
Message-ID: <1337871115.13601.31.camel@Solace> (raw)
In-Reply-To: <1337870152.7229.35.camel@zakaz.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1628 bytes --]
On Thu, 2012-05-24 at 15:35 +0100, Ian Campbell wrote:
> > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> > --- a/tools/libxl/libxl_dm.c
> > +++ b/tools/libxl/libxl_dm.c
> > @@ -257,6 +257,9 @@ static char ** libxl__build_device_model
> > for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++)
> > flexarray_append(dm_args, b_info->extra_hvm[i]);
> > break;
> > + case LIBXL_DOMAIN_TYPE_INVALID:
> > + LIBXL__LOG(CTX, LIBXL__LOG_ERROR, "invalid domain type");
>
> I think you need a flexarray_free here...
>
Ok. I tried to figure out whether or not I'd need some fee logic, and
apparently I failed. :-P
> > + return NULL;
> > }
> > flexarray_append(dm_args, NULL);
> > return (char **) flexarray_contents(dm_args);
> > @@ -505,6 +508,10 @@ static char ** libxl__build_device_model
> > for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++)
> > flexarray_append(dm_args, b_info->extra_hvm[i]);
> > break;
> > + case LIBXL_DOMAIN_TYPE_INVALID:
> > + LIBXL__LOG(CTX, LIBXL__LOG_ERROR, "invalid domain type");
>
> ... and here.
>
> > + return NULL;
> > + break;
>
> The break is now redundant.
>
Yep, result of a missing qpop/qpush.
v4 coming ...
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-05-24 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 14:30 [PATCH v3] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID Dario Faggioli
2012-05-24 14:35 ` Ian Campbell
2012-05-24 14:51 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337871115.13601.31.camel@Solace \
--to=raistlin@linux.it \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).