From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID Date: Thu, 24 May 2012 16:51:55 +0200 Message-ID: <1337871115.13601.31.camel@Solace> References: <79827edfe2950b8c6839.1337869827@Solace> <1337870152.7229.35.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0995961392971583443==" Return-path: In-Reply-To: <1337870152.7229.35.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Christoph Egger , Roger Pau Monne , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============0995961392971583443== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-v5mclLR83g/tFj5qlzmO" --=-v5mclLR83g/tFj5qlzmO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2012-05-24 at 15:35 +0100, Ian Campbell wrote: > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > --- a/tools/libxl/libxl_dm.c > > +++ b/tools/libxl/libxl_dm.c > > @@ -257,6 +257,9 @@ static char ** libxl__build_device_model > > for (i =3D 0; b_info->extra_hvm && b_info->extra_hvm[i] !=3D N= ULL; i++) > > flexarray_append(dm_args, b_info->extra_hvm[i]); > > break; > > + case LIBXL_DOMAIN_TYPE_INVALID: > > + LIBXL__LOG(CTX, LIBXL__LOG_ERROR, "invalid domain type"); >=20 > I think you need a flexarray_free here... >=20 Ok. I tried to figure out whether or not I'd need some fee logic, and apparently I failed. :-P > > + return NULL; > > } > > flexarray_append(dm_args, NULL); > > return (char **) flexarray_contents(dm_args); > > @@ -505,6 +508,10 @@ static char ** libxl__build_device_model > > for (i =3D 0; b_info->extra_hvm && b_info->extra_hvm[i] !=3D N= ULL; i++) > > flexarray_append(dm_args, b_info->extra_hvm[i]); > > break; > > + case LIBXL_DOMAIN_TYPE_INVALID: > > + LIBXL__LOG(CTX, LIBXL__LOG_ERROR, "invalid domain type"); >=20 > ... and here. >=20 > > + return NULL; > > + break; >=20 > The break is now redundant. >=20 Yep, result of a missing qpop/qpush. v4 coming ... Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-v5mclLR83g/tFj5qlzmO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk++SwsACgkQk4XaBE3IOsQdlACgiVTtMZ7D/Y0z9Mss/WwvrIyd +LEAnjsnwVlmoueUqW8Gv09pQaujsrt0 =0Srp -----END PGP SIGNATURE----- --=-v5mclLR83g/tFj5qlzmO-- --===============0995961392971583443== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0995961392971583443==--