* swap: don't do discard if no discard option added @ 2012-05-20 22:30 William Dauchy 2012-05-21 18:15 ` [Xen-devel] " Konrad Rzeszutek Wilk 0 siblings, 1 reply; 12+ messages in thread From: William Dauchy @ 2012-05-20 22:30 UTC (permalink / raw) To: stable Cc: xen-devel, Shaohua Li, Greg Kroah-Hartman, Ben Hutchings, linux-kernel Hello, On Xen, when booting a guest with a system disk and an additional swap disk I'm getting a calltrace. xen hypervisor: 4.1.2; linux dom0: v3.3.6; linux guest: v3.2.17 When booting without a swap disk, I don't have the issue. I also tested a guest with v3.3.6: same problem. But from v3.4-rc2, the issue is fixed. I cherry-picked: 052b198 swap: don't do discard if no discard option added Applied and tested on top of v3.2.17 and v3.3.6, it fixes the issue. Pid: 0, comm: swapper/0 Not tainted 3.2.17-x86_64 #12 Call Trace: <IRQ> [<ffffffff810919da>] ? handle_irq_event_percpu+0x3a/0x140 [<ffffffff81091b29>] ? handle_irq_event+0x49/0x80 [<ffffffff81094e7d>] ? handle_edge_irq+0x6d/0x120 [<ffffffff81229088>] ? __xen_evtchn_do_upcall+0x1b8/0x280 [<ffffffff8122a442>] ? xen_evtchn_do_upcall+0x22/0x40 [<ffffffff8133f4fe>] ? xen_do_hypervisor_callback+0x1e/0x30 <EOI> [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 [<ffffffff8100768c>] ? xen_safe_halt+0xc/0x20 [<ffffffff81013563>] ? default_idle+0x23/0x40 [<ffffffff8100b073>] ? cpu_idle+0x63/0xb0 [<ffffffff81654c43>] ? start_kernel+0x362/0x36d [<ffffffff81657491>] ? xen_start_kernel+0x558/0x55e Code: 39 ed 0f 84 1c 02 00 00 44 8b 7b 48 4c 8b 73 50 41 83 ef 01 41 21 ef 49 6b c7 70 4d 8b 64 06 40 49 69 c4 d0 00 00 00 48 8d 14 03 <48> 8b 8a 78 02 00 00 48 89 4c 24 10 80 ba 09 02 00 00 00 74 6d RIP [<ffffffff8125ed66>] blkif_interrupt+0x66/0x320 RSP <ffff88001fc03e18> ---[ end trace dfd4e5623eb06620 ]--- Regards, -- William ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-20 22:30 swap: don't do discard if no discard option added William Dauchy @ 2012-05-21 18:15 ` Konrad Rzeszutek Wilk 2012-05-21 21:02 ` William Dauchy 2012-05-26 18:29 ` Hugh Dickins 0 siblings, 2 replies; 12+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-05-21 18:15 UTC (permalink / raw) To: William Dauchy, shli Cc: stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings On Mon, May 21, 2012 at 12:30:45AM +0200, William Dauchy wrote: > Hello, > > On Xen, when booting a guest with a system disk and an additional swap > disk I'm getting a calltrace. > xen hypervisor: 4.1.2; linux dom0: v3.3.6; linux guest: v3.2.17 > When booting without a swap disk, I don't have the issue. > I also tested a guest with v3.3.6: same problem. But from v3.4-rc2, > the issue is fixed. > I cherry-picked: > 052b198 swap: don't do discard if no discard option added So you are asking for 052b198 to be back-ported. I am OK with that but I think Shaohua needs to Ack that and ask Greg to put it on stable@kernel.org > Applied and tested on top of v3.2.17 and v3.3.6, it fixes the issue. > > Pid: 0, comm: swapper/0 Not tainted 3.2.17-x86_64 #12 > Call Trace: > <IRQ> > [<ffffffff810919da>] ? handle_irq_event_percpu+0x3a/0x140 > [<ffffffff81091b29>] ? handle_irq_event+0x49/0x80 > [<ffffffff81094e7d>] ? handle_edge_irq+0x6d/0x120 > [<ffffffff81229088>] ? __xen_evtchn_do_upcall+0x1b8/0x280 > [<ffffffff8122a442>] ? xen_evtchn_do_upcall+0x22/0x40 > [<ffffffff8133f4fe>] ? xen_do_hypervisor_callback+0x1e/0x30 > <EOI> > [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 > [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 > [<ffffffff8100768c>] ? xen_safe_halt+0xc/0x20 > [<ffffffff81013563>] ? default_idle+0x23/0x40 > [<ffffffff8100b073>] ? cpu_idle+0x63/0xb0 > [<ffffffff81654c43>] ? start_kernel+0x362/0x36d > [<ffffffff81657491>] ? xen_start_kernel+0x558/0x55e > Code: 39 ed 0f 84 1c 02 00 00 44 8b 7b 48 4c 8b 73 50 41 83 ef 01 41 > 21 ef 49 6b c7 70 4d 8b 64 06 40 49 69 c4 d0 00 00 00 48 8d 14 03 <48> > 8b 8a 78 02 00 00 48 89 4c 24 10 80 ba 09 02 00 00 00 74 6d > RIP [<ffffffff8125ed66>] blkif_interrupt+0x66/0x320 > RSP <ffff88001fc03e18> > ---[ end trace dfd4e5623eb06620 ]--- > > Regards, > -- > William > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-21 18:15 ` [Xen-devel] " Konrad Rzeszutek Wilk @ 2012-05-21 21:02 ` William Dauchy 2012-05-24 18:50 ` Greg Kroah-Hartman 2012-05-26 18:29 ` Hugh Dickins 1 sibling, 1 reply; 12+ messages in thread From: William Dauchy @ 2012-05-21 21:02 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: shli, stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings Hello, On Mon, May 21, 2012 at 8:15 PM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > So you are asking for 052b198 to be back-ported. > I am OK with that but I think Shaohua needs to Ack that and > ask Greg to put it on stable@kernel.org Yes, since I didn't find the official process to propose an already-in-tree commit to stable@ (http://kernel.org/doc/Documentation/stable_kernel_rules.txt), I was just asking around, maybe to get Shaohua feedback. I guess it meets the requirements to be integrated in stable; tested on my side in 3.2.x and 3.3.x and fixing a precise issue. Regards, -- William ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-21 21:02 ` William Dauchy @ 2012-05-24 18:50 ` Greg Kroah-Hartman 2012-05-25 21:19 ` William Dauchy 0 siblings, 1 reply; 12+ messages in thread From: Greg Kroah-Hartman @ 2012-05-24 18:50 UTC (permalink / raw) To: William Dauchy Cc: Konrad Rzeszutek Wilk, shli, stable, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings On Mon, May 21, 2012 at 11:02:26PM +0200, William Dauchy wrote: > Hello, > > On Mon, May 21, 2012 at 8:15 PM, Konrad Rzeszutek Wilk > <konrad.wilk@oracle.com> wrote: > > So you are asking for 052b198 to be back-ported. > > I am OK with that but I think Shaohua needs to Ack that and > > ask Greg to put it on stable@kernel.org > > Yes, since I didn't find the official process to propose an > already-in-tree commit to stable@ > (http://kernel.org/doc/Documentation/stable_kernel_rules.txt), I was > just asking around, maybe to get Shaohua feedback. > > I guess it meets the requirements to be integrated in stable; tested > on my side in 3.2.x and 3.3.x and fixing a precise issue. Now applied to the 3.3.x tree, thanks. greg k-h ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-24 18:50 ` Greg Kroah-Hartman @ 2012-05-25 21:19 ` William Dauchy 2012-05-26 15:30 ` Ben Hutchings 0 siblings, 1 reply; 12+ messages in thread From: William Dauchy @ 2012-05-25 21:19 UTC (permalink / raw) To: Greg Kroah-Hartman, Ben Hutchings Cc: Konrad Rzeszutek Wilk, shli, stable, xen-devel, Shaohua Li, linux-kernel On Thu, May 24, 2012 at 8:50 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > Now applied to the 3.3.x tree, thanks. Thanks. Ben, do you plan to apply it on top of the 3.2.x tree? Regards, -- William ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-25 21:19 ` William Dauchy @ 2012-05-26 15:30 ` Ben Hutchings 0 siblings, 0 replies; 12+ messages in thread From: Ben Hutchings @ 2012-05-26 15:30 UTC (permalink / raw) To: William Dauchy Cc: Greg Kroah-Hartman, Konrad Rzeszutek Wilk, shli, stable, xen-devel, Shaohua Li, linux-kernel [-- Attachment #1: Type: text/plain, Size: 395 bytes --] On Fri, 2012-05-25 at 23:19 +0200, William Dauchy wrote: > On Thu, May 24, 2012 at 8:50 PM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > Now applied to the 3.3.x tree, thanks. > > Thanks. > > Ben, do you plan to apply it on top of the 3.2.x tree? Just added it to the queue, thanks. Ben. -- Ben Hutchings You can't have everything. Where would you put it? [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 828 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-21 18:15 ` [Xen-devel] " Konrad Rzeszutek Wilk 2012-05-21 21:02 ` William Dauchy @ 2012-05-26 18:29 ` Hugh Dickins 2012-05-29 14:47 ` Konrad Rzeszutek Wilk 1 sibling, 1 reply; 12+ messages in thread From: Hugh Dickins @ 2012-05-26 18:29 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: William Dauchy, shli, stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings On Mon, 21 May 2012, Konrad Rzeszutek Wilk wrote: > On Mon, May 21, 2012 at 12:30:45AM +0200, William Dauchy wrote: > > Hello, > > > > On Xen, when booting a guest with a system disk and an additional swap > > disk I'm getting a calltrace. > > xen hypervisor: 4.1.2; linux dom0: v3.3.6; linux guest: v3.2.17 > > When booting without a swap disk, I don't have the issue. > > I also tested a guest with v3.3.6: same problem. But from v3.4-rc2, > > the issue is fixed. > > I cherry-picked: > > > 052b198 swap: don't do discard if no discard option added > > So you are asking for 052b198 to be back-ported. > > I am OK with that but I think Shaohua needs to Ack that and > ask Greg to put it on stable@kernel.org Since that commit did indeed go into v3.4, I won't quarrel with it now going to stable. But the commit went in to work around the slow discard implementation on OCZ Vertex II SSDs. Please, could someone explain to me the meaning of the stacktrace below (which is missing a WARNING or BUG line?), and how disabling swap discard fixes it? At present I see no connection (beyond the fact that the patch fixes the symptom): in the absence of understanding, I have to beware that the underlying issue may remain unfixed. Hugh > > > > > Applied and tested on top of v3.2.17 and v3.3.6, it fixes the issue. > > > > Pid: 0, comm: swapper/0 Not tainted 3.2.17-x86_64 #12 > > Call Trace: > > <IRQ> > > [<ffffffff810919da>] ? handle_irq_event_percpu+0x3a/0x140 > > [<ffffffff81091b29>] ? handle_irq_event+0x49/0x80 > > [<ffffffff81094e7d>] ? handle_edge_irq+0x6d/0x120 > > [<ffffffff81229088>] ? __xen_evtchn_do_upcall+0x1b8/0x280 > > [<ffffffff8122a442>] ? xen_evtchn_do_upcall+0x22/0x40 > > [<ffffffff8133f4fe>] ? xen_do_hypervisor_callback+0x1e/0x30 > > <EOI> > > [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 > > [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 > > [<ffffffff8100768c>] ? xen_safe_halt+0xc/0x20 > > [<ffffffff81013563>] ? default_idle+0x23/0x40 > > [<ffffffff8100b073>] ? cpu_idle+0x63/0xb0 > > [<ffffffff81654c43>] ? start_kernel+0x362/0x36d > > [<ffffffff81657491>] ? xen_start_kernel+0x558/0x55e > > Code: 39 ed 0f 84 1c 02 00 00 44 8b 7b 48 4c 8b 73 50 41 83 ef 01 41 > > 21 ef 49 6b c7 70 4d 8b 64 06 40 49 69 c4 d0 00 00 00 48 8d 14 03 <48> > > 8b 8a 78 02 00 00 48 89 4c 24 10 80 ba 09 02 00 00 00 74 6d > > RIP [<ffffffff8125ed66>] blkif_interrupt+0x66/0x320 > > RSP <ffff88001fc03e18> > > ---[ end trace dfd4e5623eb06620 ]--- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-26 18:29 ` Hugh Dickins @ 2012-05-29 14:47 ` Konrad Rzeszutek Wilk 2012-05-30 20:29 ` William Dauchy 2012-05-31 23:04 ` Hugh Dickins 0 siblings, 2 replies; 12+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-05-29 14:47 UTC (permalink / raw) To: Hugh Dickins Cc: William Dauchy, shli, stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings On Sat, May 26, 2012 at 11:29:37AM -0700, Hugh Dickins wrote: > On Mon, 21 May 2012, Konrad Rzeszutek Wilk wrote: > > On Mon, May 21, 2012 at 12:30:45AM +0200, William Dauchy wrote: > > > Hello, > > > > > > On Xen, when booting a guest with a system disk and an additional swap > > > disk I'm getting a calltrace. > > > xen hypervisor: 4.1.2; linux dom0: v3.3.6; linux guest: v3.2.17 > > > When booting without a swap disk, I don't have the issue. > > > I also tested a guest with v3.3.6: same problem. But from v3.4-rc2, > > > the issue is fixed. > > > I cherry-picked: > > > > > 052b198 swap: don't do discard if no discard option added > > > > So you are asking for 052b198 to be back-ported. > > > > I am OK with that but I think Shaohua needs to Ack that and > > ask Greg to put it on stable@kernel.org > > Since that commit did indeed go into v3.4, I won't quarrel with it > now going to stable. > > But the commit went in to work around the slow discard implementation > on OCZ Vertex II SSDs. > > Please, could someone explain to me the meaning of the stacktrace > below (which is missing a WARNING or BUG line?), and how disabling > swap discard fixes it? I think I know and just narrowed down the issue this Friday. William, could you please apply the patch outlined in https://bugzilla.redhat.com/show_bug.cgi?id=824641 to your dom0 and see if that (so do not have 052b198 in your branch) > > At present I see no connection (beyond the fact that the patch fixes > the symptom): in the absence of understanding, I have to beware that > the underlying issue may remain unfixed. <nods> > > Hugh > > > > > > > > > > Applied and tested on top of v3.2.17 and v3.3.6, it fixes the issue. > > > > > > Pid: 0, comm: swapper/0 Not tainted 3.2.17-x86_64 #12 > > > Call Trace: > > > <IRQ> > > > [<ffffffff810919da>] ? handle_irq_event_percpu+0x3a/0x140 > > > [<ffffffff81091b29>] ? handle_irq_event+0x49/0x80 > > > [<ffffffff81094e7d>] ? handle_edge_irq+0x6d/0x120 > > > [<ffffffff81229088>] ? __xen_evtchn_do_upcall+0x1b8/0x280 > > > [<ffffffff8122a442>] ? xen_evtchn_do_upcall+0x22/0x40 > > > [<ffffffff8133f4fe>] ? xen_do_hypervisor_callback+0x1e/0x30 > > > <EOI> > > > [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 > > > [<ffffffff810013aa>] ? hypercall_page+0x3aa/0x1000 > > > [<ffffffff8100768c>] ? xen_safe_halt+0xc/0x20 > > > [<ffffffff81013563>] ? default_idle+0x23/0x40 > > > [<ffffffff8100b073>] ? cpu_idle+0x63/0xb0 > > > [<ffffffff81654c43>] ? start_kernel+0x362/0x36d > > > [<ffffffff81657491>] ? xen_start_kernel+0x558/0x55e > > > Code: 39 ed 0f 84 1c 02 00 00 44 8b 7b 48 4c 8b 73 50 41 83 ef 01 41 > > > 21 ef 49 6b c7 70 4d 8b 64 06 40 49 69 c4 d0 00 00 00 48 8d 14 03 <48> > > > 8b 8a 78 02 00 00 48 89 4c 24 10 80 ba 09 02 00 00 00 74 6d > > > RIP [<ffffffff8125ed66>] blkif_interrupt+0x66/0x320 > > > RSP <ffff88001fc03e18> > > > ---[ end trace dfd4e5623eb06620 ]--- > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-29 14:47 ` Konrad Rzeszutek Wilk @ 2012-05-30 20:29 ` William Dauchy 2012-05-30 21:16 ` Konrad Rzeszutek Wilk 2012-05-31 23:04 ` Hugh Dickins 1 sibling, 1 reply; 12+ messages in thread From: William Dauchy @ 2012-05-30 20:29 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: Hugh Dickins, shli, stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings Hello Konrad, On Tue, May 29, 2012 at 4:47 PM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > I think I know and just narrowed down the issue this Friday. > William, could you please apply the patch outlined in > https://bugzilla.redhat.com/show_bug.cgi?id=824641 > to your dom0 and see if that (so do not have 052b198 in your branch) I applied the patch on dom0 and removed 052b198 from my virtual machine and it worked. Regards, -- William ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-30 20:29 ` William Dauchy @ 2012-05-30 21:16 ` Konrad Rzeszutek Wilk 2012-05-30 21:33 ` William Dauchy 0 siblings, 1 reply; 12+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-05-30 21:16 UTC (permalink / raw) To: William Dauchy Cc: Hugh Dickins, shli, stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings On Wed, May 30, 2012 at 10:29:16PM +0200, William Dauchy wrote: > Hello Konrad, > > On Tue, May 29, 2012 at 4:47 PM, Konrad Rzeszutek Wilk > <konrad.wilk@oracle.com> wrote: > > I think I know and just narrowed down the issue this Friday. > > William, could you please apply the patch outlined in > > https://bugzilla.redhat.com/show_bug.cgi?id=824641 > > to your dom0 and see if that (so do not have 052b198 in your branch) > > I applied the patch on dom0 and removed 052b198 from my virtual > machine and it worked. Great. Is it OK to attach a Tested-by tag to the patch with your name? > > Regards, > -- > William > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-30 21:16 ` Konrad Rzeszutek Wilk @ 2012-05-30 21:33 ` William Dauchy 0 siblings, 0 replies; 12+ messages in thread From: William Dauchy @ 2012-05-30 21:33 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: Hugh Dickins, shli, stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings On Wed, May 30, 2012 at 11:16 PM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > Great. Is it OK to attach a Tested-by tag to the patch with your name? Sure. -- William ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] swap: don't do discard if no discard option added 2012-05-29 14:47 ` Konrad Rzeszutek Wilk 2012-05-30 20:29 ` William Dauchy @ 2012-05-31 23:04 ` Hugh Dickins 1 sibling, 0 replies; 12+ messages in thread From: Hugh Dickins @ 2012-05-31 23:04 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: William Dauchy, shli, stable, Greg Kroah-Hartman, xen-devel, Shaohua Li, linux-kernel, Ben Hutchings On Tue, 29 May 2012, Konrad Rzeszutek Wilk wrote: > > I think I know and just narrowed down the issue this Friday. > > William, could you please apply the patch outlined in > https://bugzilla.redhat.com/show_bug.cgi?id=824641 > to your dom0 and see if that (so do not have 052b198 in your branch) > > > > > At present I see no connection (beyond the fact that the patch fixes > > the symptom): in the absence of understanding, I have to beware that > > the underlying issue may remain unfixed. > > <nods> Thanks a lot for pursuing that to a much more satisfying conclusion. Hugh ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-05-31 23:04 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-05-20 22:30 swap: don't do discard if no discard option added William Dauchy 2012-05-21 18:15 ` [Xen-devel] " Konrad Rzeszutek Wilk 2012-05-21 21:02 ` William Dauchy 2012-05-24 18:50 ` Greg Kroah-Hartman 2012-05-25 21:19 ` William Dauchy 2012-05-26 15:30 ` Ben Hutchings 2012-05-26 18:29 ` Hugh Dickins 2012-05-29 14:47 ` Konrad Rzeszutek Wilk 2012-05-30 20:29 ` William Dauchy 2012-05-30 21:16 ` Konrad Rzeszutek Wilk 2012-05-30 21:33 ` William Dauchy 2012-05-31 23:04 ` Hugh Dickins
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).