xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andre Przywara <andre.przywara@amd.com>,
	jeremy@goop.org, xen-devel@lists.xensource.com,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jacob Shin <jacob.shin@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org, Borislav Petkov <borislav.petkov@amd.com>,
	Jan Beulich <JBeulich@suse.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>
Subject: [PATCH] x86, AMD: Fix crash as Xen Dom0 on AMD Trinity systems
Date: Wed, 30 May 2012 19:47:10 +0200	[thread overview]
Message-ID: <1338400030-8920-1-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <20120530173247.GC15635@x1.osrc.amd.com>

From: Andre Przywara <andre.przywara@amd.com>

Switch to the standard {rd,wr}msr*_safe* variants which should've been
used in the first place anyway and avoided unneeded excitation with xen.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>
Cc: stable@vger.kernel.org # 3.4+
Link: <http://lkml.kernel.org/r/1338383402-3838-1-git-send-email-andre.przywara@amd.com>
[Boris: correct commit message]
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 arch/x86/kernel/cpu/amd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 146bb6218eec..80ccd99542e6 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -586,9 +586,9 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
 	    !cpu_has(c, X86_FEATURE_TOPOEXT)) {
 		u64 val;
 
-		if (!rdmsrl_amd_safe(0xc0011005, &val)) {
+		if (!rdmsrl_safe(0xc0011005, &val)) {
 			val |= 1ULL << 54;
-			wrmsrl_amd_safe(0xc0011005, val);
+			checking_wrmsrl(0xc0011005, val);
 			rdmsrl(0xc0011005, val);
 			if (val & (1ULL << 54)) {
 				set_cpu_cap(c, X86_FEATURE_TOPOEXT);
-- 
1.7.9.3.362.g71319

  reply	other threads:[~2012-05-30 17:47 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 13:10 [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Andre Przywara
2012-05-30 13:33 ` Jan Beulich
2012-05-30 14:02   ` Andre Przywara
2012-05-30 14:23     ` Jan Beulich
2012-05-30 14:42       ` [Xen-devel] " H. Peter Anvin
2012-05-30 14:49         ` Konrad Rzeszutek Wilk
2012-05-30 15:12           ` Borislav Petkov
2012-05-30 15:40             ` Jan Beulich
2012-05-30 15:45               ` H. Peter Anvin
2012-05-30 15:58               ` Borislav Petkov
2012-05-30 14:48     ` Jacob Shin
2012-05-30 14:50       ` Konrad Rzeszutek Wilk
2012-05-30 15:03         ` Jacob Shin
2012-05-30 17:17           ` Konrad Rzeszutek Wilk
2012-05-30 17:31             ` H. Peter Anvin
2012-05-30 22:23               ` Konrad Rzeszutek Wilk
2012-05-30 17:32             ` Borislav Petkov
2012-05-30 17:47               ` Borislav Petkov [this message]
2012-05-30 17:47               ` H. Peter Anvin
2012-05-30 17:51                 ` Borislav Petkov
2012-05-30 18:00                   ` H. Peter Anvin
2012-05-30 18:17                     ` Borislav Petkov
2012-05-30 18:19                       ` Borislav Petkov
2012-05-30 18:21                         ` H. Peter Anvin
2012-05-30 18:29                           ` Borislav Petkov
2012-05-30 18:20                       ` H. Peter Anvin
2012-05-30 22:33                         ` Konrad Rzeszutek Wilk
2012-05-30 23:09                           ` H. Peter Anvin
2012-06-06  9:27                             ` Ingo Molnar
2012-06-06  9:42                               ` Borislav Petkov
2012-06-06  9:45                                 ` Ingo Molnar
2012-05-31 12:24                           ` Andre Przywara
2012-05-31 15:27                             ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-31  7:39                       ` Jan Beulich
2012-05-31 16:55                         ` Borislav Petkov
2012-05-31  7:17             ` Jan Beulich
2012-05-31 15:59               ` H. Peter Anvin
2012-05-30 14:39 ` Konrad Rzeszutek Wilk
2012-05-30 14:50   ` H. Peter Anvin
2012-05-30 14:51     ` Konrad Rzeszutek Wilk
2012-05-30 15:08     ` Jan Beulich
2012-05-30 15:15       ` H. Peter Anvin
2012-05-30 15:35         ` Jan Beulich
2012-05-30 16:48           ` Konrad Rzeszutek Wilk
2012-05-30 14:42 ` H. Peter Anvin
2012-05-30 14:55   ` Borislav Petkov
2012-05-30 14:58     ` H. Peter Anvin
2012-05-30 15:00       ` Borislav Petkov
2012-05-30 15:01         ` H. Peter Anvin
2012-05-30 15:05           ` Borislav Petkov
2012-05-30 23:31 ` H. Peter Anvin
  -- strict thread matches above, loose matches on Subject: below --
2012-06-01 10:43 [PATCH] x86, AMD: Fix " Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338400030-8920-1-git-send-email-bp@amd64.org \
    --to=bp@amd64.org \
    --cc=JBeulich@suse.com \
    --cc=andre.przywara@amd.com \
    --cc=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=jacob.shin@amd.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).