From: Dario Faggioli <raistlin@linux.it>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH v2 ]libxl: allow to allocate cpumap with specific size
Date: Fri, 01 Jun 2012 08:38:47 +0200 [thread overview]
Message-ID: <1338532727.31901.12.camel@Abyss> (raw)
In-Reply-To: <1338532240.14877.40.camel@dagon.hellion.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 936 bytes --]
On Fri, 2012-06-01 at 07:30 +0100, Ian Campbell wrote:
> > > Currently, libxl_cpumap_alloc()allocate the cpumap with size of max_cpus. In some place, we may want to allocate specific size of cpumap.
> > >
> > ... Do we? I fail to see this in the code below (you're only replacing
> > libxl_cpumap_alloc calls with new versions _always_ passing 0 as
> > max_cpus, am I right?)
>
> The change to actually use this is is a followup patch "libxl: allow to
> set more than 31 vcpus".
>
Yep, I saw that and commented on it too... If we go for this, I'd
suggest at least changing the changelog a bit and mention where/why
we're going to use it.
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-06-01 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 2:41 [PATCH v2 ]libxl: allow to allocate cpumap with specific size Zhang, Yang Z
2012-06-01 6:26 ` Dario Faggioli
2012-06-01 6:30 ` Ian Campbell
2012-06-01 6:38 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338532727.31901.12.camel@Abyss \
--to=raistlin@linux.it \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).