From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 ]libxl: allow to allocate cpumap with specific size Date: Fri, 01 Jun 2012 08:38:47 +0200 Message-ID: <1338532727.31901.12.camel@Abyss> References: <1338531971.31901.2.camel@Abyss> <1338532240.14877.40.camel@dagon.hellion.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0809171089258822139==" Return-path: In-Reply-To: <1338532240.14877.40.camel@dagon.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "Zhang, Yang Z" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --===============0809171089258822139== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-38FnUCPfRk1XdTufMK3o" --=-38FnUCPfRk1XdTufMK3o Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-06-01 at 07:30 +0100, Ian Campbell wrote:=20 > > > Currently, libxl_cpumap_alloc()allocate the cpumap with size of max_c= pus. In some place, we may want to allocate specific size of cpumap. > > > > > ... Do we? I fail to see this in the code below (you're only replacing > > libxl_cpumap_alloc calls with new versions _always_ passing 0 as > > max_cpus, am I right?) >=20 > The change to actually use this is is a followup patch "libxl: allow to > set more than 31 vcpus". >=20 Yep, I saw that and commented on it too... If we go for this, I'd suggest at least changing the changelog a bit and mention where/why we're going to use it. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-38FnUCPfRk1XdTufMK3o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk/IY3cACgkQk4XaBE3IOsQBkQCfQO4yphSQbFpWzfGamhnGSk+q QjgAn12utlMg7sCRXWTkBomjGBCUQJDB =67r7 -----END PGP SIGNATURE----- --=-38FnUCPfRk1XdTufMK3o-- --===============0809171089258822139== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0809171089258822139==--