From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1 of 1 v5] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID Date: Wed, 06 Jun 2012 13:10:02 +0200 Message-ID: <1338981002.6152.32.camel@Solace> References: <20431.13618.66803.683850@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3819417051944688331==" Return-path: In-Reply-To: <20431.13618.66803.683850@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Christoph Egger , Roger Pau Monne , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============3819417051944688331== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-w+8kv2PeV+OP+2KBhIIj" --=-w+8kv2PeV+OP+2KBhIIj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2012-06-06 at 11:47 +0100, Ian Jackson wrote: > Dario Faggioli writes ("[PATCH 1 of 1 v5] libxl: introduce LIBXL_DOMAIN_T= YPE_INVALID"): > > To avoid recent gcc complaining about: > > libxl.c: In function =E2=80=98libxl_primary_console_exec=E2=80=99: > > libxl.c:1233:9: error: case value =E2=80=984294967295=E2=80=99 not in e= numerated type =E2=80=98libxl_domain_type=E2=80=99 [-Werror=3Dswitch] > ... > > + if (type =3D=3D LIBXL_DOMAIN_TYPE_INVALID) { > > + LIBXL__LOG(ctx, LIBXL__LOG_ERROR, > > + "invalid domain type for domain %d", domid); > > + rc =3D ERROR_INVAL; > > + goto remus_fail; >=20 > This is not an expected error condition, is it ? ERROR_INVAL is for > libxl being passed impromper parameters. So I think this should be > ERROR_FAIL. >=20 Sounds reasonable, will fix. > > @@ -692,11 +699,20 @@ int libxl_domain_suspend(libxl_ctx *ctx, > > int debug =3D info !=3D NULL && info->flags & XL_SUSPEND_DEBUG; > > int rc =3D 0; > > =20 > > + if (type =3D=3D LIBXL_DOMAIN_TYPE_INVALID) { > > + LIBXL__LOG(ctx, LIBXL__LOG_ERROR, > > + "invalid domain type for domain %d", domid); > > + rc =3D ERROR_INVAL; > > + goto suspend_fail; > > + } >=20 > Is it possible for you to leave this part alone ? It's moved about a > lot in my suspend/resume series. >=20 > I will fix it up at the end of my series. >=20 Ok. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-w+8kv2PeV+OP+2KBhIIj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk/POooACgkQk4XaBE3IOsTgZgCdFS7ErVfIT3fpEY/n+ZBGM+6L QSgAmweZ/kwUNWCcQuXLjB3MSfMuSWKj =ghXD -----END PGP SIGNATURE----- --=-w+8kv2PeV+OP+2KBhIIj-- --===============3819417051944688331== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3819417051944688331==--