From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <raistlin@linux.it>
Subject: Re: [PATCH 1 of 2 v2] libxl: propagete down the error
 from libxl_domain_sched_params_set
Date: Fri, 08 Jun 2012 10:57:59 +0200
Message-ID: <1339145879.5003.0.camel@Solace>
References: <patchbomb.1339076551@Solace>
	<93ff3e5ecdee68b4f949.1339076552@Solace>
	<20432.55756.587767.208290@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7556366922351361540=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20432.55756.587767.208290@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org


--===============7556366922351361540==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-KKXsnM9DjNPx8jFX5nuK"


--=-KKXsnM9DjNPx8jFX5nuK
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2012-06-07 at 17:41 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH 1 of 2 v2] libxl: propagete down the error=
 from libxl_domain_sched_params_set"):
> > So that the caller (e.g., libxl__build_post() ) knows and can deal with=
 it.
> ...
> > -    libxl_domain_sched_params_set(CTX, domid, &info->sched_params);
> > +    if (libxl_domain_sched_params_set(CTX, domid, &info->sched_params)=
)
> > +        return ERROR_INVAL;
>=20
> This is not correct.  It should return whatever error code
> libxl_domain_sched_params_set returns, not unconditionally
> ERROR_INVAL.
>=20
Ops, you're right, sorry... New version coming!

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-KKXsnM9DjNPx8jFX5nuK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAk/RvpcACgkQk4XaBE3IOsTxbgCeNWvVYVVt5KhfDIgtxdWLmJSG
pAsAnijzkRdmf7qxO//p5GcD1pfLWk96
=SpXv
-----END PGP SIGNATURE-----

--=-KKXsnM9DjNPx8jFX5nuK--



--===============7556366922351361540==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7556366922351361540==--