From: Ian Campbell <Ian.Campbell@citrix.com>
To: Matt Wilson <msw@amazon.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools: honour --libdir when it is passed to ./configure
Date: Wed, 20 Jun 2012 17:44:26 +0100 [thread overview]
Message-ID: <1340210666.4906.79.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20120620164111.GA2640@US-SEA-R8XVZTX>
On Wed, 2012-06-20 at 17:41 +0100, Matt Wilson wrote:
> On Wed, Jun 20, 2012 at 02:10:35AM -0700, Ian Campbell wrote:
> > On Wed, 2012-06-20 at 01:46 +0100, Matt Wilson wrote:
> > >
> > > LIBLEAFDIR = lib
> > > LIBLEAFDIR_x86_32 = lib
> > > LIBLEAFDIR_x86_64 ?= lib64
> > > -LIBDIR = $(PREFIX)/$(LIBLEAFDIR)
> > > LIBDIR_x86_32 = $(PREFIX)/$(LIBLEAFDIR_x86_32)
> > > LIBDIR_x86_64 = $(PREFIX)/$(LIBLEAFDIR_x86_64)
> >
> > Roger already asked if we can somehow get rid of all the LEAFDIR stuff
> > too.
>
> That'd be lovely. I was a little worried about the python syspath
> bits, but now that I've looked to see that it uses distutils that
> should be fine.
Cool!
> > > diff -r 32034d1914a6 -r 0a592e08ac31 config/Tools.mk.in
> > > --- a/config/Tools.mk.in Thu Jun 07 19:46:57 2012 +0100
> > > +++ b/config/Tools.mk.in Wed Jun 20 00:40:15 2012 +0000
> > > @@ -1,5 +1,7 @@
> > > # Prefix and install folder
> > > PREFIX := @prefix@
> > > +exec_prefix := @exec_prefix@
> >
> > Is exec_prefix related to this change?
>
> Yes, libdir defauts to ${exec_prefix}/lib, so if we don't bring
> exec_prefix into Tooks.mk, files will land in /lib by default instead
> of /usr/lib.
Ah, makes perfect sense, thanks.
Ian.
prev parent reply other threads:[~2012-06-20 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 0:46 [PATCH] tools: honour --libdir when it is passed to ./configure Matt Wilson
2012-06-20 8:51 ` Roger Pau Monne
2012-06-20 16:44 ` Matt Wilson
2012-06-20 16:51 ` Ian Campbell
2012-06-20 18:27 ` Matt Wilson
2012-06-21 9:12 ` Roger Pau Monne
2012-06-20 9:10 ` Ian Campbell
2012-06-20 16:41 ` Matt Wilson
2012-06-20 16:44 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340210666.4906.79.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=msw@amazon.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).