From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xensource.com, Stefano.Stabellini@eu.citrix.com,
Ian.Campbell@citrix.com, tim@xen.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH WIP 2/6] xen/arm: Introduce xen_guest_init
Date: Fri, 22 Jun 2012 17:14:41 +0100 [thread overview]
Message-ID: <1340381685-22529-2-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <1340381685-22529-1-git-send-email-stefano.stabellini@eu.citrix.com>
We used to rely on a core_initcall to initialize Xen on ARM, however
core_initcalls are actually called after early consoles are initialized.
That means that hvc_xen.c is going to be initialized before Xen.
Given the lack of a better alternative, just call a new Xen
initialization function (xen_guest_init) from xen_cons_init.
xen_guest_init has to be arch independant, so write both an ARM and an
x86 implementation. The x86 implementation is currently empty because we
can be sure that xen_hvm_guest_init is called early enough.
Probably we can get rid of this as soon as we have better DT support.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
arch/arm/xen/enlighten.c | 12 ++++++++----
arch/x86/xen/enlighten.c | 8 ++++++++
drivers/tty/hvc/hvc_xen.c | 3 +++
include/xen/xen.h | 2 ++
4 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 7d76962..e1c2e4d 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -127,12 +127,16 @@ out:
}
EXPORT_SYMBOL_GPL(xen_remap_domain_mfn_range);
-void __ref xen_hvm_init_shared_info(void)
+static void __init xen_hvm_init_shared_info(void)
{
int cpu;
struct xen_add_to_physmap xatp;
static struct shared_info *shared_info_page = 0;
+ /* already setup */
+ if (shared_info_page != 0 && HYPERVISOR_shared_info == shared_info_page)
+ return;
+
if (!shared_info_page)
shared_info_page = (struct shared_info *)
get_zeroed_page(GFP_KERNEL);
@@ -161,11 +165,11 @@ void __ref xen_hvm_init_shared_info(void)
per_cpu(xen_vcpu, cpu) = &HYPERVISOR_shared_info->vcpu_info[cpu];
}
}
+core_initcall(xen_hvm_init_shared_info);
-static int __init xen_hvm_guest_init(void)
+int __init xen_guest_init(void)
{
xen_hvm_init_shared_info();
return 0;
}
-
-core_initcall(xen_hvm_guest_init);
+EXPORT_SYMBOL(xen_guest_init);
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 1f92865..0bad7b5 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1420,4 +1420,12 @@ const struct hypervisor_x86 x86_hyper_xen_hvm __refconst = {
.init_platform = xen_hvm_guest_init,
};
EXPORT_SYMBOL(x86_hyper_xen_hvm);
+
+int __init xen_guest_init(void)
+{
+ /* do nothing: rely on x86_hyper_xen_hvm for the initialization */
+ return 0;
+
+}
+EXPORT_SYMBOL(xen_guest_init);
#endif
diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
index 3ae96a9..52a98ff 100644
--- a/drivers/tty/hvc/hvc_xen.c
+++ b/drivers/tty/hvc/hvc_xen.c
@@ -578,6 +578,9 @@ static int xen_cons_init(void)
if (!xen_domain())
return 0;
+ /* retrieve xen infos */
+ xen_guest_init();
+
if (xen_initial_domain())
ops = &dom0_hvc_ops;
else {
diff --git a/include/xen/xen.h b/include/xen/xen.h
index 2c0d3a5..792a4d2 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -9,8 +9,10 @@ enum xen_domain_type {
#ifdef CONFIG_XEN
extern enum xen_domain_type xen_domain_type;
+int xen_guest_init(void);
#else
#define xen_domain_type XEN_NATIVE
+static inline int xen_guest_init(void) { return 0; }
#endif
#define xen_domain() (xen_domain_type != XEN_NATIVE)
--
1.7.2.5
next prev parent reply other threads:[~2012-06-22 16:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 16:13 [PATCH WIP 0/6] xen/arm: PV console support Stefano Stabellini
2012-06-22 16:14 ` [PATCH WIP 1/6] xen/arm: fix the shared_info and vcpu_info structs Stefano Stabellini
2012-06-22 16:14 ` Stefano Stabellini [this message]
2012-07-09 14:45 ` [Xen-devel] [PATCH WIP 2/6] xen/arm: Introduce xen_guest_init Konrad Rzeszutek Wilk
2012-07-09 15:08 ` David Vrabel
2012-07-12 11:49 ` Roger Pau Monne
2012-07-12 12:04 ` David Vrabel
2012-07-12 17:50 ` Stefano Stabellini
2012-07-12 18:00 ` Ian Campbell
2012-07-13 16:38 ` Stefano Stabellini
2012-06-22 16:14 ` [PATCH WIP 3/6] xen/arm: get privilege status Stefano Stabellini
2012-07-09 14:41 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-12 17:43 ` Stefano Stabellini
2012-06-22 16:14 ` [PATCH WIP 4/6] xen/arm: implement hvm_op Stefano Stabellini
2012-06-22 16:14 ` [PATCH WIP 5/6] xen: fix unmask_evtchn for HVM guests Stefano Stabellini
2012-06-22 16:14 ` [PATCH WIP 6/6] xen/arm: enable evtchn irqs Stefano Stabellini
2012-07-09 14:40 ` Konrad Rzeszutek Wilk
2012-07-13 17:14 ` Stefano Stabellini
2012-07-16 14:57 ` Konrad Rzeszutek Wilk
2012-07-18 16:51 ` Stefano Stabellini
2012-07-19 23:30 ` Konrad Rzeszutek Wilk
2012-07-20 11:09 ` Stefano Stabellini
2012-07-20 14:36 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-20 15:23 ` Stefano Stabellini
2012-07-25 18:43 ` Konrad Rzeszutek Wilk
2012-07-26 13:53 ` Stefano Stabellini
2012-06-22 16:26 ` [PATCH] xen/events: fix unmask_evtchn for PV on HVM guests Stefano Stabellini
2012-07-09 14:19 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-13 17:48 ` Stefano Stabellini
2012-07-16 15:14 ` Konrad Rzeszutek Wilk
2012-07-18 18:17 ` Stefano Stabellini
2012-08-22 11:20 ` Stefano Stabellini
2012-08-22 14:03 ` Konrad Rzeszutek Wilk
2012-08-22 15:01 ` Stefano Stabellini
2012-07-09 14:41 ` [PATCH WIP 1/6] xen/arm: fix the shared_info and vcpu_info structs Konrad Rzeszutek Wilk
2012-07-13 16:48 ` Stefano Stabellini
2012-07-13 17:08 ` Ian Campbell
2012-07-16 14:57 ` Konrad Rzeszutek Wilk
2012-07-18 16:46 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340381685-22529-2-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).