From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 17/21] libxl: do not leak dms->saved_state Date: Tue, 26 Jun 2012 18:55:14 +0100 Message-ID: <1340733318-21099-18-git-send-email-ian.jackson@eu.citrix.com> References: <1340733318-21099-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340733318-21099-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org This was allocated using asprintf but never freed. Use GCSPRINTF. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/libxl_create.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index b95a2fe..2d21be5 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -801,9 +801,8 @@ void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void, goto out; if (info->type == LIBXL_DOMAIN_TYPE_HVM) { - ret = asprintf(&state->saved_state, + state->saved_state = GCSPRINTF( XC_DEVICE_MODEL_RESTORE_FILE".%d", domid); - ret = (ret < 0) ? ERROR_FAIL : 0; } out: -- 1.7.2.5