From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xen.org
Cc: Christoph Egger <Christoph.Egger@amd.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH v2] autoconf: correctly parse *_INCLUDES and *_LIB env vars
Date: Thu, 28 Jun 2012 16:10:33 +0100 [thread overview]
Message-ID: <1340896233-9523-1-git-send-email-roger.pau@citrix.com> (raw)
Parse those options correctly, since the "+=" operator is not valid.
Also added CPPFLAGS, so headers checks don't give strange results.
Please rerun configure after applying.
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>
Signed-off-by: Roger Pau Monne <roger.pau@citrix.com>
---
tools/m4/set_cflags_ldflags.m4 | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/m4/set_cflags_ldflags.m4 b/tools/m4/set_cflags_ldflags.m4
index 7e357ba..cbad3c1 100644
--- a/tools/m4/set_cflags_ldflags.m4
+++ b/tools/m4/set_cflags_ldflags.m4
@@ -1,20 +1,20 @@
AC_DEFUN([AX_SET_FLAGS],
-[for cflag in $PREPEND_INCLUDES
+[for cppflag in $PREPEND_INCLUDES
do
- PREPEND_CFLAGS+=" -I$cflag"
+ PREPEND_CPPFLAGS="$PREPEND_CPPFLAGS -I$cppflag"
done
for ldflag in $PREPEND_LIB
do
- PREPEND_LDFLAGS+=" -L$ldflag"
+ PREPEND_LDFLAGS="$PREPEND_LDFLAGS -L$ldflag"
done
-for cflag in $APPEND_INCLUDES
+for cppflag in $APPEND_INCLUDES
do
- APPEND_CFLAGS+=" -I$cflag"
+ APPEND_CPPFLAGS="$APPEND_CPPFLAGS -I$cppflag"
done
for ldflag in $APPEND_LIB
do
- APPEND_LDFLAGS+=" -L$ldflag"
+ APPEND_LDFLAGS="$APPEND_LDFLAGS -L$ldflag"
done
-CFLAGS="$PREPEND_CFLAGS $CFLAGS $APPEND_CFLAGS"
+CPPFLAGS="$PREPEND_CPPFLAGS $CPPFLAGS $APPEND_CPPFLAGS"
LDFLAGS="$PREPEND_LDFLAGS $LDFLAGS $APPEND_LDFLAGS"])
--
1.7.7.5 (Apple Git-26)
next reply other threads:[~2012-06-28 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 15:10 Roger Pau Monne [this message]
2012-06-29 14:39 ` [PATCH v2] autoconf: correctly parse *_INCLUDES and *_LIB env vars Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340896233-9523-1-git-send-email-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).