From: Ian Campbell <ian.campbell@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v8 00/15] execute hotplug scripts from libxl
Date: Sun, 8 Jul 2012 12:41:52 -0600 [thread overview]
Message-ID: <1341772912.797.7.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <1341772363.797.2.camel@hastur.hellion.org.uk>
On Sun, 2012-07-08 at 14:32 -0400, Ian Campbell wrote:
> (resending as I don't think I had SMTP setup properly on my laptop -- sorry if you get this twice!)
>
> On Wed, 2012-07-04 at 07:59 -0400, Roger Pau Monne wrote:
> > This new serie (v8) fixes a code refactoring problem that was present
> > in v7 (06/15 changed code introduced by 05/15).
>
> From somewhere in here I'm seeing timeouts waiting for the b/e to go to
> state 5 when doing cd-insert on an HVM guest.
I should have said that it does actually seem to eventually succeed.
> I suspect because this is
> (or should be) turned into a virtual media change rather than an actual
> device remove and insert?
I've not really got a clue how this is suppose to work, but looking at
tools/qemu-xen-traditional-dir/xenstore.c I see things like:
fprintf(stderr,"medium change watch on ...
Experimentally it seems that ejecting the ISO can be done with:
xenstore-rm /local/domain/0/backend/qdisk/45/5632/params
and inserting with
xenstore-write /local/domain/0/backend/qdisk/45/5632/params aio:/scratch/mini.iso
(whether you can skip eject to do a change I didn't check)
So I think the libxl_cdrom_insert alg needs to be something like:
if (hvm)
rewrite params key
if stubdomid
libxl_device_disk_remove(domid)
libxl_device_disk_add(domid)
else /* pv */
libxl_device_disk_remove(domid)
libxl_device_disk_add(domid)
where the libxl_device_disk_* are actually async initiations and a chain
of callbacks
Grepping around in xend I don't see where this used to be done, maybe it
wasn't. I can't see an xm equiv to xl cd-insert...
Ian.
next prev parent reply other threads:[~2012-07-08 18:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 11:59 [PATCH v8 00/15] execute hotplug scripts from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 01/15] libxl: change ao_device_remove to ao_device Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 02/15] libxl: move device model creation prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 03/15] libxl: convert libxl_domain_destroy to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 04/15] libxl: move bootloader data strucutres and prototypes Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 05/15] libxl: refactor disk addition to take a helper Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 06/15] libxl: convert libxl__device_disk_local_attach to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 07/15] libxl: rename vifs to nics Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 08/15] libxl: convert libxl_device_disk_add to an async op Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 09/15] libxl: convert libxl_device_nic_add to an async operation Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 10/15] libxl: add option to choose who executes hotplug scripts Roger Pau Monne
2012-07-06 10:28 ` Ian Campbell
2012-07-10 9:20 ` Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 11/15] libxl: rename _IOEMU nic type to VIF_IOEMU Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 12/15] libxl: set correct nic type depending on the guest Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 13/15] libxl: use libxl__xs_path_cleanup on device_destroy Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 14/15] libxl: call hotplug scripts for disk devices from libxl Roger Pau Monne
2012-07-04 11:59 ` [PATCH v8 15/15] libxl: call hotplug scripts for nic " Roger Pau Monne
2012-07-08 18:32 ` [PATCH v8 00/15] execute hotplug scripts " Ian Campbell
2012-07-08 18:41 ` Ian Campbell [this message]
2012-07-10 11:31 ` Roger Pau Monne
2012-07-10 15:55 ` Ian Campbell
2012-07-10 16:07 ` Roger Pau Monne
2012-07-10 16:57 ` Ian Campbell
2012-07-10 17:23 ` Roger Pau Monne
2012-07-10 17:30 ` Ian Campbell
2012-07-10 17:39 ` Roger Pau Monne
2012-07-10 17:40 ` Ian Campbell
2012-07-11 9:08 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341772912.797.7.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).