From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 0 of 3 v5/leftover] Automatic NUMA placement for xl Date: Mon, 23 Jul 2012 12:38:26 +0200 Message-ID: <1343039906.4998.11.camel@Solace> References: <50093C0E.9030809@cantab.net> <5009446E.3000900@amd.com> <1342785606.26734.106.camel@zakaz.uk.xensource.com> <1342786124.26734.108.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6777629648612828351==" Return-path: In-Reply-To: <1342786124.26734.108.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andre Przywara , Stefano Stabellini , George Dunlap , Juergen Gross , Ian Jackson , xen-devel , David Vrabel List-Id: xen-devel@lists.xenproject.org --===============6777629648612828351== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-ksAPmk+0lPkZ0bZSFJfz" --=-ksAPmk+0lPkZ0bZSFJfz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-07-20 at 13:08 +0100, Ian Campbell wrote: > On Fri, 2012-07-20 at 13:00 +0100, Ian Campbell wrote: > > Even if we just blindly store the current result today as the expected > > one then when someone makes a tweak we can manually inspect the > > differences in the output and say "yes, that seems sane" or "no, that's > > mad". The need to do this will be encoded in the diff which makes the > > change (since you'd have to patch the test suite...) >=20 > BTW, this is mostly what we do for > tools/libxl/check-xl-{disk,vif}-parse. >=20 That is very nice, although our case here is a bit different. I can put together a similar script, and I can also think about some test cases and methods to check how things are going. The tricky part is I _can't_ run xl just like we do in that file, as there's not a specific command for running just the placement, and I can't invoke `cl create', can I? :-P So, it seems I should write a sort of C program from which to trigger the libxl domain creation, after taking care of intercepting and properly replacing quite a bit of functions to either nops or (e.g., in case of libxl_get_cpu_topology(), etc) proper reads of the test database. Also, this involves quite a bit of libxl internal function. Will I be able to intercept them too? Not sure, I need to check... How does that sound? I'll think about and try to implement this in next days, any thoughts that may come to your mind, do feel free to share. :-D Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-ksAPmk+0lPkZ0bZSFJfz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlANKaIACgkQk4XaBE3IOsR6JwCfWNv1oAWHy1Wq0MHVXH1fECjl w1oAoILwDWalsA6yF4Cy3Lw6oyLwx3NO =zF8m -----END PGP SIGNATURE----- --=-ksAPmk+0lPkZ0bZSFJfz-- --===============6777629648612828351== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6777629648612828351==--