From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <raistlin@linux.it>
Subject: Re: [PATCH 2 of 4 v6/leftover] xl: inform libxl if
 there was a cpumap in the config file
Date: Mon, 23 Jul 2012 15:35:56 +0200
Message-ID: <1343050556.4998.16.camel@Solace>
References: <patchbomb.1342833740@Solace>
	<ce02c3daeb7d7d8e8d26.1342833742@Solace>
	<20493.12221.272930.55159@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0884613652580015818=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20493.12221.272930.55159@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org


--===============0884613652580015818==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-O4tWpVbYk6zcW1DpIbZ/"


--=-O4tWpVbYk6zcW1DpIbZ/
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2012-07-23 at 12:04 +0100, Ian Jackson wrote:
> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -212,7 +212,8 @@ int libxl__build_pre(libxl__gc *gc, uint
> >       * call to libxl_set_vcpuaffinity_all() will do the actual placeme=
nt,
> >       * whatever that turns out to be.
> >       */
> > -    if (libxl_bitmap_is_full(&info->cpumap)) {
> > +    if (libxl_defbool_val(info->numa_placement) &&
> > +        libxl_bitmap_is_full(&info->cpumap)) {
> >          int rc =3D numa_place_domain(gc, info);
>=20
> Shouldn't this be
>=20
>   -    if (libxl_bitmap_is_full(&info->cpumap)) {
>   +    if (libxl_defbool_val(info->numa_placement)) {
>   +        if (!libxl_bitmap_is_full(&info->cpumap)) {
>   +            rc =3D ERROR_INVAL;
>   +            LOG blah blah invalid not supported
>   +            goto out;
>   +        }
>=20
> or the equivalent ?
>=20
Mmm... So that if one manage in setting numa_placement to true but also
specify a cpumap we bail out, right? Yes, I think I can go for this.

> Apart from that it looks good to me.
>=20
Cool. :-)

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-O4tWpVbYk6zcW1DpIbZ/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlANUzwACgkQk4XaBE3IOsTuQwCfUwf8FPqxXwneUC6EOztNlhAX
tVQAn0fS3Q251Vp/2CUnAZazch2ag0RG
=ktGV
-----END PGP SIGNATURE-----

--=-O4tWpVbYk6zcW1DpIbZ/--



--===============0884613652580015818==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============0884613652580015818==--