From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: [PATCH v12 01/17] libxl: fix removal of secondary consoles Date: Wed, 25 Jul 2012 12:19:05 +0100 Message-ID: <1343215161-27546-2-git-send-email-roger.pau@citrix.com> References: <1343215161-27546-1-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1343215161-27546-1-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Ian Jackson , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org Secondary consoles are processed by libxl with the rest of the devices by calling libxl__initiate_device_remove that waits for the device to reach state 6 before procceeding with the removal. When libxl is destroying the console devices, Qemu is already dead or dying, and xenconsoled completely ignores the state backend entry for console devices, since it performs the cleanup based on the result of reads/writes to the tty. Since we don't want to execute hotplug scripts for consoles, leave the behaviour as it was previously, and just nuke the backend/frontend xenstore entries by calling libxl__device_destroy. Report: http://markmail.org/message/yqgppcsdip6tnmh6 Cc: Ian Jackson Reported-by: Ian Campbell Signed-off-by: Roger Pau Monne --- tools/libxl/libxl_device.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c index a94beab..2120cfb 100644 --- a/tools/libxl/libxl_device.c +++ b/tools/libxl/libxl_device.c @@ -81,6 +81,8 @@ static int libxl__num_devices(libxl__gc *gc, uint32_t domid) for (i = 0; i < num_kinds; i++) { if (libxl__device_kind_from_string(kinds[i], &kind)) continue; + if (kind == LIBXL__DEVICE_KIND_CONSOLE) + continue; path = GCSPRINTF("/local/domain/%d/device/%s", domid, kinds[i]); devs = libxl__xs_directory(gc, XBT_NULL, path, &num_devs); @@ -512,10 +514,18 @@ void libxl__devices_destroy(libxl__egc *egc, libxl__devices_remove_state *drs) path = libxl__xs_read(gc, XBT_NULL, path); GCNEW(dev); if (path && libxl__parse_backend_path(gc, path, dev) == 0) { - aodev = &aodevs->array[numdev]; dev->domid = domid; dev->kind = kind; dev->devid = atoi(devs[j]); + if (dev->backend_kind == LIBXL__DEVICE_KIND_CONSOLE) { + /* Currently console devices can be destroyed + * synchronously by just removing xenstore entries, + * this is what libxl__device_destroy does. + */ + libxl__device_destroy(gc, dev); + continue; + } + aodev = &aodevs->array[numdev]; aodev->action = DEVICE_DISCONNECT; aodev->dev = dev; aodev->callback = libxl__ao_devices_callback; -- 1.7.7.5 (Apple Git-26)