From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH 4/4] arm: kill a guest which uses hvc with an immediate operand != XEN_HYPERCALL_TAG Date: Wed, 25 Jul 2012 14:44:01 +0000 Message-ID: <1343227442-2781-4-git-send-email-ian.campbell@citrix.com> References: <1343224660.18971.97.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1343224660.18971.97.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Stefano Stabellini , Tim Deegan , Ian Campbell List-Id: xen-devel@lists.xenproject.org At best these guests are confused/broken and at worse they are malicious. In any case we don't know that they are expecting to handle a -errno style error. Signed-off-by: Ian Campbell --- xen/arch/arm/traps.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 7b12832..c2f3135 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -475,12 +475,7 @@ static void do_trap_hypercall(struct cpu_user_regs *regs, unsigned long iss) #endif if ( iss != XEN_HYPERCALL_TAG ) - { - printk("%s %d: received an alien hypercall iss=%lx\n", __func__ , - __LINE__ , iss); - regs->r0 = -EINVAL; - return; - } + domain_crash_synchronous(); if ( regs->r12 > ARRAY_SIZE(arm_hypercall_table) ) { -- 1.7.9.1