From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <raistlin@linux.it>
Subject: Re: [PATCH v2] libxl: libxl_domain_sched_params_set
 case for ARINC 653 scheduler
Date: Wed, 25 Jul 2012 17:48:11 +0200
Message-ID: <1343231291.21187.6.camel@Abyss>
References: <c6d90859a30a996ac524.1343230932@arlpc33>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0941589290858408031=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <c6d90859a30a996ac524.1343230932@arlpc33>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Kane <Andrew.Kane@dornerworks.com>
Cc: george.dunlap@eu.citrix.com, xen-devel@lists.xensource.com, Steve.VanderLeest@dornerworks.com, Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org


--===============0941589290858408031==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-EX2XWC2OmH8dy0oQm6NV"


--=-EX2XWC2OmH8dy0oQm6NV
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2012-07-25 at 11:42 -0400, Andrew Kane wrote:=20
> Implements sched_arinc653_domain_set to match the existing API. Currently=
,
> there is no domain-specific configuration when using the ARINC 653 schedu=
ler,
> so we simply return success.
>=20
> Signed-off-by: Andrew Kane <Andrew.Kane@dornerworks.com>
>=20
Hi again Andrew,

> static int sched_credit_domain_get(libxl__gc *gc, uint32_t domid,
>                                     libxl_domain_sched_params *scinfo)
>  {
> @@ -3909,6 +3917,9 @@ int libxl_domain_sched_params_set(libxl_
>      case LIBXL_SCHEDULER_CREDIT2:
>          ret=3Dsched_credit2_domain_set(gc, domid, scinfo);
>          break;
> +    case LIBXL_SCHEDULER_ARINC653:
> +        ret=3Dsched_arinc653_domain_set(gc, domid, scinfo);
> +        break;
>      default:
>          LOG(ERROR, "Unknown scheduler");
>          ret=3DERROR_INVAL;
>
I don't know if you've seen it, as I said it in my second e-mail, while
replying to you, so I'm asking here again. Is it ok that you need to do
this for libxl_domain_sched_params_set() bit *NOT* for
libxl_domain_sched_params_get()? If it is, sorry for bothering... If
not, you probably should add that too. :-)

To me it seems it could be needed, but it might well be me not knowing
enough of ARINC's interface. :-P

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



--=-EX2XWC2OmH8dy0oQm6NV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlAQFTsACgkQk4XaBE3IOsRr3ACfcwMK1i11B8Y6u3T0YHIK0qJN
apEAni/5iNPLI+dVLEiwdGTc6jkPyE25
=/sBR
-----END PGP SIGNATURE-----

--=-EX2XWC2OmH8dy0oQm6NV--



--===============0941589290858408031==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============0941589290858408031==--