[PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Andrew Kane]

Implements sched_arinc653_domain_set to match the existing API. Currently,
there is no domain-specific configuration when using the ARINC 653 scheduler,
so we simply return success.

Signed-off-by: Andrew Kane <Andrew.Kane@dornerworks.com>

---
Changed since v1:
  * changed comment to C-style (/* */)

diff -r 4a28c496acbf -r c6d90859a30a tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Mon Jul 23 17:58:33 2012 +0100
+++ b/tools/libxl/libxl.c	Wed Jul 25 11:40:25 2012 -0400
@@ -3642,6 +3642,14 @@ libxl_scheduler libxl_get_scheduler(libx
     return sched;
 }
 
+static int sched_arinc653_domain_set(libxl__gc *gc, uint32_t domid,
+                                     const libxl_domain_sched_params *scinfo)
+{
+    /* Currently, the ARINC 653 scheduler does not take any domain-specific
+         configuration, so we simply return success. */
+    return 0;
+}
+
 static int sched_credit_domain_get(libxl__gc *gc, uint32_t domid,
                                    libxl_domain_sched_params *scinfo)
 {
@@ -3909,6 +3917,9 @@ int libxl_domain_sched_params_set(libxl_
     case LIBXL_SCHEDULER_CREDIT2:
         ret=sched_credit2_domain_set(gc, domid, scinfo);
         break;
+    case LIBXL_SCHEDULER_ARINC653:
+        ret=sched_arinc653_domain_set(gc, domid, scinfo);
+        break;
     default:
         LOG(ERROR, "Unknown scheduler");
         ret=ERROR_INVAL;

Re: [PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Ian Campbell]

On Wed, 2012-07-25 at 16:42 +0100, Andrew Kane wrote:
> Implements sched_arinc653_domain_set to match the existing API. Currently,
> there is no domain-specific configuration when using the ARINC 653 scheduler,
> so we simply return success.
> 
> Signed-off-by: Andrew Kane <Andrew.Kane@dornerworks.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

There's no need for an equivalent in the get path like Dario suggested?

> 
> ---
> Changed since v1:
>   * changed comment to C-style (/* */)
> 
> diff -r 4a28c496acbf -r c6d90859a30a tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c	Mon Jul 23 17:58:33 2012 +0100
> +++ b/tools/libxl/libxl.c	Wed Jul 25 11:40:25 2012 -0400
> @@ -3642,6 +3642,14 @@ libxl_scheduler libxl_get_scheduler(libx
>      return sched;
>  }
>  
> +static int sched_arinc653_domain_set(libxl__gc *gc, uint32_t domid,
> +                                     const libxl_domain_sched_params *scinfo)
> +{
> +    /* Currently, the ARINC 653 scheduler does not take any domain-specific
> +         configuration, so we simply return success. */
> +    return 0;
> +}
> +
>  static int sched_credit_domain_get(libxl__gc *gc, uint32_t domid,
>                                     libxl_domain_sched_params *scinfo)
>  {
> @@ -3909,6 +3917,9 @@ int libxl_domain_sched_params_set(libxl_
>      case LIBXL_SCHEDULER_CREDIT2:
>          ret=sched_credit2_domain_set(gc, domid, scinfo);
>          break;
> +    case LIBXL_SCHEDULER_ARINC653:
> +        ret=sched_arinc653_domain_set(gc, domid, scinfo);
> +        break;
>      default:
>          LOG(ERROR, "Unknown scheduler");
>          ret=ERROR_INVAL;

Re: [PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Ian Campbell]

On Wed, 2012-07-25 at 16:45 +0100, Ian Campbell wrote:
> On Wed, 2012-07-25 at 16:42 +0100, Andrew Kane wrote:
> > Implements sched_arinc653_domain_set to match the existing API. Currently,
> > there is no domain-specific configuration when using the ARINC 653 scheduler,
> > so we simply return success.
> > 
> > Signed-off-by: Andrew Kane <Andrew.Kane@dornerworks.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> There's no need for an equivalent in the get path like Dario suggested?

Applied, please send the get one separately if it is needed.

Re: [PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1609 bytes --]

On Wed, 2012-07-25 at 11:42 -0400, Andrew Kane wrote: 
> Implements sched_arinc653_domain_set to match the existing API. Currently,
> there is no domain-specific configuration when using the ARINC 653 scheduler,
> so we simply return success.
> 
> Signed-off-by: Andrew Kane <Andrew.Kane@dornerworks.com>
> 
Hi again Andrew,

> static int sched_credit_domain_get(libxl__gc *gc, uint32_t domid,
>                                     libxl_domain_sched_params *scinfo)
>  {
> @@ -3909,6 +3917,9 @@ int libxl_domain_sched_params_set(libxl_
>      case LIBXL_SCHEDULER_CREDIT2:
>          ret=sched_credit2_domain_set(gc, domid, scinfo);
>          break;
> +    case LIBXL_SCHEDULER_ARINC653:
> +        ret=sched_arinc653_domain_set(gc, domid, scinfo);
> +        break;
>      default:
>          LOG(ERROR, "Unknown scheduler");
>          ret=ERROR_INVAL;
>
I don't know if you've seen it, as I said it in my second e-mail, while
replying to you, so I'm asking here again. Is it ok that you need to do
this for libxl_domain_sched_params_set() bit *NOT* for
libxl_domain_sched_params_get()? If it is, sorry for bothering... If
not, you probably should add that too. :-)

To me it seems it could be needed, but it might well be me not knowing
enough of ARINC's interface. :-P

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Andrew Kane]

Dario and Ian,

On Jul 25, 2012, at 11:48 AM, Dario Faggioli wrote:

> On Wed, 2012-07-25 at 11:42 -0400, Andrew Kane wrote: 
>> Implements sched_arinc653_domain_set to match the existing API. Currently,
>> there is no domain-specific configuration when using the ARINC 653 scheduler,
>> so we simply return success.
>> 
>> Signed-off-by: Andrew Kane <Andrew.Kane@dornerworks.com>
>> 
> Hi again Andrew,
> 
>> static int sched_credit_domain_get(libxl__gc *gc, uint32_t domid,
>>                                    libxl_domain_sched_params *scinfo)
>> {
>> @@ -3909,6 +3917,9 @@ int libxl_domain_sched_params_set(libxl_
>>     case LIBXL_SCHEDULER_CREDIT2:
>>         ret=sched_credit2_domain_set(gc, domid, scinfo);
>>         break;
>> +    case LIBXL_SCHEDULER_ARINC653:
>> +        ret=sched_arinc653_domain_set(gc, domid, scinfo);
>> +        break;
>>     default:
>>         LOG(ERROR, "Unknown scheduler");
>>         ret=ERROR_INVAL;
>> 
> I don't know if you've seen it, as I said it in my second e-mail, while
> replying to you, so I'm asking here again. Is it ok that you need to do
> this for libxl_domain_sched_params_set() bit *NOT* for
> libxl_domain_sched_params_get()? If it is, sorry for bothering... If
> not, you probably should add that too. :-)

We would like to delay implementing libxl_domain_sched_params_get and the
associated xl call structure until we have integrated our in-house
configuration tool with xl. Otherwise we'd have a long call tree to nowhere
and an xl subcommand that doesn't do anything. =)

Regards,
- Andrew

> 
> To me it seems it could be needed, but it might well be me not knowing
> enough of ARINC's interface. :-P
> 
> Thanks and Regards,
> Dario
> 
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
> 
-- 
Andrew Kane
Computer Engineering Intern, DornerWorks Ltd.

Re: [PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1028 bytes --]

On Wed, 2012-07-25 at 14:11 -0400, Andrew Kane wrote: 
> We would like to delay implementing libxl_domain_sched_params_get and the
> associated xl call structure until we have integrated our in-house
> configuration tool with xl. Otherwise we'd have a long call tree to nowhere
> and an xl subcommand that doesn't do anything. =)
>
That sounds reasonable. I  was only asking because, with the current
code, invoking libxl_domain_sched_params_get(), with the ARINC scheduler
as a parameter, would result in the call failing and in an error message
saying "Unknown scheduler".

However, you're the sole users of it that I know of, so, if you're fine
with that, and nobody else complains, I'm fine with it too. :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel