From: Dario Faggioli <raistlin@linux.it>
To: Andre Przywara <andre.przywara@amd.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Juergen Gross <juergen.gross@ts.fujitsu.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 2 of 4 v7/leftover] libxl: enable automatic placement of guests on NUMA nodes
Date: Thu, 26 Jul 2012 15:54:38 +0200 [thread overview]
Message-ID: <1343310878.6187.45.camel@Solace> (raw)
In-Reply-To: <5011321F.6080601@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 2298 bytes --]
On Thu, 2012-07-26 at 14:03 +0200, Andre Przywara wrote:
> I have tested this version 7 on my box in various configurations:
> 1. Homogeneous memory distribution: 8 nodes, each 16 GB
> 2. "Odd" configuration: 8 nodes, 4 have 8 GB, 4 have 16 GB
> 3 Flat memory (by using cpus="all")
>
> I created up to 32 guests with 2 VCPUs and 2 GB each and observed the
> distribution after every 8th guest.
> Another round with 2 VCPU guests, but this time with memory sizes
> varying from 512MB to 5120MB.
>
Wow, that sounds like a lot of work... Thanks a ton for doing this
Andre! :-)
> The placement was running well in all cases.
>
It's hard to describe how much I am pleased to hear this. :-P
> The only thing I saw as a little sub-optimal placement in the odd
> configuration (2) with the differently sized guests. This is probably a
> side effect of Dom0 ballooning, which is not really NUMA aware AFAIK.
> This leads to a situation, where some nodes just by chance have less
> memory than a certain guest needs and so are not considered candidates.
>
Yes, that sounds a more than possible explanation. Honestly, I think
that no matter how good we are in finding algorithms and heuristics,
there always will be some weird combination of host and guest
configurations that will lead to equally weird results.
That being said, I also think the algorithm's structure is flexible
enough to allow us trying to do better in at least some of this weird
but possible situation. For example, we surely can play with some of the
parameters we pass to libxl__get_numa_candidate() and with the
comparison function in order to deal better with asymmetrical hosts...
In the near _future_ !!
Also, instilling some NUMA-awareness in other components, such as the
ballooning machinery, should be on our todo-list, for 4.3 perhaps.
> So this patch gets my:
>
> Tested-by: Andre Przywara <andre.przywara@amd.com>
>
That's the important thing for now. :-)
Thanks again and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-07-26 13:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 14:42 [PATCH 0 of 4 v7/leftover] Automatic NUMA placement for xl Dario Faggioli
2012-07-24 14:42 ` [PATCH 1 of 4 v7/leftover] libxl: kill the need for checking and linking to libm Dario Faggioli
2012-07-25 16:40 ` Ian Campbell
2012-07-24 14:42 ` [PATCH 2 of 4 v7/leftover] libxl: enable automatic placement of guests on NUMA nodes Dario Faggioli
2012-07-26 12:03 ` Andre Przywara
2012-07-26 13:54 ` Dario Faggioli [this message]
2012-07-26 14:14 ` Ian Jackson
2012-07-26 16:00 ` Dario Faggioli
2012-07-24 14:42 ` [PATCH 3 of 4 v7/leftover] libxl: have NUMA placement deal with cpupools Dario Faggioli
2012-07-26 14:20 ` Ian Jackson
2012-07-24 14:42 ` [PATCH 4 of 4 v7/leftover] Some automatic NUMA placement documentation Dario Faggioli
2012-07-26 14:22 ` Ian Jackson
2012-07-26 14:31 ` Ian Campbell
2012-07-26 14:42 ` [PATCH 0 of 4 v7/leftover] Automatic NUMA placement for xl Ian Campbell
2012-07-26 15:47 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343310878.6187.45.camel@Solace \
--to=raistlin@linux.it \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=george.dunlap@eu.citrix.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).