xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xensource.com, Stefano.Stabellini@eu.citrix.com,
	konrad.wilk@oracle.com, Ian.Campbell@citrix.com, tim@xen.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-dev@lists.linaro.org, catalin.marinas@arm.com,
	arnd@arndb.de,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 15/24] xen/arm: receive Xen events on ARM
Date: Thu, 26 Jul 2012 16:33:57 +0100	[thread overview]
Message-ID: <1343316846-25860-15-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1207251741470.26163@kaball.uk.xensource.com>

Compile events.c on ARM.
Parse, map and enable the IRQ to get event notifications from the device
tree (node "/xen").

On ARM Linux irqs are not enabled by default:

- call enable_percpu_irq for xen_events_irq (drivers are supposed
to call enable_irq after request_irq);

- reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by
default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call
irq_startup, that is responsible for calling irq_unmask at startup time.
As a result event channels remain masked.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 arch/arm/xen/enlighten.c |   33 +++++++++++++++++++++++++++++++++
 arch/x86/xen/enlighten.c |    1 +
 arch/x86/xen/irq.c       |    1 +
 arch/x86/xen/xen-ops.h   |    1 -
 drivers/xen/events.c     |   18 +++++++++++++++---
 include/xen/events.h     |    2 ++
 6 files changed, 52 insertions(+), 4 deletions(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 854af1e..60d6d36 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -7,8 +7,11 @@
 #include <xen/grant_table.h>
 #include <xen/hvm.h>
 #include <xen/xenbus.h>
+#include <xen/events.h>
 #include <asm/xen/hypervisor.h>
 #include <asm/xen/hypercall.h>
+#include <linux/interrupt.h>
+#include <linux/irqreturn.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_irq.h>
@@ -33,6 +36,8 @@ EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 int xen_platform_pci_unplug = XEN_UNPLUG_ALL;
 EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
 
+static __read_mostly int xen_events_irq = -1;
+
 int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
 			       unsigned long addr,
 			       unsigned long mfn, int nr,
@@ -65,6 +70,9 @@ int __init xen_guest_init(void)
 	if (of_address_to_resource(node, 0, &res))
 		return -EINVAL;
 	xen_hvm_resume_frames = res.start >> PAGE_SHIFT;
+	xen_events_irq = irq_of_parse_and_map(node, 0);
+	pr_info("Xen support found, events_irq=%d gnttab_frame_pfn=%lx\n",
+			xen_events_irq, xen_hvm_resume_frames);
 	xen_domain_type = XEN_HVM_DOMAIN;
 
 	xen_setup_features();
@@ -114,3 +122,28 @@ int __init xen_guest_init(void)
 }
 EXPORT_SYMBOL_GPL(xen_guest_init);
 core_initcall(xen_guest_init);
+
+static irqreturn_t xen_arm_callback(int irq, void *arg)
+{
+	xen_hvm_evtchn_do_upcall();
+	return 0;
+}
+
+static int __init xen_init_events(void)
+{
+	if (!xen_domain() || xen_events_irq < 0)
+		return -ENODEV;
+
+	xen_init_IRQ();
+
+	if (request_percpu_irq(xen_events_irq, xen_arm_callback,
+			"events", xen_vcpu)) {
+		pr_err("Error requesting IRQ %d\n", xen_events_irq);
+		return -EINVAL;
+	}
+
+	enable_percpu_irq(xen_events_irq, 0);
+
+	return 0;
+}
+postcore_initcall(xen_init_events);
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 6131d43..5a30502 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -33,6 +33,7 @@
 #include <linux/memblock.h>
 
 #include <xen/xen.h>
+#include <xen/events.h>
 #include <xen/interface/xen.h>
 #include <xen/interface/version.h>
 #include <xen/interface/physdev.h>
diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c
index 1573376..01a4dc0 100644
--- a/arch/x86/xen/irq.c
+++ b/arch/x86/xen/irq.c
@@ -5,6 +5,7 @@
 #include <xen/interface/xen.h>
 #include <xen/interface/sched.h>
 #include <xen/interface/vcpu.h>
+#include <xen/events.h>
 
 #include <asm/xen/hypercall.h>
 #include <asm/xen/hypervisor.h>
diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h
index 202d4c1..2368295 100644
--- a/arch/x86/xen/xen-ops.h
+++ b/arch/x86/xen/xen-ops.h
@@ -35,7 +35,6 @@ void xen_set_pat(u64);
 
 char * __init xen_memory_setup(void);
 void __init xen_arch_setup(void);
-void __init xen_init_IRQ(void);
 void xen_enable_sysenter(void);
 void xen_enable_syscall(void);
 void xen_vcpu_restore(void);
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 7da65d3..9b506b2 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -31,14 +31,16 @@
 #include <linux/irqnr.h>
 #include <linux/pci.h>
 
+#ifdef CONFIG_X86
 #include <asm/desc.h>
 #include <asm/ptrace.h>
 #include <asm/irq.h>
 #include <asm/idle.h>
 #include <asm/io_apic.h>
-#include <asm/sync_bitops.h>
 #include <asm/xen/page.h>
 #include <asm/xen/pci.h>
+#endif
+#include <asm/sync_bitops.h>
 #include <asm/xen/hypercall.h>
 #include <asm/xen/hypervisor.h>
 
@@ -50,6 +52,9 @@
 #include <xen/interface/event_channel.h>
 #include <xen/interface/hvm/hvm_op.h>
 #include <xen/interface/hvm/params.h>
+#include <xen/interface/physdev.h>
+#include <xen/interface/sched.h>
+#include <asm/hw_irq.h>
 
 /*
  * This lock protects updates to the following mapping and reference-count
@@ -834,6 +839,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
 		struct irq_info *info = info_for_irq(irq);
 		WARN_ON(info == NULL || info->type != IRQT_EVTCHN);
 	}
+	irq_clear_status_flags(irq, IRQ_NOREQUEST|IRQ_NOAUTOEN);
 
 out:
 	mutex_unlock(&irq_mapping_update_lock);
@@ -1377,7 +1383,9 @@ void xen_evtchn_do_upcall(struct pt_regs *regs)
 {
 	struct pt_regs *old_regs = set_irq_regs(regs);
 
+#ifdef CONFIG_X86
 	exit_idle();
+#endif
 	irq_enter();
 
 	__xen_evtchn_do_upcall();
@@ -1786,9 +1794,9 @@ void xen_callback_vector(void)
 void xen_callback_vector(void) {}
 #endif
 
-void __init xen_init_IRQ(void)
+void xen_init_IRQ(void)
 {
-	int i, rc;
+	int i;
 
 	evtchn_to_irq = kcalloc(NR_EVENT_CHANNELS, sizeof(*evtchn_to_irq),
 				    GFP_KERNEL);
@@ -1804,6 +1812,7 @@ void __init xen_init_IRQ(void)
 
 	pirq_needs_eoi = pirq_needs_eoi_flag;
 
+#ifdef CONFIG_X86
 	if (xen_hvm_domain()) {
 		xen_callback_vector();
 		native_init_IRQ();
@@ -1811,6 +1820,7 @@ void __init xen_init_IRQ(void)
 		 * __acpi_register_gsi can point at the right function */
 		pci_xen_hvm_init();
 	} else {
+		int rc;
 		struct physdev_pirq_eoi_gmfn eoi_gmfn;
 
 		irq_ctx_init(smp_processor_id());
@@ -1826,4 +1836,6 @@ void __init xen_init_IRQ(void)
 		} else
 			pirq_needs_eoi = pirq_check_eoi_map;
 	}
+#endif
 }
+EXPORT_SYMBOL_GPL(xen_init_IRQ);
diff --git a/include/xen/events.h b/include/xen/events.h
index 04399b2..c6bfe01 100644
--- a/include/xen/events.h
+++ b/include/xen/events.h
@@ -109,4 +109,6 @@ int xen_irq_from_gsi(unsigned gsi);
 /* Determine whether to ignore this IRQ if it is passed to a guest. */
 int xen_test_irq_shared(int irq);
 
+/* initialize Xen IRQ subsystem */
+void xen_init_IRQ(void);
 #endif	/* _XEN_EVENTS_H */
-- 
1.7.2.5

  parent reply	other threads:[~2012-07-26 15:33 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 15:33 [PATCH 00/24] Introduce Xen support on ARM Stefano Stabellini
2012-07-26 15:33 ` [PATCH 01/24] arm: initial Xen support Stefano Stabellini
2012-07-26 16:30   ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-27 11:56     ` Stefano Stabellini
2012-08-01 10:42       ` Konrad Rzeszutek Wilk
     [not found]         ` <20120801104237.GB7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-06 10:55           ` Stefano Stabellini
2012-08-01 18:27   ` Rob Herring
     [not found]     ` <50197527.3070007-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-02  7:35       ` Ian Campbell
     [not found]         ` <1343892951.7571.50.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org>
2012-08-02 14:13           ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-08-06 10:46             ` Stefano Stabellini
2012-07-26 15:33 ` [PATCH 04/24] xen/arm: sync_bitops Stefano Stabellini
2012-07-26 16:37   ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-27  9:28     ` Ian Campbell
     [not found]       ` <1343381305.6812.116.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-08-01 14:35         ` Konrad Rzeszutek Wilk
     [not found]           ` <20120801143551.GI7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 16:07             ` Stefano Stabellini
2012-07-26 15:33 ` [PATCH 07/24] xen/arm: Xen detection and shared_info page mapping Stefano Stabellini
2012-07-27  9:36   ` Ian Campbell
2012-07-27 14:48     ` Stefano Stabellini
2012-07-27 14:51       ` Ian Campbell
2012-08-01 14:19   ` Konrad Rzeszutek Wilk
2012-08-01 15:45     ` Stefano Stabellini
2012-07-26 15:33 ` Stefano Stabellini [this message]
     [not found]   ` <1343316846-25860-15-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:44     ` [PATCH 15/24] xen/arm: receive Xen events on ARM Konrad Rzeszutek Wilk
2012-08-06 10:31       ` Stefano Stabellini
2012-07-26 15:33 ` [PATCH 16/24] xen/arm: implement alloc/free_xenballooned_pages with alloc_pages/kfree Stefano Stabellini
     [not found] ` <alpine.DEB.2.02.1207251741470.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-07-26 15:33   ` [PATCH 02/24] xen/arm: hypercalls Stefano Stabellini
2012-07-26 16:33     ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-27  9:17       ` Ian Campbell
     [not found]         ` <1343380659.6812.106.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-07-27 13:02           ` Stefano Stabellini
2012-07-27 13:18             ` Ian Campbell
2012-07-27 13:41               ` Stefano Stabellini
     [not found]             ` <alpine.DEB.2.02.1207271350370.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-07-27 14:21               ` Russell King - ARM Linux
2012-07-27 14:36                 ` Stefano Stabellini
2012-07-27 14:39                 ` Ian Campbell
2012-07-27 14:59                   ` Russell King - ARM Linux
2012-07-26 16:56     ` David Vrabel
     [not found]       ` <501176AF.3000607-5LkwijKnu/2sTnJN9+BGXg@public.gmane.org>
2012-07-26 17:19         ` Stefano Stabellini
2012-07-27  9:00       ` Ian Campbell
2012-07-26 19:19     ` Christopher Covington
2012-07-27  9:19       ` Ian Campbell
2012-07-27 12:56         ` Christopher Covington
2012-07-27 13:57           ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 03/24] xen/arm: page.h definitions Stefano Stabellini
2012-07-26 16:36     ` [Xen-devel] " Konrad Rzeszutek Wilk
     [not found]       ` <20120726163655.GD9222-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-07-27 13:47         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 05/24] xen/arm: empty implementation of grant_table arch specific functions Stefano Stabellini
2012-08-01 14:16     ` Konrad Rzeszutek Wilk
     [not found]       ` <20120801141624.GD7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 15:46         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 06/24] xen: missing includes Stefano Stabellini
2012-07-27  6:57     ` [Xen-devel] " Jan Beulich
2012-07-27 16:47       ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 08/24] xen/arm: Introduce xen_pfn_t for pfn and mfn types Stefano Stabellini
     [not found]     ` <1343316846-25860-8-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:22       ` Konrad Rzeszutek Wilk
2012-08-01 15:50         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 09/24] xen/arm: compile and run xenbus Stefano Stabellini
     [not found]     ` <1343316846-25860-9-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:28       ` Konrad Rzeszutek Wilk
2012-08-06 11:17         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 10/24] xen: do not compile manage, balloon, pci, acpi and cpu_hotplug on ARM Stefano Stabellini
2012-07-27  7:01     ` [Xen-devel] " Jan Beulich
2012-07-27 16:51       ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 11/24] xen/arm: introduce CONFIG_XEN " Stefano Stabellini
2012-08-01 14:34     ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-26 15:33   ` [PATCH 12/24] xen/arm: Introduce xen_guest_init Stefano Stabellini
2012-07-27  9:42     ` Ian Campbell
2012-07-27 15:54       ` Stefano Stabellini
     [not found]         ` <alpine.DEB.2.02.1207271613200.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-07-27 16:11           ` Ian Campbell
2012-08-01 14:38     ` Konrad Rzeszutek Wilk
2012-07-26 15:33   ` [PATCH 13/24] xen/arm: get privilege status Stefano Stabellini
2012-07-27  9:44     ` Ian Campbell
2012-07-27 14:25       ` Stefano Stabellini
2012-07-27 14:33         ` Ian Campbell
     [not found]           ` <1343399630.25096.4.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-08-01 14:39             ` Konrad Rzeszutek Wilk
2012-08-01 16:21               ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 14/24] xen/arm: initialize grant_table on ARM Stefano Stabellini
2012-08-01 14:40     ` Konrad Rzeszutek Wilk
     [not found]       ` <20120801144059.GL7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 17:08         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 17/24] xen: allow privcmd for HVM guests Stefano Stabellini
2012-07-27  7:04     ` [Xen-devel] " Jan Beulich
     [not found]       ` <5012598C0200007800090DB9-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2012-07-27 14:10         ` Stefano Stabellini
     [not found]           ` <alpine.DEB.2.02.1207271502480.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-08-01 14:47             ` Konrad Rzeszutek Wilk
2012-07-26 15:34   ` [PATCH 18/24] xen/arm: compile blkfront and blkback Stefano Stabellini
2012-07-27  9:48     ` Ian Campbell
     [not found]       ` <1343382495.6812.127.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-07-27 16:25         ` Stefano Stabellini
     [not found]     ` <1343316846-25860-18-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:48       ` Konrad Rzeszutek Wilk
2012-08-01 16:19         ` Stefano Stabellini
2012-07-26 15:34   ` [PATCH 19/24] xen/arm: compile netback Stefano Stabellini
2012-07-26 15:34   ` [PATCH 20/24] xen: update xen_add_to_physmap interface Stefano Stabellini
2012-08-01 14:52     ` Konrad Rzeszutek Wilk
2012-08-01 16:18       ` Stefano Stabellini
2012-08-01 18:19       ` Mukesh Rathor
2012-07-26 15:34   ` [PATCH 21/24] arm/v2m: initialize arch_timers even if v2m_timer is not present Stefano Stabellini
     [not found]     ` <1343316846-25860-21-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:52       ` Konrad Rzeszutek Wilk
     [not found]         ` <20120801145257.GQ7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 16:06           ` Stefano Stabellini
2012-07-26 15:34   ` [PATCH 22/24] ARM: enable earlyprintk=xen Stefano Stabellini
2012-07-26 15:34   ` [PATCH 23/24] hvc_xen: allow dom0_write_console for HVM guests Stefano Stabellini
2012-08-01 14:54     ` Konrad Rzeszutek Wilk
     [not found]       ` <20120801145413.GR7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 16:04         ` Stefano Stabellini
2012-07-26 15:34   ` [PATCH 24/24] [HACK] xen/arm: implement xen_remap_domain_mfn_range Stefano Stabellini
     [not found]     ` <1343316846-25860-24-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:56       ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343316846-25860-15-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).