xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org,
	linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	tim-LM2mM/qkH7s@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 09/24] xen/arm: compile and run xenbus
Date: Thu, 26 Jul 2012 16:33:51 +0100	[thread overview]
Message-ID: <1343316846-25860-9-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1207251741470.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>

bind_evtchn_to_irqhandler can legitimately return 0 (irq 0): it is not
an error.

If Linux is running as an HVM domain and is running as Dom0, use
xenstored_local_init to initialize the xenstore page and event channel.

Signed-off-by: Stefano Stabellini <stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
---
 drivers/xen/xenbus/xenbus_comms.c |    2 +-
 drivers/xen/xenbus/xenbus_probe.c |   27 +++++++++++++++++----------
 drivers/xen/xenbus/xenbus_xs.c    |    1 +
 3 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/drivers/xen/xenbus/xenbus_comms.c b/drivers/xen/xenbus/xenbus_comms.c
index 52fe7ad..c5aa55c 100644
--- a/drivers/xen/xenbus/xenbus_comms.c
+++ b/drivers/xen/xenbus/xenbus_comms.c
@@ -224,7 +224,7 @@ int xb_init_comms(void)
 		int err;
 		err = bind_evtchn_to_irqhandler(xen_store_evtchn, wake_waiting,
 						0, "xenbus", &xb_waitq);
-		if (err <= 0) {
+		if (err < 0) {
 			printk(KERN_ERR "XENBUS request irq failed %i\n", err);
 			return err;
 		}
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index b793723..3ae47c2 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -729,16 +729,23 @@ static int __init xenbus_init(void)
 	xenbus_ring_ops_init();
 
 	if (xen_hvm_domain()) {
-		uint64_t v = 0;
-		err = hvm_get_parameter(HVM_PARAM_STORE_EVTCHN, &v);
-		if (err)
-			goto out_error;
-		xen_store_evtchn = (int)v;
-		err = hvm_get_parameter(HVM_PARAM_STORE_PFN, &v);
-		if (err)
-			goto out_error;
-		xen_store_mfn = (unsigned long)v;
-		xen_store_interface = ioremap(xen_store_mfn << PAGE_SHIFT, PAGE_SIZE);
+		if (xen_initial_domain()) {
+			err = xenstored_local_init();
+			xen_store_interface =
+				phys_to_virt(xen_store_mfn << PAGE_SHIFT);
+		} else {
+			uint64_t v = 0;
+			err = hvm_get_parameter(HVM_PARAM_STORE_EVTCHN, &v);
+			if (err)
+				goto out_error;
+			xen_store_evtchn = (int)v;
+			err = hvm_get_parameter(HVM_PARAM_STORE_PFN, &v);
+			if (err)
+				goto out_error;
+			xen_store_mfn = (unsigned long)v;
+			xen_store_interface =
+				ioremap(xen_store_mfn << PAGE_SHIFT, PAGE_SIZE);
+		}
 	} else {
 		xen_store_evtchn = xen_start_info->store_evtchn;
 		xen_store_mfn = xen_start_info->store_mfn;
diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
index d1c217b..f7feb3d 100644
--- a/drivers/xen/xenbus/xenbus_xs.c
+++ b/drivers/xen/xenbus/xenbus_xs.c
@@ -44,6 +44,7 @@
 #include <linux/rwsem.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <asm/xen/hypervisor.h>
 #include <xen/xenbus.h>
 #include <xen/xen.h>
 #include "xenbus_comms.h"
-- 
1.7.2.5

  parent reply	other threads:[~2012-07-26 15:33 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 15:33 [PATCH 00/24] Introduce Xen support on ARM Stefano Stabellini
2012-07-26 15:33 ` [PATCH 01/24] arm: initial Xen support Stefano Stabellini
2012-07-26 16:30   ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-27 11:56     ` Stefano Stabellini
2012-08-01 10:42       ` Konrad Rzeszutek Wilk
     [not found]         ` <20120801104237.GB7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-06 10:55           ` Stefano Stabellini
2012-08-01 18:27   ` Rob Herring
     [not found]     ` <50197527.3070007-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-02  7:35       ` Ian Campbell
     [not found]         ` <1343892951.7571.50.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org>
2012-08-02 14:13           ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-08-06 10:46             ` Stefano Stabellini
     [not found] ` <alpine.DEB.2.02.1207251741470.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-07-26 15:33   ` [PATCH 02/24] xen/arm: hypercalls Stefano Stabellini
2012-07-26 16:33     ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-27  9:17       ` Ian Campbell
     [not found]         ` <1343380659.6812.106.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-07-27 13:02           ` Stefano Stabellini
2012-07-27 13:18             ` Ian Campbell
2012-07-27 13:41               ` Stefano Stabellini
     [not found]             ` <alpine.DEB.2.02.1207271350370.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-07-27 14:21               ` Russell King - ARM Linux
2012-07-27 14:36                 ` Stefano Stabellini
2012-07-27 14:39                 ` Ian Campbell
2012-07-27 14:59                   ` Russell King - ARM Linux
2012-07-26 16:56     ` David Vrabel
     [not found]       ` <501176AF.3000607-5LkwijKnu/2sTnJN9+BGXg@public.gmane.org>
2012-07-26 17:19         ` Stefano Stabellini
2012-07-27  9:00       ` Ian Campbell
2012-07-26 19:19     ` Christopher Covington
2012-07-27  9:19       ` Ian Campbell
2012-07-27 12:56         ` Christopher Covington
2012-07-27 13:57           ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 03/24] xen/arm: page.h definitions Stefano Stabellini
2012-07-26 16:36     ` [Xen-devel] " Konrad Rzeszutek Wilk
     [not found]       ` <20120726163655.GD9222-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-07-27 13:47         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 05/24] xen/arm: empty implementation of grant_table arch specific functions Stefano Stabellini
2012-08-01 14:16     ` Konrad Rzeszutek Wilk
     [not found]       ` <20120801141624.GD7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 15:46         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 06/24] xen: missing includes Stefano Stabellini
2012-07-27  6:57     ` [Xen-devel] " Jan Beulich
2012-07-27 16:47       ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 08/24] xen/arm: Introduce xen_pfn_t for pfn and mfn types Stefano Stabellini
     [not found]     ` <1343316846-25860-8-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:22       ` Konrad Rzeszutek Wilk
2012-08-01 15:50         ` Stefano Stabellini
2012-07-26 15:33   ` Stefano Stabellini [this message]
     [not found]     ` <1343316846-25860-9-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:28       ` [PATCH 09/24] xen/arm: compile and run xenbus Konrad Rzeszutek Wilk
2012-08-06 11:17         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 10/24] xen: do not compile manage, balloon, pci, acpi and cpu_hotplug on ARM Stefano Stabellini
2012-07-27  7:01     ` [Xen-devel] " Jan Beulich
2012-07-27 16:51       ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 11/24] xen/arm: introduce CONFIG_XEN " Stefano Stabellini
2012-08-01 14:34     ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-26 15:33   ` [PATCH 12/24] xen/arm: Introduce xen_guest_init Stefano Stabellini
2012-07-27  9:42     ` Ian Campbell
2012-07-27 15:54       ` Stefano Stabellini
     [not found]         ` <alpine.DEB.2.02.1207271613200.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-07-27 16:11           ` Ian Campbell
2012-08-01 14:38     ` Konrad Rzeszutek Wilk
2012-07-26 15:33   ` [PATCH 13/24] xen/arm: get privilege status Stefano Stabellini
2012-07-27  9:44     ` Ian Campbell
2012-07-27 14:25       ` Stefano Stabellini
2012-07-27 14:33         ` Ian Campbell
     [not found]           ` <1343399630.25096.4.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-08-01 14:39             ` Konrad Rzeszutek Wilk
2012-08-01 16:21               ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 14/24] xen/arm: initialize grant_table on ARM Stefano Stabellini
2012-08-01 14:40     ` Konrad Rzeszutek Wilk
     [not found]       ` <20120801144059.GL7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 17:08         ` Stefano Stabellini
2012-07-26 15:33   ` [PATCH 17/24] xen: allow privcmd for HVM guests Stefano Stabellini
2012-07-27  7:04     ` [Xen-devel] " Jan Beulich
     [not found]       ` <5012598C0200007800090DB9-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2012-07-27 14:10         ` Stefano Stabellini
     [not found]           ` <alpine.DEB.2.02.1207271502480.26163-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-08-01 14:47             ` Konrad Rzeszutek Wilk
2012-07-26 15:34   ` [PATCH 18/24] xen/arm: compile blkfront and blkback Stefano Stabellini
2012-07-27  9:48     ` Ian Campbell
     [not found]       ` <1343382495.6812.127.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-07-27 16:25         ` Stefano Stabellini
     [not found]     ` <1343316846-25860-18-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:48       ` Konrad Rzeszutek Wilk
2012-08-01 16:19         ` Stefano Stabellini
2012-07-26 15:34   ` [PATCH 19/24] xen/arm: compile netback Stefano Stabellini
2012-07-26 15:34   ` [PATCH 20/24] xen: update xen_add_to_physmap interface Stefano Stabellini
2012-08-01 14:52     ` Konrad Rzeszutek Wilk
2012-08-01 16:18       ` Stefano Stabellini
2012-08-01 18:19       ` Mukesh Rathor
2012-07-26 15:34   ` [PATCH 21/24] arm/v2m: initialize arch_timers even if v2m_timer is not present Stefano Stabellini
     [not found]     ` <1343316846-25860-21-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:52       ` Konrad Rzeszutek Wilk
     [not found]         ` <20120801145257.GQ7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 16:06           ` Stefano Stabellini
2012-07-26 15:34   ` [PATCH 22/24] ARM: enable earlyprintk=xen Stefano Stabellini
2012-07-26 15:34   ` [PATCH 23/24] hvc_xen: allow dom0_write_console for HVM guests Stefano Stabellini
2012-08-01 14:54     ` Konrad Rzeszutek Wilk
     [not found]       ` <20120801145413.GR7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 16:04         ` Stefano Stabellini
2012-07-26 15:34   ` [PATCH 24/24] [HACK] xen/arm: implement xen_remap_domain_mfn_range Stefano Stabellini
     [not found]     ` <1343316846-25860-24-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:56       ` Konrad Rzeszutek Wilk
2012-07-26 15:33 ` [PATCH 04/24] xen/arm: sync_bitops Stefano Stabellini
2012-07-26 16:37   ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-07-27  9:28     ` Ian Campbell
     [not found]       ` <1343381305.6812.116.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-08-01 14:35         ` Konrad Rzeszutek Wilk
     [not found]           ` <20120801143551.GI7227-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-01 16:07             ` Stefano Stabellini
2012-07-26 15:33 ` [PATCH 07/24] xen/arm: Xen detection and shared_info page mapping Stefano Stabellini
2012-07-27  9:36   ` Ian Campbell
2012-07-27 14:48     ` Stefano Stabellini
2012-07-27 14:51       ` Ian Campbell
2012-08-01 14:19   ` Konrad Rzeszutek Wilk
2012-08-01 15:45     ` Stefano Stabellini
2012-07-26 15:33 ` [PATCH 15/24] xen/arm: receive Xen events on ARM Stefano Stabellini
     [not found]   ` <1343316846-25860-15-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-01 14:44     ` Konrad Rzeszutek Wilk
2012-08-06 10:31       ` Stefano Stabellini
2012-07-26 15:33 ` [PATCH 16/24] xen/arm: implement alloc/free_xenballooned_pages with alloc_pages/kfree Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343316846-25860-9-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini-mvvwk6wmycldpfhejli6iq@public.gmane.org \
    --cc=Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tim-LM2mM/qkH7s@public.gmane.org \
    --cc=xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).