xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] libxl: fix reentrancy hazard in fd event processing
Date: Thu, 26 Jul 2012 17:23:10 +0100	[thread overview]
Message-ID: <1343319790.6812.49.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20497.20070.201426.948695@mariner.uk.xensource.com>

On Thu, 2012-07-26 at 15:04 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 1/2] libxl: fix reentrancy hazard in fd event processing"):
> > On Wed, 2012-07-25 at 17:10 +0100, Ian Jackson wrote:
> > > Ian Campbell writes ("Re: [PATCH 1/2] libxl: fix reentrancy hazard in fd event processing"):
> > > > On Fri, 2012-07-20 at 19:18 +0100, Ian Jackson wrote:
> > > ...
> > > > >   Program terminated with signal 11, Segmentation fault.
> > > > >   #0  0x00007f7ff743131b in afterpoll_check_fd (poller=<optimized out>, fds=0x7f7ff7b241c0, nfds=7, fd=-1, events=1)
> > > > >       at libxl_event.c:856
> > > > >   856             if (fds[slot].fd != fd)
> > > > 
> > > > Has Roger or you tested this now?
> > > 
> > > I still haven't tested the new version I'm afraid.
> > 
> > OK, I'll hold off on committing then.
> 
> I have now tested these as part of my testing of Roger's hotplug
> series.

Thx. Added Roger's Tested-by and my Acked-by and committed.

  reply	other threads:[~2012-07-26 16:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 18:18 [PATCH 0/2] libxl: event fixes for Roger Ian Jackson
2012-07-20 18:18 ` [PATCH 1/2] libxl: fix reentrancy hazard in fd event processing Ian Jackson
2012-07-25 16:05   ` Ian Campbell
2012-07-25 16:10     ` Ian Jackson
2012-07-25 16:33       ` Ian Campbell
2012-07-26 14:04         ` Ian Jackson
2012-07-26 16:23           ` Ian Campbell [this message]
2012-07-25 16:49     ` Roger Pau Monne
2012-07-20 18:18 ` [PATCH 2/2] libxl: do not blunder on if bootloader fails Ian Jackson
2012-07-23 11:09   ` Ian Campbell
2012-07-23 12:13     ` Ian Campbell
2012-07-20 18:22 ` [PATCH 0/2] libxl: event fixes for Roger Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343319790.6812.49.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).