From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Tim.Deegan@xen.org, Ian.Campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH v3 2/4] xen/arm: implement get/put_page_type
Date: Thu, 26 Jul 2012 19:54:50 +0100 [thread overview]
Message-ID: <1343328892-10195-2-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1207261949150.26163@kaball.uk.xensource.com>
Add a basic get_page_type and put_page_type implementation: we don't
care about typecounts so just return success.
Also remove PGT_shared_page, that is unused.
Changes in v3:
- replace get_page_type and put_page_type with an empty implementation.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
xen/arch/arm/dummy.S | 4 ----
xen/arch/arm/mm.c | 13 +++++++++++++
xen/include/asm-arm/mm.h | 1 -
3 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/xen/arch/arm/dummy.S b/xen/arch/arm/dummy.S
index baced25..2b96d22 100644
--- a/xen/arch/arm/dummy.S
+++ b/xen/arch/arm/dummy.S
@@ -22,10 +22,6 @@ DUMMY(arch_get_info_guest);
DUMMY(arch_vcpu_reset);
NOP(update_vcpu_system_time);
-/* Page Reference & Type Maintenance */
-DUMMY(get_page_type);
-DUMMY(put_page_type);
-
/* Grant Tables */
DUMMY(steal_page);
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index e963af9..96a4ca2 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -594,6 +594,19 @@ int get_page(struct page_info *page, struct domain *domain)
return 0;
}
+/* Common code requires get_page_type and put_page_type.
+ * We don't care about typecounts so we just do the minimum to make it
+ * happy. */
+int get_page_type(struct page_info *page, unsigned long type)
+{
+ return 1;
+}
+
+void put_page_type(struct page_info *page)
+{
+ return;
+}
+
void gnttab_clear_flag(unsigned long nr, uint16_t *addr)
{
/*
diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
index 53801b0..b37bd35 100644
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -71,7 +71,6 @@ struct page_info
#define PGT_none PG_mask(0, 4) /* no special uses of this page */
#define PGT_writable_page PG_mask(7, 4) /* has writable mappings? */
-#define PGT_shared_page PG_mask(8, 4) /* CoW sharable page */
#define PGT_type_mask PG_mask(15, 4) /* Bits 28-31 or 60-63. */
/* Owning guest has pinned this page to its current type? */
--
1.7.2.5
next prev parent reply other threads:[~2012-07-26 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 18:53 [PATCH v3 0/4] xen/arm: grant_table Stefano Stabellini
2012-07-26 18:54 ` [PATCH v3 1/4] xen/arm: implement page reference and grant table functions needed by grant_table.c Stefano Stabellini
2012-07-26 18:54 ` Stefano Stabellini [this message]
2012-08-02 10:08 ` [PATCH v3 2/4] xen/arm: implement get/put_page_type Ian Campbell
2012-07-26 18:54 ` [PATCH v3 3/4] xen/arm: create_p2m_entries should not call free_domheap_page Stefano Stabellini
2012-07-26 18:54 ` [PATCH v3 4/4] xen/arm: grant table Stefano Stabellini
2012-08-01 10:29 ` [PATCH v3 0/4] xen/arm: grant_table Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343328892-10195-2-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Tim.Deegan@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).