From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 09/11] libxl: remus: mark TODOs more clearly
Date: Wed, 1 Aug 2012 17:24:18 +0100 [thread overview]
Message-ID: <1343838260-17725-10-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1343838260-17725-1-git-send-email-ian.jackson@eu.citrix.com>
Change the TODOs in the remus code to "REMUS TODO" which will make
them easier to grep for later. AIUI all of these are essential for
use of remus in production.
Also add a new TODO and a new assert, to check rc on entry to
remus_checkpoint_dm_saved.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
tools/libxl/libxl_dom.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index d749983..06d5e4f 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -1110,7 +1110,7 @@ int libxl__toolstack_save(uint32_t domid, uint8_t **buf,
static int libxl__remus_domain_suspend_callback(void *data)
{
- /* TODO: Issue disk and network checkpoint reqs. */
+ /* REMUS TODO: Issue disk and network checkpoint reqs. */
return libxl__domain_suspend_common_callback(data);
}
@@ -1124,7 +1124,7 @@ static int libxl__remus_domain_resume_callback(void *data)
if (libxl_domain_resume(CTX, dss->domid, /* Fast Suspend */1))
return 0;
- /* TODO: Deal with disk. Start a new network output buffer */
+ /* REMUS TODO: Deal with disk. Start a new network output buffer */
return 1;
}
@@ -1151,8 +1151,9 @@ static void libxl__remus_domain_checkpoint_callback(void *data)
static void remus_checkpoint_dm_saved(libxl__egc *egc,
libxl__domain_suspend_state *dss, int rc)
{
- /* TODO: Wait for disk and memory ack, release network buffer */
- /* TODO: make this asynchronous */
+ /* REMUS TODO: Wait for disk and memory ack, release network buffer */
+ /* REMUS TODO: make this asynchronous */
+ assert(!rc); /* REMUS TODO handle this error properly */
usleep(dss->interval * 1000);
libxl__xc_domain_saverestore_async_callback_done(egc, &dss->shs, 1);
}
--
1.7.2.5
next prev parent reply other threads:[~2012-08-01 16:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 16:24 [PATCH v4 00/11] libxl: Assorted bugfixes Ian Jackson
2012-08-01 16:24 ` [PATCH 01/11] libxl: unify libxl__device_destroy and device_hotplug_done Ian Jackson
2012-08-02 10:11 ` Ian Campbell
2012-08-01 16:24 ` [PATCH 02/11] libxl: react correctly to bootloader pty master POLLHUP Ian Jackson
2012-08-02 10:16 ` Ian Campbell
2012-08-02 11:18 ` Ian Jackson
2012-08-01 16:24 ` [PATCH 03/11] libxl: fix device counting race in libxl__devices_destroy Ian Jackson
2012-08-02 10:18 ` Ian Campbell
2012-08-01 16:24 ` [PATCH 04/11] libxl: fix formatting of DEFINE_DEVICES_ADD Ian Jackson
2012-08-02 10:18 ` Ian Campbell
2012-08-01 16:24 ` [PATCH 05/11] libxl: abolish useless `start' parameter to libxl__add_* Ian Jackson
2012-08-02 10:19 ` Ian Campbell
2012-08-01 16:24 ` [PATCH 06/11] libxl: rename aodevs to multidev Ian Jackson
2012-08-02 10:20 ` Ian Campbell
2012-08-01 16:24 ` [PATCH 07/11] libxl: do not blunder on if bootloader fails (again) Ian Jackson
2012-08-02 10:22 ` Ian Campbell
2012-08-01 16:24 ` [PATCH 08/11] Debugging machinery for synthesising POLLHUP Ian Jackson
2012-08-01 16:24 ` Ian Jackson [this message]
2012-08-02 10:23 ` [PATCH 09/11] libxl: remus: mark TODOs more clearly Ian Campbell
2012-08-02 12:18 ` Shriram Rajagopalan
2012-08-01 16:24 ` [PATCH 10/11] libxl: remove an unused numainfo parameter Ian Jackson
2012-08-02 10:24 ` Ian Campbell
2012-08-02 11:00 ` Dario Faggioli
2012-08-01 16:24 ` [PATCH 11/11] libxl: -Wunused-parameter Ian Jackson
2012-08-02 8:59 ` Ian Campbell
2012-08-02 14:09 ` Ian Jackson
2012-08-02 10:41 ` Ian Campbell
2012-08-02 14:32 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343838260-17725-10-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).