From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: tim@xen.org, Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] arm: fix gic_init_secondary_cpu.
Date: Wed, 1 Aug 2012 16:43:57 +0000 [thread overview]
Message-ID: <1343839438-3321-1-git-send-email-ian.campbell@citrix.com> (raw)
Using spin_lock_irq here is unnecessary (interrupts are not yet enabled) and
wrong (since they will get unexpectedly renabled by spin_unlock_irq).
We can just use spin_lock/spin_unlock.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: tim@xen.org
---
Now an SMP model gets as far as hanging at dom0 "Calibrating delay loop...".
Tim, didn't you diagnose that a while ago?
---
xen/arch/arm/gic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 378158b..6f5b0e1 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -323,10 +323,10 @@ int __init gic_init(void)
/* Set up the per-CPU parts of the GIC for a secondary CPU */
void __cpuinit gic_init_secondary_cpu(void)
{
- spin_lock_irq(&gic.lock);
+ spin_lock(&gic.lock);
gic_cpu_init();
gic_hyp_init();
- spin_unlock_irq(&gic.lock);
+ spin_unlock(&gic.lock);
}
/* Shut down the per-CPU GIC interface */
--
1.7.9.1
next reply other threads:[~2012-08-01 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 16:43 Ian Campbell [this message]
2012-08-02 11:09 ` [PATCH] arm: fix gic_init_secondary_cpu Tim Deegan
2012-08-03 8:56 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343839438-3321-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).