From: Ian Campbell <Ian.Campbell@citrix.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Greg Wettstein <greg@wind.enjellic.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] libxl: fix cleanup of tap devices in libxl__device_destroy
Date: Thu, 2 Aug 2012 10:45:22 +0100 [thread overview]
Message-ID: <1343900722.27221.107.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <f345fbfa8f50975b5c32.1343900314@cosworth.uk.xensource.com>
> rc = libxl__xs_transaction_start(gc, &t);
> if (rc) goto out;
>
> + /* May not exist if this is not a tap device */
> + tapdisk_params = libxl__xs_read(gc, t, tapdisk_path);
> +
> libxl__xs_path_cleanup(gc, t, fe_path);
> libxl__xs_path_cleanup(gc, t, be_path);
Do we deliberate ignore the error codes from these two?
Ian.
next prev parent reply other threads:[~2012-08-02 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 9:38 [PATCH] libxl: fix cleanup of tap devices in libxl__device_destroy Ian Campbell
2012-08-02 9:45 ` Ian Campbell [this message]
2012-08-02 14:42 ` Ian Jackson
2012-08-02 14:45 ` Ian Campbell
2012-08-02 14:54 ` Ian Jackson
2012-08-02 14:41 ` Ian Jackson
2012-08-02 14:43 ` Ian Campbell
2012-08-02 14:48 ` linewrapping commit messages (was Re: [PATCH] libxl: fix cleanup of tap devices in libxl__device_destroy) Ian Jackson
2012-08-02 14:55 ` [PATCH] libxl: fix cleanup of tap devices in libxl__device_destroy Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343900722.27221.107.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=greg@wind.enjellic.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).