xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org,
	linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	tim-LM2mM/qkH7s@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH v2 18/23] xen: allow privcmd for HVM guests
Date: Mon, 6 Aug 2012 15:27:21 +0100	[thread overview]
Message-ID: <1344263246-28036-18-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1208061428060.4645-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>

This patch removes the "return -ENOSYS" for auto_translated_physmap
guests from privcmd_mmap, thus it allows ARM guests to issue privcmd
mmap calls. However privcmd mmap calls are still going to fail for HVM
and hybrid guests on x86 because the xen_remap_domain_mfn_range
implementation is currently PV only.

Changes in v2:

- better commit message;
- return -EINVAL from xen_remap_domain_mfn_range if
  auto_translated_physmap.

Signed-off-by: Stefano Stabellini <stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
---
 arch/x86/xen/mmu.c    |    3 +++
 drivers/xen/privcmd.c |    4 ----
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 3a73785..885a223 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -2310,6 +2310,9 @@ int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
 	unsigned long range;
 	int err = 0;
 
+	if (xen_feature(XENFEAT_auto_translated_physmap))
+		return -EINVAL;
+
 	prot = __pgprot(pgprot_val(prot) | _PAGE_IOMAP);
 
 	BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_RESERVED | VM_IO)) ==
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index ccee0f1..85226cb 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -380,10 +380,6 @@ static struct vm_operations_struct privcmd_vm_ops = {
 
 static int privcmd_mmap(struct file *file, struct vm_area_struct *vma)
 {
-	/* Unsupported for auto-translate guests. */
-	if (xen_feature(XENFEAT_auto_translated_physmap))
-		return -ENOSYS;
-
 	/* DONTCOPY is essential for Xen because copy_page_range doesn't know
 	 * how to recreate these mappings */
 	vma->vm_flags |= VM_RESERVED | VM_IO | VM_DONTCOPY | VM_PFNMAP;
-- 
1.7.2.5

  parent reply	other threads:[~2012-08-06 14:27 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 14:25 [PATCH v2 00/23] Introduce Xen support on ARM Stefano Stabellini
2012-08-06 14:27 ` [PATCH v2 01/23] arm: initial Xen support Stefano Stabellini
2012-08-07 18:10   ` Konrad Rzeszutek Wilk
2012-08-08 16:31     ` Stefano Stabellini
2012-08-06 14:27 ` [PATCH v2 02/23] xen/arm: hypercalls Stefano Stabellini
2012-08-08 12:41   ` Dave Martin
2012-08-09 15:37     ` Stefano Stabellini
2012-08-09 16:50       ` Dave Martin
2012-08-06 14:27 ` [PATCH v2 06/23] xen: missing includes Stefano Stabellini
2012-08-07 18:14   ` Konrad Rzeszutek Wilk
2012-08-08 16:38     ` Stefano Stabellini
2012-08-06 14:27 ` [PATCH v2 10/23] xen/arm: compile and run xenbus Stefano Stabellini
2012-08-07 18:21   ` Konrad Rzeszutek Wilk
2012-08-07 18:44     ` Daniel De Graaf
2012-08-08 16:51       ` Stefano Stabellini
2012-08-08 17:01         ` Daniel De Graaf
     [not found]           ` <50229B70.3090507-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
2012-08-08 17:19             ` Stefano Stabellini
2012-08-08 17:33               ` Daniel De Graaf
2012-08-08 17:42                 ` Stefano Stabellini
2012-08-09 16:54                   ` Konrad Rzeszutek Wilk
2012-08-06 14:27 ` [PATCH v2 17/23] xen/arm: implement alloc/free_xenballooned_pages with alloc_pages/kfree Stefano Stabellini
     [not found]   ` <1344263246-28036-17-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:31     ` Konrad Rzeszutek Wilk
     [not found] ` <alpine.DEB.2.02.1208061428060.4645-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2012-08-06 14:27   ` [PATCH v2 03/23] xen/arm: page.h definitions Stefano Stabellini
     [not found]     ` <1344263246-28036-3-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:13       ` Konrad Rzeszutek Wilk
2012-08-08 16:33         ` Stefano Stabellini
2012-08-06 14:27   ` [PATCH v2 04/23] xen/arm: sync_bitops Stefano Stabellini
     [not found]     ` <1344263246-28036-4-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:13       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 05/23] xen/arm: empty implementation of grant_table arch specific functions Stefano Stabellini
     [not found]     ` <1344263246-28036-5-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:13       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 07/23] xen/arm: Xen detection and shared_info page mapping Stefano Stabellini
     [not found]     ` <1344263246-28036-7-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-06 16:23       ` [Xen-devel] " David Vrabel
2012-08-08 16:24         ` Stefano Stabellini
2012-08-07 18:17       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 08/23] xen/arm: Introduce xen_pfn_t for pfn and mfn types Stefano Stabellini
     [not found]     ` <1344263246-28036-8-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:18       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 09/23] xen/arm: Introduce xen_ulong_t for unsigned long Stefano Stabellini
     [not found]     ` <1344263246-28036-9-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:18       ` Konrad Rzeszutek Wilk
2012-08-08 16:42         ` Stefano Stabellini
2012-08-06 14:27   ` [PATCH v2 11/23] xen: do not compile manage, balloon, pci, acpi and cpu_hotplug on ARM Stefano Stabellini
     [not found]     ` <1344263246-28036-11-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:23       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 12/23] xen/arm: introduce CONFIG_XEN " Stefano Stabellini
     [not found]     ` <1344263246-28036-12-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:23       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 13/23] xen/arm: get privilege status Stefano Stabellini
     [not found]     ` <1344263246-28036-13-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:24       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 14/23] xen/arm: initialize grant_table on ARM Stefano Stabellini
2012-08-06 14:27   ` [PATCH v2 15/23] xen/arm: receive Xen events " Stefano Stabellini
2012-08-07 18:30     ` Konrad Rzeszutek Wilk
     [not found]       ` <20120807183036.GR15053-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2012-08-08 18:05         ` Stefano Stabellini
2012-08-06 14:27   ` [PATCH v2 16/23] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST Stefano Stabellini
     [not found]     ` <1344263246-28036-16-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:31       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` Stefano Stabellini [this message]
     [not found]     ` <1344263246-28036-18-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:31       ` [PATCH v2 18/23] xen: allow privcmd for HVM guests Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 19/23] xen/arm: compile blkfront and blkback Stefano Stabellini
     [not found]     ` <1344263246-28036-19-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:32       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 20/23] xen/arm: compile netback Stefano Stabellini
     [not found]     ` <1344263246-28036-20-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:32       ` Konrad Rzeszutek Wilk
2012-08-06 14:27   ` [PATCH v2 21/23] xen: update xen_add_to_physmap interface Stefano Stabellini
     [not found]     ` <1344263246-28036-21-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:33       ` Konrad Rzeszutek Wilk
2012-08-08 17:22         ` Stefano Stabellini
2012-08-06 14:27   ` [PATCH v2 22/23] arm/v2m: initialize arch_timers even if v2m_timer is not present Stefano Stabellini
2012-08-06 14:27   ` [PATCH v2 23/23] [HACK] xen/arm: implement xen_remap_domain_mfn_range Stefano Stabellini
     [not found]     ` <1344263246-28036-23-git-send-email-stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org>
2012-08-07 18:39       ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344263246-28036-18-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini-mvvwk6wmycldpfhejli6iq@public.gmane.org \
    --cc=Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tim-LM2mM/qkH7s@public.gmane.org \
    --cc=xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).