From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [RFC PATCH 7/8]: PVH: grant changes
Date: Sat, 18 Aug 2012 09:22:04 +0100
Message-ID: <1345278124.23624.11.camel@dagon.hellion.org.uk>
References: <20120815180622.0c988f48@mantra.us.oracle.com>
	<1345197150.30865.147.camel@zakaz.uk.xensource.com>
	<20120817170641.4261229b@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20120817170641.4261229b@mantra.us.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

> > > HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp); if (rc != 0) {
> > >  				printk(KERN_WARNING
> > > @@ -1053,7 +1058,7 @@ static void gnttab_request_version(void)
> > >  	int rc;
> > >  	struct gnttab_set_version gsv;
> > >  
> > > -	if (xen_hvm_domain())
> > > +	if (xen_hvm_domain() || xen_pvh_domain())
> > 
> > Does something stop pvh using v2?
> 
> I had some issue related to grstatus field that was added, so punted it
> for now. It's phase II which is a big phase now :) :)...

It seems like it's got a lot of most independent bits in it, so
hopefully you should get some help ;-)

> > >  
> > > -	if (xen_pv_domain())
> > > +	/* PVH note: xen will free existing kmalloc'd mfn in
> > > +	 * XENMEM_add_to_physmap */
> > > +	if (xen_pvh_domain() && !gnttab_shared.addr) {
> > > +		gnttab_shared.addr =
> > > +			kmalloc(max_nr_gframes * PAGE_SIZE,
> > > GFP_KERNEL);
> > > +		if ( !gnttab_shared.addr ) {
> > > +			printk(KERN_WARNING "%s", kmsg);
> > 
> > Why this construct instead of just the string literal?
>  
> To keep line overflow. I dont' like code spanning 80 columns. If you split,
> then you can't grep.

FWIW CodingStyle relaxes the 80 column limit for literal strings for
exactly this reason.

Ian.