From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [RFC PATCH 5/8]: PVH: smp changes Date: Wed, 22 Aug 2012 07:10:49 +0100 Message-ID: <1345615849.23624.42.camel@dagon.hellion.org.uk> References: <20120815180449.50410028@mantra.us.oracle.com> <1345196531.30865.139.camel@zakaz.uk.xensource.com> <20120821172323.38aec925@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120821172323.38aec925@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: "Xen-devel@lists.xensource.com" , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org On Wed, 2012-08-22 at 01:23 +0100, Mukesh Rathor wrote: > On Fri, 17 Aug 2012 10:42:11 +0100 > Ian Campbell wrote: > > > > @@ -339,7 +343,20 @@ cpu_initialize_context(unsigned int cpu, > > > struct task_struct *idle) (unsigned long)xen_hypervisor_callback; > > > ctxt->failsafe_callback_eip = > > > (unsigned > > > long)xen_failsafe_callback; - > > > + } else { > > > + ctxt->user_regs.ds = __KERNEL_DS; > > > + ctxt->user_regs.es = 0; > > > + ctxt->user_regs.gs = 0; > > > > Not __KERNEL_DS for es too? > > 64bit, es ignored, right? Not 100% sure, the limit certainly is but the base and the privilege level might not be? The reason I mentioned it was that I could see in the !pvh case: ctxt->user_regs.es = __USER_DS; Ian.