From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 04/16] arm: handle xenheap which isn't at the start of RAM.
Date: Mon, 3 Sep 2012 13:30:44 +0000 [thread overview]
Message-ID: <1346679056-8108-4-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1346678886.32462.9.camel@zakaz.uk.xensource.com>
Also refactor page_to_virt somewhat in an attempt to make it clearer
what is happening.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/include/asm-arm/mm.h | 24 +++++++++++++++++++-----
1 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
index b37bd35..6498322 100644
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -214,17 +214,31 @@ static inline struct page_info *virt_to_page(const void *v)
ASSERT(va >= XENHEAP_VIRT_START);
ASSERT(va < xenheap_virt_end);
- return frame_table + ((va - XENHEAP_VIRT_START) >> PAGE_SHIFT);
+ return frame_table
+ + ((va - XENHEAP_VIRT_START) >> PAGE_SHIFT)
+ + xenheap_mfn_start
+ - frametable_base_mfn;
}
static inline void *page_to_virt(const struct page_info *pg)
{
+ unsigned long va;
+ const unsigned long offset =
+ (xenheap_mfn_start-frametable_base_mfn)*sizeof(*pg);
+
+ /*
+ * Dividing by this on both top and bottom factors out the largest
+ * common factor of 2 which helps the compiler to use smaller shifts.
+ */
+ const unsigned long lcd = (sizeof(*pg) & -sizeof(*pg));
+
ASSERT((unsigned long)pg - FRAMETABLE_VIRT_START < frametable_virt_end);
- return (void *)(XENHEAP_VIRT_START +
- ((unsigned long)pg - FRAMETABLE_VIRT_START) /
- (sizeof(*pg) / (sizeof(*pg) & -sizeof(*pg))) *
- (PAGE_SIZE / (sizeof(*pg) & -sizeof(*pg))));
+ va = (unsigned long)pg;
+ va = XENHEAP_VIRT_START +
+ ((va - FRAMETABLE_VIRT_START - offset) / (sizeof(*pg) / lcd)) *
+ (PAGE_SIZE / lcd);
+ return (void *)va;
}
struct domain *page_get_owner_and_reference(struct page_info *page);
--
1.7.9.1
next prev parent reply other threads:[~2012-09-03 13:30 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 13:28 [PATCH 0/16] arm: support for initial modules (e.g. dom0) and DTB supplied in RAM Ian Campbell
2012-09-03 13:30 ` [PATCH 01/16] arm: Zero the BSS at start of day Ian Campbell
2012-09-06 9:56 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 02/16] Create a raw binary target Ian Campbell
2012-09-06 10:01 ` Tim Deegan
2012-09-06 10:29 ` Ian Campbell
2012-09-03 13:30 ` [PATCH 03/16] arm: make virtual address defines unsigned Ian Campbell
2012-09-06 10:02 ` Tim Deegan
2012-09-03 13:30 ` Ian Campbell [this message]
2012-09-06 11:36 ` [PATCH 04/16] arm: handle xenheap which isn't at the start of RAM Tim Deegan
2012-09-03 13:30 ` [PATCH 05/16] arm: move get_paddr_function to arch setup.c from device_tree.c Ian Campbell
2012-09-06 11:40 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 06/16] arm: parse modules from DT during early boot Ian Campbell
2012-09-06 11:47 ` Tim Deegan
2012-09-06 11:53 ` Ian Campbell
2012-11-30 14:58 ` Stefano Stabellini
2012-09-03 13:30 ` [PATCH 07/16] arm: avoid placing Xen over any modules Ian Campbell
2012-09-06 12:01 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 08/16] arm: really allocate boot frametable pages with 32M alignment Ian Campbell
2012-09-06 12:04 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 09/16] arm: avoid allocating the heaps over modules or xen itself Ian Campbell
2012-09-06 12:08 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 10/16] arm: print a message if multiple banks of memory are present Ian Campbell
2012-09-06 12:31 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 11/16] arm: mark heap and frametable limits as read mostly Ian Campbell
2012-09-06 13:29 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 12/16] arm: const-correctness in virt_to_maddr Ian Campbell
2012-09-06 13:33 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 13/16] device-tree: get_val cannot cope with cells > 2, add a BUG Ian Campbell
2012-09-06 13:35 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 14/16] arm: load dom0 kernel from first boot module Ian Campbell
2012-09-06 13:44 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 15/16] arm: discard boot modules after building domain 0 Ian Campbell
2012-09-06 13:53 ` Tim Deegan
2012-09-06 13:57 ` Ian Campbell
2012-09-06 14:03 ` Tim Deegan
2012-09-03 13:30 ` [PATCH 16/16] arm: use /chosen/module1-args for domain 0 command line Ian Campbell
2012-09-06 13:50 ` Tim Deegan
2012-09-06 13:55 ` Ian Campbell
2012-09-06 13:58 ` Tim Deegan
2012-09-06 13:59 ` Ian Campbell
2012-09-06 14:19 ` David Vrabel
2012-09-06 14:28 ` Ian Campbell
2012-09-06 14:46 ` [PATCH 0/16] arm: support for initial modules (e.g. dom0) and DTB supplied in RAM David Vrabel
2012-09-10 16:12 ` Ian Campbell
2012-09-17 11:39 ` Stefano Stabellini
2012-10-11 14:57 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346679056-8108-4-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).