From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xensource.com
Cc: David Vrabel <david.vrabel@citrix.com>
Subject: [PATCH] timer: remove stray local_irq_enable()
Date: Thu, 6 Sep 2012 13:05:18 +0100 [thread overview]
Message-ID: <1346933118-28928-1-git-send-email-david.vrabel@citrix.com> (raw)
From: David Vrabel <david.vrabel@citrix.com>
migrate_timers_from_cpu() has a stray local_irq_enable() that does
nothing (it's immediately after a spin_unlock_irq()) and has no
matching local_irq_disable().
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
xen/common/timer.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/xen/common/timer.c b/xen/common/timer.c
index 0dd2476..39de52d 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
spin_unlock(&old_ts->lock);
spin_unlock_irq(&new_ts->lock);
- local_irq_enable();
if ( notify )
cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
--
1.7.2.5
next reply other threads:[~2012-09-06 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 12:05 David Vrabel [this message]
2012-09-06 12:26 ` [PATCH] timer: remove stray local_irq_enable() Jan Beulich
2012-09-06 13:28 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346933118-28928-1-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).