* [PATCH] timer: remove stray local_irq_enable()
@ 2012-09-06 12:05 David Vrabel
2012-09-06 12:26 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: David Vrabel @ 2012-09-06 12:05 UTC (permalink / raw)
To: xen-devel; +Cc: David Vrabel
From: David Vrabel <david.vrabel@citrix.com>
migrate_timers_from_cpu() has a stray local_irq_enable() that does
nothing (it's immediately after a spin_unlock_irq()) and has no
matching local_irq_disable().
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
xen/common/timer.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/xen/common/timer.c b/xen/common/timer.c
index 0dd2476..39de52d 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
spin_unlock(&old_ts->lock);
spin_unlock_irq(&new_ts->lock);
- local_irq_enable();
if ( notify )
cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] timer: remove stray local_irq_enable()
2012-09-06 12:05 [PATCH] timer: remove stray local_irq_enable() David Vrabel
@ 2012-09-06 12:26 ` Jan Beulich
2012-09-06 13:28 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2012-09-06 12:26 UTC (permalink / raw)
To: David Vrabel; +Cc: xen-devel
>>> On 06.09.12 at 14:05, David Vrabel <david.vrabel@citrix.com> wrote:
> From: David Vrabel <david.vrabel@citrix.com>
>
> migrate_timers_from_cpu() has a stray local_irq_enable() that does
> nothing (it's immediately after a spin_unlock_irq()) and has no
> matching local_irq_disable().
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
> --- a/xen/common/timer.c
> +++ b/xen/common/timer.c
> @@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
>
> spin_unlock(&old_ts->lock);
> spin_unlock_irq(&new_ts->lock);
> - local_irq_enable();
>
> if ( notify )
> cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] timer: remove stray local_irq_enable()
2012-09-06 12:26 ` Jan Beulich
@ 2012-09-06 13:28 ` Keir Fraser
0 siblings, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2012-09-06 13:28 UTC (permalink / raw)
To: Jan Beulich, David Vrabel; +Cc: xen-devel
On 06/09/2012 13:26, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 06.09.12 at 14:05, David Vrabel <david.vrabel@citrix.com> wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> migrate_timers_from_cpu() has a stray local_irq_enable() that does
>> nothing (it's immediately after a spin_unlock_irq()) and has no
>> matching local_irq_disable().
>>
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Jan, Please apply it to xen-unstable.
-- Keir
>> --- a/xen/common/timer.c
>> +++ b/xen/common/timer.c
>> @@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
>>
>> spin_unlock(&old_ts->lock);
>> spin_unlock_irq(&new_ts->lock);
>> - local_irq_enable();
>>
>> if ( notify )
>> cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-06 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-06 12:05 [PATCH] timer: remove stray local_irq_enable() David Vrabel
2012-09-06 12:26 ` Jan Beulich
2012-09-06 13:28 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).