From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxl: Enable -Wshadow
Date: Mon, 17 Sep 2012 11:18:56 +0100 [thread overview]
Message-ID: <1347877136.14977.49.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20563.20495.204901.209605@mariner.uk.xensource.com>
On Fri, 2012-09-14 at 16:41 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH] libxl: Enable -Wshadow"):
> > On Fri, 2012-09-14 at 15:42 +0100, Ian Jackson wrote:
> > > If we're doing -Wshadow then macros which introduce local variables
> > > like this should give them names qualified somehow for the macro.
> >
> > Done, v2 below.
> >
> > Since I was touching every line I fixed the line length in those macros
> > too.
>
> :-).
>
> Thanks,
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Applied, thanks.
prev parent reply other threads:[~2012-09-17 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 11:09 [PATCH] libxl: Enable -Wshadow Ian Campbell
2012-09-14 14:41 ` Ian Jackson
2012-09-14 14:42 ` Ian Jackson
2012-09-14 15:34 ` Ian Campbell
2012-09-14 15:41 ` Ian Jackson
2012-09-17 10:18 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347877136.14977.49.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).