xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xensource.com
Cc: David Vrabel <david.vrabel@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] xen-pcifront: handle backend CLOSED without CLOSING
Date: Fri, 21 Sep 2012 17:04:21 +0100	[thread overview]
Message-ID: <1348243464-15903-4-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1348243464-15903-1-git-send-email-david.vrabel@citrix.com>

From: David Vrabel <david.vrabel@citrix.com>

Backend drivers shouldn't transistion to CLOSED unless the frontend is
CLOSED.  If a backend does transition to CLOSED too soon then the
frontend may not see the CLOSING state and will not properly shutdown.

So, treat an unexpected backend CLOSED state the same as CLOSING.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
 drivers/pci/xen-pcifront.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index d6cc62c..b5692c3 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -1069,13 +1069,16 @@ static void __init_refok pcifront_backend_changed(struct xenbus_device *xdev,
 	case XenbusStateInitialising:
 	case XenbusStateInitWait:
 	case XenbusStateInitialised:
-	case XenbusStateClosed:
 		break;
 
 	case XenbusStateConnected:
 		pcifront_try_connect(pdev);
 		break;
 
+	case XenbusStateClosed:
+		if (xdev->state == XenbusStateClosed)
+			break;
+		/* Missed the backend's CLOSING state -- fallthrough */
 	case XenbusStateClosing:
 		dev_warn(&xdev->dev, "backend going away!\n");
 		pcifront_try_disconnect(pdev);
-- 
1.7.2.5

  parent reply	other threads:[~2012-09-21 16:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 16:04 [PATCH 0/6] xen: frontend devices should handle missed backend CLOSING David Vrabel
2012-09-21 16:04 ` [PATCH 1/6] xen-netfront: handle backend CLOSED without CLOSING David Vrabel
2012-09-21 16:04 ` [PATCH 2/6] xen-blkfront: " David Vrabel
2012-09-25 17:53   ` David Vrabel
2012-10-01 17:19     ` David Vrabel
2012-10-02 20:02       ` Konrad Rzeszutek Wilk
2012-10-05 11:42         ` David Vrabel
2012-10-05 11:55           ` Jan Beulich
2012-10-05 15:57             ` David Vrabel
2012-10-09 16:30               ` Konrad Rzeszutek Wilk
2012-10-04 10:14     ` [Xen-devel] " Jan Beulich
2012-10-04 10:31       ` David Vrabel
2012-09-21 16:04 ` David Vrabel [this message]
2012-09-21 16:04 ` [PATCH 4/6] xen-fbfront: " David Vrabel
2012-09-21 16:04 ` [PATCH 5/6] xen-kbdfront: " David Vrabel
2012-09-21 16:04 ` [PATCH 6/6] xen/hvc: " David Vrabel
2012-09-21 17:10 ` [PATCH 0/6] xen: frontend devices should handle missed backend CLOSING Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348243464-15903-4-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).