* [PATCH 0/2] PV drivers product number registration @ 2012-09-26 13:50 Paul Durrant 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-09-26 13:50 ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant 0 siblings, 2 replies; 7+ messages in thread From: Paul Durrant @ 2012-09-26 13:50 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU to prevent co-existence of emulated devices. See docs/misc/hvm-emulated-unplug.markdown for details. The register of product numbers used by the blacklisting feature of this protocol is currently directly in the xenstore.c source module of traditional QEMU. It should really be in a Xen header file to prevent duplication/conflict between QEMU versions. Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly without ever registering that number. This patch series introduces a new header and registers product number 3 for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to make use of the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 13:50 [PATCH 0/2] PV drivers product number registration Paul Durrant @ 2012-09-26 13:50 ` Paul Durrant 2012-09-28 17:54 ` Ian Jackson 2012-09-26 13:50 ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant 1 sibling, 1 reply; 7+ messages in thread From: Paul Durrant @ 2012-09-26 13:50 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant These product numbers are used by the QEMU blacklisting protocol in traditional QEMU and are currently coded directly into the xenstore.c source module. Since there are now multiple QEMUs this information should be pulled into a public header to avoid duplication/conflict. hvm-emulated-unplug.markdown has also been adjusted to reference the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- docs/misc/hvm-emulated-unplug.markdown | 2 +- xen/include/public/hvm/pvdrivers.h | 53 ++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 1 deletions(-) create mode 100644 xen/include/public/hvm/pvdrivers.h diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 707fbab..ec9ce83 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the product number in step 3. The master registry of product names and numbers is in -qemu-xen-unstable's xenstore.c. +xen/include/public/hvm/pvdrivers.h diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h new file mode 100644 index 0000000..98d61d0 --- /dev/null +++ b/xen/include/public/hvm/pvdrivers.h @@ -0,0 +1,53 @@ +/* + * pvdrivers.h: Register of PV drivers product numbers. + * Copyright (c) 2012, Citrix Systems Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ +#define _XEN_PUBLIC_PVDRIVERS_H_ + +/* + * This is the master registry of product numbers for + * PV drivers. + * If you need a new product number allocating, please + * post to xen-devel@lists.xen.org. You should NOT use + * a product number without allocating one. + * If you maintain a separate versioning and distribution path + * for PV drivers you should have a separate product number so + * that your drivers can be separated from others. + * + * During development, you may use the EXPERIMENTAL product ID to + * indicate a driver which is yet to be released. + * + * See docs/misc/hvm-emulated-unplug.markdown for details of how + * the product number is used. + */ + +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" + +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" + +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" + +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant @ 2012-09-28 17:54 ` Ian Jackson 0 siblings, 0 replies; 7+ messages in thread From: Ian Jackson @ 2012-09-28 17:54 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers."): > These product numbers are used by the QEMU blacklisting protocol in > traditional QEMU and are currently coded directly into the xenstore.c > source module. Since there are now multiple QEMUs this information > should be pulled into a public header to avoid duplication/conflict. > hvm-emulated-unplug.markdown has also been adjusted to reference the > new header. > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > + > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" > + > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" This form for this list is very ill-suited to many obvious uses. For example it cannot be used to automatically generate a switch statement or a table of values for printing. Can I suggest #define PVDRIVERS_ID_NAME_LIST(EACH) \ EACH(WINDOWS, 0x0001 /* Citrix */, "xensource-windows") \ ... or something ? Ian. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] Register Linux PV-on-HVM drivers product number. 2012-09-26 13:50 [PATCH 0/2] PV drivers product number registration Paul Durrant 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant @ 2012-09-26 13:50 ` Paul Durrant 1 sibling, 0 replies; 7+ messages in thread From: Paul Durrant @ 2012-09-26 13:50 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant This is already in use despite never being registereed. See XEN_IOPORT_LINUX_PRODNUM in include/xen/platform_pci.h Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- xen/include/public/hvm/pvdrivers.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h index 98d61d0..75fa656 100644 --- a/xen/include/public/hvm/pvdrivers.h +++ b/xen/include/public/hvm/pvdrivers.h @@ -28,17 +28,14 @@ * This is the master registry of product numbers for * PV drivers. * If you need a new product number allocating, please - * post to xen-devel@lists.xen.org. You should NOT use + * post to xen-devel@lists.xensource.com. You should NOT use * a product number without allocating one. * If you maintain a separate versioning and distribution path * for PV drivers you should have a separate product number so * that your drivers can be separated from others. * - * During development, you may use the EXPERIMENTAL product ID to + * During development, you may use the product ID to * indicate a driver which is yet to be released. - * - * See docs/misc/hvm-emulated-unplug.markdown for details of how - * the product number is used. */ #define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ @@ -47,6 +44,9 @@ #define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ #define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" +#define PVDRIVERS_LINUX_ID 0x0003 /* platform_pci.h */ +#define PVDRIVERS_LINUX_NAME "linux" + #define PVDRIVERS_EXPERIMENTAL_ID 0xffff #define PVDRIVERS_EXPERIMENTAL_NAME "experimental" -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 0/2] PV drivers product number registration @ 2012-09-26 12:23 Paul Durrant 2012-09-26 12:51 ` Konrad Rzeszutek Wilk 0 siblings, 1 reply; 7+ messages in thread From: Paul Durrant @ 2012-09-26 12:23 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU to prevent co-existence of emulated devices. See docs/misc/hvm-emulated-unplug.markdown for details. The register of product numbers used by the blacklisting feature of this protocol is currently directly in the xenstore.c source module of traditional QEMU. It should really be in a Xen header file to prevent duplication/conflict between QEMU versions. Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly without ever registering that number. This patch series introduces a new header and registers product number 3 for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to make use of the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] PV drivers product number registration 2012-09-26 12:23 [PATCH 0/2] PV drivers product number registration Paul Durrant @ 2012-09-26 12:51 ` Konrad Rzeszutek Wilk 2012-09-26 13:08 ` Ian Campbell 0 siblings, 1 reply; 7+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-09-26 12:51 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel On Wed, Sep 26, 2012 at 01:23:30PM +0100, Paul Durrant wrote: > PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU > to prevent co-existence of emulated devices. > See docs/misc/hvm-emulated-unplug.markdown for details. > > The register of product numbers used by the blacklisting feature of this > protocol is currently directly in the xenstore.c source module of > traditional QEMU. It should really be in a Xen header file to prevent Why do we want to blacklist them? Isn't it a whitelist (as in it is the right values?) > duplication/conflict between QEMU versions. > > Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly > without ever registering that number. > > This patch series introduces a new header and registers product number 3 > for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to > make use of the new header. > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] PV drivers product number registration 2012-09-26 12:51 ` Konrad Rzeszutek Wilk @ 2012-09-26 13:08 ` Ian Campbell 0 siblings, 0 replies; 7+ messages in thread From: Ian Campbell @ 2012-09-26 13:08 UTC (permalink / raw) To: Konrad Rzeszutek Wilk; +Cc: Paul Durrant, xen-devel@lists.xen.org On Wed, 2012-09-26 at 13:51 +0100, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 26, 2012 at 01:23:30PM +0100, Paul Durrant wrote: > > PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU > > to prevent co-existence of emulated devices. > > See docs/misc/hvm-emulated-unplug.markdown for details. > > > > The register of product numbers used by the blacklisting feature of this > > protocol is currently directly in the xenstore.c source module of > > traditional QEMU. It should really be in a Xen header file to prevent > > Why do we want to blacklist them? Isn't it a whitelist (as in it is > the right values?) We don't *want* to blacklist them, but this gives us a mechanism whereby in the future we can blacklist drivers which turn out to be buggy from the host level (via qemu). See docs/misc/hvm-emulated-unplug.markdown AFAIK qemu currently doesn't blacklist anything. Ian. > > > duplication/conflict between QEMU versions. > > > > Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly > > without ever registering that number. > > > > This patch series introduces a new header and registers product number 3 > > for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to > > make use of the new header. > > > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com> > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-28 17:54 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-26 13:50 [PATCH 0/2] PV drivers product number registration Paul Durrant 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-09-28 17:54 ` Ian Jackson 2012-09-26 13:50 ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant -- strict thread matches above, loose matches on Subject: below -- 2012-09-26 12:23 [PATCH 0/2] PV drivers product number registration Paul Durrant 2012-09-26 12:51 ` Konrad Rzeszutek Wilk 2012-09-26 13:08 ` Ian Campbell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).