* [PATCH 0/2] PV drivers product number registration @ 2012-09-26 13:50 Paul Durrant 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-09-26 13:50 ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant 0 siblings, 2 replies; 21+ messages in thread From: Paul Durrant @ 2012-09-26 13:50 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU to prevent co-existence of emulated devices. See docs/misc/hvm-emulated-unplug.markdown for details. The register of product numbers used by the blacklisting feature of this protocol is currently directly in the xenstore.c source module of traditional QEMU. It should really be in a Xen header file to prevent duplication/conflict between QEMU versions. Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly without ever registering that number. This patch series introduces a new header and registers product number 3 for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to make use of the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 13:50 [PATCH 0/2] PV drivers product number registration Paul Durrant @ 2012-09-26 13:50 ` Paul Durrant 2012-09-28 17:54 ` Ian Jackson 2012-09-26 13:50 ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant 1 sibling, 1 reply; 21+ messages in thread From: Paul Durrant @ 2012-09-26 13:50 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant These product numbers are used by the QEMU blacklisting protocol in traditional QEMU and are currently coded directly into the xenstore.c source module. Since there are now multiple QEMUs this information should be pulled into a public header to avoid duplication/conflict. hvm-emulated-unplug.markdown has also been adjusted to reference the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- docs/misc/hvm-emulated-unplug.markdown | 2 +- xen/include/public/hvm/pvdrivers.h | 53 ++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 1 deletions(-) create mode 100644 xen/include/public/hvm/pvdrivers.h diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 707fbab..ec9ce83 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the product number in step 3. The master registry of product names and numbers is in -qemu-xen-unstable's xenstore.c. +xen/include/public/hvm/pvdrivers.h diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h new file mode 100644 index 0000000..98d61d0 --- /dev/null +++ b/xen/include/public/hvm/pvdrivers.h @@ -0,0 +1,53 @@ +/* + * pvdrivers.h: Register of PV drivers product numbers. + * Copyright (c) 2012, Citrix Systems Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ +#define _XEN_PUBLIC_PVDRIVERS_H_ + +/* + * This is the master registry of product numbers for + * PV drivers. + * If you need a new product number allocating, please + * post to xen-devel@lists.xen.org. You should NOT use + * a product number without allocating one. + * If you maintain a separate versioning and distribution path + * for PV drivers you should have a separate product number so + * that your drivers can be separated from others. + * + * During development, you may use the EXPERIMENTAL product ID to + * indicate a driver which is yet to be released. + * + * See docs/misc/hvm-emulated-unplug.markdown for details of how + * the product number is used. + */ + +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" + +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" + +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" + +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant @ 2012-09-28 17:54 ` Ian Jackson 0 siblings, 0 replies; 21+ messages in thread From: Ian Jackson @ 2012-09-28 17:54 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers."): > These product numbers are used by the QEMU blacklisting protocol in > traditional QEMU and are currently coded directly into the xenstore.c > source module. Since there are now multiple QEMUs this information > should be pulled into a public header to avoid duplication/conflict. > hvm-emulated-unplug.markdown has also been adjusted to reference the > new header. > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > + > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" > + > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" This form for this list is very ill-suited to many obvious uses. For example it cannot be used to automatically generate a switch statement or a table of values for printing. Can I suggest #define PVDRIVERS_ID_NAME_LIST(EACH) \ EACH(WINDOWS, 0x0001 /* Citrix */, "xensource-windows") \ ... or something ? Ian. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/2] Register Linux PV-on-HVM drivers product number. 2012-09-26 13:50 [PATCH 0/2] PV drivers product number registration Paul Durrant 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant @ 2012-09-26 13:50 ` Paul Durrant 1 sibling, 0 replies; 21+ messages in thread From: Paul Durrant @ 2012-09-26 13:50 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant This is already in use despite never being registereed. See XEN_IOPORT_LINUX_PRODNUM in include/xen/platform_pci.h Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- xen/include/public/hvm/pvdrivers.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h index 98d61d0..75fa656 100644 --- a/xen/include/public/hvm/pvdrivers.h +++ b/xen/include/public/hvm/pvdrivers.h @@ -28,17 +28,14 @@ * This is the master registry of product numbers for * PV drivers. * If you need a new product number allocating, please - * post to xen-devel@lists.xen.org. You should NOT use + * post to xen-devel@lists.xensource.com. You should NOT use * a product number without allocating one. * If you maintain a separate versioning and distribution path * for PV drivers you should have a separate product number so * that your drivers can be separated from others. * - * During development, you may use the EXPERIMENTAL product ID to + * During development, you may use the product ID to * indicate a driver which is yet to be released. - * - * See docs/misc/hvm-emulated-unplug.markdown for details of how - * the product number is used. */ #define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ @@ -47,6 +44,9 @@ #define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ #define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" +#define PVDRIVERS_LINUX_ID 0x0003 /* platform_pci.h */ +#define PVDRIVERS_LINUX_NAME "linux" + #define PVDRIVERS_EXPERIMENTAL_ID 0xffff #define PVDRIVERS_EXPERIMENTAL_NAME "experimental" -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 0/2] PV drivers product number registration (v3) @ 2012-10-01 16:28 Paul Durrant 2012-10-01 16:28 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 0 siblings, 1 reply; 21+ messages in thread From: Paul Durrant @ 2012-10-01 16:28 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU to prevent co-existence of emulated devices. See docs/misc/hvm-emulated-unplug.markdown for details. The register of product numbers used by the blacklisting feature of this protocol is currently directly in the xenstore.c source moduleof traditional QEMU. It should really be in a Xen header file to prevent duplication/conflict between QEMU versions. Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly without ever registering that number. This patch series introduces a new header and registers product number 3 for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to make use of the new header. Version 2: I have re-coded at Ian Jackson's request in the form of macros that allow a switch statement or array to be easily generated from the product list. Version 3: Ditching the terminator list entry. The associated QEMU patch is unmodified by this so not resending. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-10-01 16:28 [PATCH 0/2] PV drivers product number registration (v3) Paul Durrant @ 2012-10-01 16:28 ` Paul Durrant 2012-10-01 16:55 ` Ian Jackson 0 siblings, 1 reply; 21+ messages in thread From: Paul Durrant @ 2012-10-01 16:28 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant These product numbers are used by the QEMU blacklisting protocol in traditional QEMU and are currently coded directly into the xenstore.c source module. Since there are now multiple QEMUs this information should be pulled into a public header to avoid duplication/conflict. hvm-emulated-unplug.markdown has also been adjusted to reference the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- docs/misc/hvm-emulated-unplug.markdown | 2 +- xen/include/public/hvm/pvdrivers.h | 46 ++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 1 deletions(-) create mode 100644 xen/include/public/hvm/pvdrivers.h diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 707fbab..ec9ce83 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the product number in step 3. The master registry of product names and numbers is in -qemu-xen-unstable's xenstore.c. +xen/include/public/hvm/pvdrivers.h diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h new file mode 100644 index 0000000..0471ebc --- /dev/null +++ b/xen/include/public/hvm/pvdrivers.h @@ -0,0 +1,46 @@ +/* + * pvdrivers.h: Register of PV drivers product numbers. + * Copyright (c) 2012, Citrix Systems Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ +#define _XEN_PUBLIC_PVDRIVERS_H_ + +/* + * This is the master registry of product numbers for + * PV drivers. + * If you need a new product number allocating, please + * post to xen-devel@lists.xensource.com. You should NOT use + * a product number without allocating one. + * If you maintain a separate versioning and distribution path + * for PV drivers you should have a separate product number so + * that your drivers can be separated from others. + * + * During development, you may use the product ID to + * indicate a driver which is yet to be released. + */ + +#define PVDRIVERS_PRODUCT_LIST(EACH) \ + EACH("xensource-windows", 0x0001) /* Citrix */ \ + EACH("gplpv-windows", 0x0002) /* James Harper */ \ + EACH("experimental", 0xffff) + +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-10-01 16:28 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant @ 2012-10-01 16:55 ` Ian Jackson 2012-10-02 8:34 ` Paul Durrant 0 siblings, 1 reply; 21+ messages in thread From: Ian Jackson @ 2012-10-01 16:55 UTC (permalink / raw) To: Paul Durrant; +Cc: Keir (Xen.org), Jan Beulich, xen-devel Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers."): > These product numbers are used by the QEMU blacklisting protocol in > traditional QEMU and are currently coded directly into the xenstore.c > source module. Since there are now multiple QEMUs this information > should be pulled into a public header to avoid duplication/conflict. > hvm-emulated-unplug.markdown has also been adjusted to reference the > new header. Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Given the fact this is in a public header, we should probably get an ack from Keir or Jan. Ian. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-10-01 16:55 ` Ian Jackson @ 2012-10-02 8:34 ` Paul Durrant 0 siblings, 0 replies; 21+ messages in thread From: Paul Durrant @ 2012-10-02 8:34 UTC (permalink / raw) To: Ian Jackson; +Cc: Keir (Xen.org), Jan Beulich, xen-devel@lists.xen.org > -----Original Message----- > From: Ian Jackson [mailto:Ian.Jackson@eu.citrix.com] > Sent: 01 October 2012 17:56 > To: Paul Durrant > Cc: xen-devel@lists.xen.org; Keir (Xen.org); Jan Beulich > Subject: Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve > as the register of product numbers. > > Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header > to serve as the register of product numbers."): > > These product numbers are used by the QEMU blacklisting protocol in > > traditional QEMU and are currently coded directly into the xenstore.c > > source module. Since there are now multiple QEMUs this information > > should be pulled into a public header to avoid duplication/conflict. > > hvm-emulated-unplug.markdown has also been adjusted to reference the > > new header. > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > > Given the fact this is in a public header, we should probably get an ack from > Keir or Jan. > Thanks. Paul ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 0/2] PV drivers product number registration (v2) @ 2012-10-01 9:41 Paul Durrant 2012-10-01 9:41 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 0 siblings, 1 reply; 21+ messages in thread From: Paul Durrant @ 2012-10-01 9:41 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU to prevent co-existence of emulated devices. See docs/misc/hvm-emulated-unplug.markdown for details. The register of product numbers used by the blacklisting feature of this protocol is currently directly in the xenstore.c source moduleof traditional QEMU. It should really be in a Xen header file to prevent duplication/conflict between QEMU versions. Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly without ever registering that number. This patch series introduces a new header and registers product number 3 for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to make use of the new header. Version 2: I have re-coded at Ian Jackson's request in the form of macros that allow a switch statement or array to be easily generated from the product list. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-10-01 9:41 [PATCH 0/2] PV drivers product number registration (v2) Paul Durrant @ 2012-10-01 9:41 ` Paul Durrant 2012-10-01 15:12 ` Ian Jackson 0 siblings, 1 reply; 21+ messages in thread From: Paul Durrant @ 2012-10-01 9:41 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant These product numbers are used by the QEMU blacklisting protocol in traditional QEMU and are currently coded directly into the xenstore.c source module. Since there are now multiple QEMUs this information should be pulled into a public header to avoid duplication/conflict. hvm-emulated-unplug.markdown has also been adjusted to reference the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- docs/misc/hvm-emulated-unplug.markdown | 2 +- xen/include/public/hvm/pvdrivers.h | 47 ++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletions(-) create mode 100644 xen/include/public/hvm/pvdrivers.h diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 707fbab..ec9ce83 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the product number in step 3. The master registry of product names and numbers is in -qemu-xen-unstable's xenstore.c. +xen/include/public/hvm/pvdrivers.h diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h new file mode 100644 index 0000000..13bf57b --- /dev/null +++ b/xen/include/public/hvm/pvdrivers.h @@ -0,0 +1,47 @@ +/* + * pvdrivers.h: Register of PV drivers product numbers. + * Copyright (c) 2012, Citrix Systems Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ +#define _XEN_PUBLIC_PVDRIVERS_H_ + +/* + * This is the master registry of product numbers for + * PV drivers. + * If you need a new product number allocating, please + * post to xen-devel@lists.xensource.com. You should NOT use + * a product number without allocating one. + * If you maintain a separate versioning and distribution path + * for PV drivers you should have a separate product number so + * that your drivers can be separated from others. + * + * During development, you may use the product ID to + * indicate a driver which is yet to be released. + */ + +#define PVDRIVERS_PRODUCT_LIST(EACH) \ + EACH("xensource-windows", 0x0001) /* Citrix */ \ + EACH("gplpv-windows", 0x0002) /* James Harper */ \ + EACH("experimental", 0xffff) \ + EACH(NULL, 0x0000) /* terminator */ + +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-10-01 9:41 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant @ 2012-10-01 15:12 ` Ian Jackson 2012-10-01 16:17 ` Paul Durrant 0 siblings, 1 reply; 21+ messages in thread From: Ian Jackson @ 2012-10-01 15:12 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers."): > +#define PVDRIVERS_PRODUCT_LIST(EACH) \ > + EACH("xensource-windows", 0x0001) /* Citrix */ \ > + EACH("gplpv-windows", 0x0002) /* James Harper */ \ > + EACH("experimental", 0xffff) \ > + EACH(NULL, 0x0000) /* terminator */ When you said a terminator, I thought you meant macro parameters to PVDRIVERS_PRODUCT_LIST which were invoked only between elements. This invocation of EACH is harmful. If the user wants to make an array out of this, they can add it themselves. But if they want to make a switch statement out of it, they can't. Ian. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-10-01 15:12 ` Ian Jackson @ 2012-10-01 16:17 ` Paul Durrant 0 siblings, 0 replies; 21+ messages in thread From: Paul Durrant @ 2012-10-01 16:17 UTC (permalink / raw) To: Ian Jackson; +Cc: xen-devel@lists.xen.org > -----Original Message----- > From: Ian Jackson [mailto:Ian.Jackson@eu.citrix.com] > Sent: 01 October 2012 16:12 > To: Paul Durrant > Cc: xen-devel@lists.xen.org > Subject: Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve > as the register of product numbers. > > Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header > to serve as the register of product numbers."): > > > +#define PVDRIVERS_PRODUCT_LIST(EACH) \ > > + EACH("xensource-windows", 0x0001) /* Citrix */ \ > > + EACH("gplpv-windows", 0x0002) /* James Harper */ \ > > + EACH("experimental", 0xffff) \ > > + EACH(NULL, 0x0000) /* terminator */ > > When you said a terminator, I thought you meant macro parameters to > PVDRIVERS_PRODUCT_LIST which were invoked only between elements. > > This invocation of EACH is harmful. If the user wants to make an array out of > this, they can add it themselves. But if they want to make a switch > statement out of it, they can't. > Ok. I thought it was helpful to reserve product number 0 for this purpose, but I'll ditch it. Paul ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 0/2] PV drivers product number registration @ 2012-09-26 12:23 Paul Durrant 2012-09-26 12:23 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 0 siblings, 1 reply; 21+ messages in thread From: Paul Durrant @ 2012-09-26 12:23 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant PV drivers in HVM guests typically make use off an 'unplug' protocol in QEMU to prevent co-existence of emulated devices. See docs/misc/hvm-emulated-unplug.markdown for details. The register of product numbers used by the blacklisting feature of this protocol is currently directly in the xenstore.c source module of traditional QEMU. It should really be in a Xen header file to prevent duplication/conflict between QEMU versions. Moreover the linux PV-on-HVM drivers make use of product number 3 seemingly without ever registering that number. This patch series introduces a new header and registers product number 3 for Linux's use. A subsequent patch to qemu-xen-unstable wll be created to make use of the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:23 [PATCH 0/2] PV drivers product number registration Paul Durrant @ 2012-09-26 12:23 ` Paul Durrant 2012-09-26 12:45 ` Jan Beulich ` (3 more replies) 0 siblings, 4 replies; 21+ messages in thread From: Paul Durrant @ 2012-09-26 12:23 UTC (permalink / raw) To: xen-devel; +Cc: Paul Durrant These product numbers are used by the QEMU blacklisting protocol in traditional QEMU and are currently coded directly into the xenstore.c source module. Since there are now multiple QEMUs this information should be pulled into a public header to avoid duplication/conflict. hvm-emulated-unplug.markdown has also been adjusted to reference the new header. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- docs/misc/hvm-emulated-unplug.markdown | 2 +- xen/include/public/hvm/pvdrivers.h | 50 ++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletions(-) create mode 100644 xen/include/public/hvm/pvdrivers.h diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 707fbab..ec9ce83 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the product number in step 3. The master registry of product names and numbers is in -qemu-xen-unstable's xenstore.c. +xen/include/public/hvm/pvdrivers.h diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h new file mode 100644 index 0000000..4be57ac --- /dev/null +++ b/xen/include/public/hvm/pvdrivers.h @@ -0,0 +1,50 @@ +/* + * pvdrivers.h: Register of PV drivers product numbers. + * Copyright (c) 2012, Citrix Systems Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ +#define _XEN_PUBLIC_PVDRIVERS_H_ + +/* + * This is the master registry of product numbers for + * PV drivers. + * If you need a new product number allocating, please + * post to xen-devel@lists.xensource.com. You should NOT use + * a product number without allocating one. + * If you maintain a separate versioning and distribution path + * for PV drivers you should have a separate product number so + * that your drivers can be separated from others. + * + * During development, you may use the product ID to + * indicate a driver which is yet to be released. + */ + +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" + +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" + +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" + +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:23 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant @ 2012-09-26 12:45 ` Jan Beulich 2012-09-26 13:16 ` Paul Durrant 2012-09-26 12:49 ` Konrad Rzeszutek Wilk ` (2 subsequent siblings) 3 siblings, 1 reply; 21+ messages in thread From: Jan Beulich @ 2012-09-26 12:45 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel >>> On 26.09.12 at 14:23, Paul Durrant <paul.durrant@citrix.com> wrote: > --- /dev/null > +++ b/xen/include/public/hvm/pvdrivers.h > @@ -0,0 +1,50 @@ > +/* > + * pvdrivers.h: Register of PV drivers product numbers. > + * Copyright (c) 2012, Citrix Systems Inc. > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ > +#define _XEN_PUBLIC_PVDRIVERS_H_ > + > +/* > + * This is the master registry of product numbers for > + * PV drivers. > + * If you need a new product number allocating, please > + * post to xen-devel@lists.xensource.com. You should NOT use @lists.xen.org > + * a product number without allocating one. > + * If you maintain a separate versioning and distribution path > + * for PV drivers you should have a separate product number so > + * that your drivers can be separated from others. > + * > + * During development, you may use the product ID to > + * indicate a driver which is yet to be released. Which "the product ID"? Jan > + */ > + > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > + > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" > + > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" > + > +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ > -- > 1.7.2.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:45 ` Jan Beulich @ 2012-09-26 13:16 ` Paul Durrant 2012-09-27 7:20 ` Jan Beulich 0 siblings, 1 reply; 21+ messages in thread From: Paul Durrant @ 2012-09-26 13:16 UTC (permalink / raw) To: Jan Beulich; +Cc: xen-devel@lists.xen.org > -----Original Message----- > From: Jan Beulich [mailto:JBeulich@suse.com] > Sent: 26 September 2012 13:46 > To: Paul Durrant > Cc: xen-devel@lists.xen.org > Subject: Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve > as the register of product numbers. > > >>> On 26.09.12 at 14:23, Paul Durrant <paul.durrant@citrix.com> wrote: > > --- /dev/null > > +++ b/xen/include/public/hvm/pvdrivers.h > > @@ -0,0 +1,50 @@ > > +/* > > + * pvdrivers.h: Register of PV drivers product numbers. > > + * Copyright (c) 2012, Citrix Systems Inc. > > + * > > + * Permission is hereby granted, free of charge, to any person obtaining a > copy > > + * of this software and associated documentation files (the "Software"), > to > > + * deal in the Software without restriction, including without limitation > the > > + * rights to use, copy, modify, merge, publish, distribute, sublicense, > and/or > > + * sell copies of the Software, and to permit persons to whom the > Software is > > + * furnished to do so, subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be > included in > > + * all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY > KIND, EXPRESS OR > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > MERCHANTABILITY, > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO > EVENT SHALL THE > > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, > DAMAGES OR OTHER > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR > OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE > OR OTHER > > + * DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ > > +#define _XEN_PUBLIC_PVDRIVERS_H_ > > + > > +/* > > + * This is the master registry of product numbers for > > + * PV drivers. > > + * If you need a new product number allocating, please > > + * post to xen-devel@lists.xensource.com. You should NOT use > > @lists.xen.org > Good point. That was historic. I'll fix it up. > > + * a product number without allocating one. > > + * If you maintain a separate versioning and distribution path > > + * for PV drivers you should have a separate product number so > > + * that your drivers can be separated from others. > > + * > > + * During development, you may use the product ID to > > + * indicate a driver which is yet to be released. > > Which "the product ID"? > The ones post-fixed '_ID'. Paul > Jan > > > + */ > > + > > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID > 0x0001 /* Citrix */ > > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource- > windows" > > + > > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* > James Harper */ > > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv- > windows" > > + > > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > > +#define PVDRIVERS_EXPERIMENTAL_NAME > "experimental" > > + > > +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ > > -- > > 1.7.2.5 > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 13:16 ` Paul Durrant @ 2012-09-27 7:20 ` Jan Beulich 2012-09-27 7:44 ` Paul Durrant 0 siblings, 1 reply; 21+ messages in thread From: Jan Beulich @ 2012-09-27 7:20 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel@lists.xen.org >>> On 26.09.12 at 15:16, Paul Durrant <Paul.Durrant@citrix.com> wrote: >> From: Jan Beulich [mailto:JBeulich@suse.com] >> >>> On 26.09.12 at 14:23, Paul Durrant <paul.durrant@citrix.com> wrote: >> > + * a product number without allocating one. >> > + * If you maintain a separate versioning and distribution path >> > + * for PV drivers you should have a separate product number so >> > + * that your drivers can be separated from others. >> > + * >> > + * During development, you may use the product ID to >> > + * indicate a driver which is yet to be released. >> >> Which "the product ID"? >> > > The ones post-fixed '_ID'. I would have thought it's meant to be specifically PVDRIVERS_EXPERIMENTAL_ID, and hence expected that to be spelled out. Jan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-27 7:20 ` Jan Beulich @ 2012-09-27 7:44 ` Paul Durrant 0 siblings, 0 replies; 21+ messages in thread From: Paul Durrant @ 2012-09-27 7:44 UTC (permalink / raw) To: Jan Beulich; +Cc: xen-devel@lists.xen.org > -----Original Message----- > From: Jan Beulich [mailto:JBeulich@suse.com] > Sent: 27 September 2012 08:21 > To: Paul Durrant > Cc: xen-devel@lists.xen.org > Subject: Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve > as the register of product numbers. > > >>> On 26.09.12 at 15:16, Paul Durrant <Paul.Durrant@citrix.com> wrote: > >> From: Jan Beulich [mailto:JBeulich@suse.com] > >> >>> On 26.09.12 at 14:23, Paul Durrant <paul.durrant@citrix.com> wrote: > >> > + * a product number without allocating one. > >> > + * If you maintain a separate versioning and distribution path > >> > + * for PV drivers you should have a separate product number so > >> > + * that your drivers can be separated from others. > >> > + * > >> > + * During development, you may use the product ID to > >> > + * indicate a driver which is yet to be released. > >> > >> Which "the product ID"? > >> > > > > The ones post-fixed '_ID'. > > I would have thought it's meant to be specifically > PVDRIVERS_EXPERIMENTAL_ID, and hence expected that to be spelled out. > Sorry, I misread what you'd said. Fixed in the 2nd version anyway. Paul ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:23 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-09-26 12:45 ` Jan Beulich @ 2012-09-26 12:49 ` Konrad Rzeszutek Wilk 2012-09-26 13:05 ` Ian Campbell 2012-09-27 8:06 ` Jan Beulich 2012-09-26 12:54 ` Ian Campbell 2012-09-26 13:26 ` David Vrabel 3 siblings, 2 replies; 21+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-09-26 12:49 UTC (permalink / raw) To: Paul Durrant, steve.prochniak, annie.li; +Cc: xen-devel On Wed, Sep 26, 2012 at 01:23:31PM +0100, Paul Durrant wrote: > These product numbers are used by the QEMU blacklisting protocol in > traditional QEMU and are currently coded directly into the xenstore.c > source module. Since there are now multiple QEMUs this information > should be pulled into a public header to avoid duplication/conflict. > hvm-emulated-unplug.markdown has also been adjusted to reference the > new header. > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com> > --- > docs/misc/hvm-emulated-unplug.markdown | 2 +- > xen/include/public/hvm/pvdrivers.h | 50 ++++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 1 deletions(-) > create mode 100644 xen/include/public/hvm/pvdrivers.h > > diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown > index 707fbab..ec9ce83 100644 > --- a/docs/misc/hvm-emulated-unplug.markdown > +++ b/docs/misc/hvm-emulated-unplug.markdown > @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the > product number in step 3. > > The master registry of product names and numbers is in > -qemu-xen-unstable's xenstore.c. > +xen/include/public/hvm/pvdrivers.h > diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h > new file mode 100644 > index 0000000..4be57ac > --- /dev/null > +++ b/xen/include/public/hvm/pvdrivers.h > @@ -0,0 +1,50 @@ > +/* > + * pvdrivers.h: Register of PV drivers product numbers. > + * Copyright (c) 2012, Citrix Systems Inc. > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ > +#define _XEN_PUBLIC_PVDRIVERS_H_ > + > +/* > + * This is the master registry of product numbers for > + * PV drivers. > + * If you need a new product number allocating, please > + * post to xen-devel@lists.xensource.com. You should NOT use > + * a product number without allocating one. > + * If you maintain a separate versioning and distribution path > + * for PV drivers you should have a separate product number so > + * that your drivers can be separated from others. > + * > + * During development, you may use the product ID to > + * indicate a driver which is yet to be released. > + */ > + > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > + > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" And also the Oracle one :-) The Novell one looks to be using 107? > + > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" > + > +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ > -- > 1.7.2.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:49 ` Konrad Rzeszutek Wilk @ 2012-09-26 13:05 ` Ian Campbell 2012-09-27 8:06 ` Jan Beulich 1 sibling, 0 replies; 21+ messages in thread From: Ian Campbell @ 2012-09-26 13:05 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: annie.li@oracle.com, Paul Durrant, steve.prochniak@oracle.com, xen-devel@lists.xen.org On Wed, 2012-09-26 at 13:49 +0100, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 26, 2012 at 01:23:31PM +0100, Paul Durrant wrote: > > These product numbers are used by the QEMU blacklisting protocol in > > traditional QEMU and are currently coded directly into the xenstore.c > > source module. Since there are now multiple QEMUs this information > > should be pulled into a public header to avoid duplication/conflict. > > hvm-emulated-unplug.markdown has also been adjusted to reference the > > new header. > > > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com> > > --- > > docs/misc/hvm-emulated-unplug.markdown | 2 +- > > xen/include/public/hvm/pvdrivers.h | 50 ++++++++++++++++++++++++++++++++ > > 2 files changed, 51 insertions(+), 1 deletions(-) > > create mode 100644 xen/include/public/hvm/pvdrivers.h > > > > diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown > > index 707fbab..ec9ce83 100644 > > --- a/docs/misc/hvm-emulated-unplug.markdown > > +++ b/docs/misc/hvm-emulated-unplug.markdown > > @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the > > product number in step 3. > > > > The master registry of product names and numbers is in > > -qemu-xen-unstable's xenstore.c. > > +xen/include/public/hvm/pvdrivers.h > > diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h > > new file mode 100644 > > index 0000000..4be57ac > > --- /dev/null > > +++ b/xen/include/public/hvm/pvdrivers.h > > @@ -0,0 +1,50 @@ > > +/* > > + * pvdrivers.h: Register of PV drivers product numbers. > > + * Copyright (c) 2012, Citrix Systems Inc. > > + * > > + * Permission is hereby granted, free of charge, to any person obtaining a copy > > + * of this software and associated documentation files (the "Software"), to > > + * deal in the Software without restriction, including without limitation the > > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > > + * sell copies of the Software, and to permit persons to whom the Software is > > + * furnished to do so, subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be included in > > + * all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > > + * DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ > > +#define _XEN_PUBLIC_PVDRIVERS_H_ > > + > > +/* > > + * This is the master registry of product numbers for > > + * PV drivers. > > + * If you need a new product number allocating, please > > + * post to xen-devel@lists.xensource.com. You should NOT use > > + * a product number without allocating one. > > + * If you maintain a separate versioning and distribution path > > + * for PV drivers you should have a separate product number so > > + * that your drivers can be separated from others. > > + * > > + * During development, you may use the product ID to > > + * indicate a driver which is yet to be released. > > + */ > > + > > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > > + > > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" > > And also the Oracle one :-) Oracle is using 0x0002? That would be unfortunate... > > The Novell one looks to be using 107? > > + > > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > > +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" > > + > > +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ > > -- > > 1.7.2.5 > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:49 ` Konrad Rzeszutek Wilk 2012-09-26 13:05 ` Ian Campbell @ 2012-09-27 8:06 ` Jan Beulich 2012-09-28 17:41 ` Konrad Rzeszutek Wilk 1 sibling, 1 reply; 21+ messages in thread From: Jan Beulich @ 2012-09-27 8:06 UTC (permalink / raw) To: Konrad Rzeszutek Wilk; +Cc: annie.li, Paul Durrant, steve.prochniak, xen-devel >>> On 26.09.12 at 14:49, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > On Wed, Sep 26, 2012 at 01:23:31PM +0100, Paul Durrant wrote: >> +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ >> +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" >> + >> +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ >> +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" > > And also the Oracle one :-) > > The Novell one looks to be using 107? Where did you spot that one? I was only able to locate use of 0xffff... Jan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-27 8:06 ` Jan Beulich @ 2012-09-28 17:41 ` Konrad Rzeszutek Wilk 0 siblings, 0 replies; 21+ messages in thread From: Konrad Rzeszutek Wilk @ 2012-09-28 17:41 UTC (permalink / raw) To: Jan Beulich; +Cc: annie.li, Paul Durrant, steve.prochniak, xen-devel On Thu, Sep 27, 2012 at 09:06:52AM +0100, Jan Beulich wrote: > >>> On 26.09.12 at 14:49, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > > On Wed, Sep 26, 2012 at 01:23:31PM +0100, Paul Durrant wrote: > >> +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > >> +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > >> + > >> +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > >> +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" > > > > And also the Oracle one :-) > > > > The Novell one looks to be using 107? > > Where did you spot that one? I was only able to locate use of > 0xffff... Let me doublecheck then. I saw it from the /var/log/xen/qemu.. being printed. This was a Win2K guest. > > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:23 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-09-26 12:45 ` Jan Beulich 2012-09-26 12:49 ` Konrad Rzeszutek Wilk @ 2012-09-26 12:54 ` Ian Campbell 2012-09-26 13:26 ` David Vrabel 3 siblings, 0 replies; 21+ messages in thread From: Ian Campbell @ 2012-09-26 12:54 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel@lists.xen.org On Wed, 2012-09-26 at 13:23 +0100, Paul Durrant wrote: > These product numbers are used by the QEMU blacklisting protocol in > traditional QEMU and are currently coded directly into the xenstore.c > source module. Since there are now multiple QEMUs this information > should be pulled into a public header to avoid duplication/conflict. > hvm-emulated-unplug.markdown has also been adjusted to reference the > new header. > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com> > --- > docs/misc/hvm-emulated-unplug.markdown | 2 +- > xen/include/public/hvm/pvdrivers.h | 50 ++++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 1 deletions(-) > create mode 100644 xen/include/public/hvm/pvdrivers.h > > diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown > index 707fbab..ec9ce83 100644 > --- a/docs/misc/hvm-emulated-unplug.markdown > +++ b/docs/misc/hvm-emulated-unplug.markdown > @@ -65,4 +65,4 @@ decimal number. `{product_name}` is a string corresponding to the > product number in step 3. > > The master registry of product names and numbers is in > -qemu-xen-unstable's xenstore.c. > +xen/include/public/hvm/pvdrivers.h > diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h > new file mode 100644 > index 0000000..4be57ac > --- /dev/null > +++ b/xen/include/public/hvm/pvdrivers.h > @@ -0,0 +1,50 @@ > +/* > + * pvdrivers.h: Register of PV drivers product numbers. > + * Copyright (c) 2012, Citrix Systems Inc. > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef _XEN_PUBLIC_PVDRIVERS_H_ > +#define _XEN_PUBLIC_PVDRIVERS_H_ > + > +/* > + * This is the master registry of product numbers for > + * PV drivers. > + * If you need a new product number allocating, please > + * post to xen-devel@lists.xensource.com. You should NOT use > + * a product number without allocating one. > + * If you maintain a separate versioning and distribution path > + * for PV drivers you should have a separate product number so > + * that your drivers can be separated from others. > + * > + * During development, you may use the product ID to > + * indicate a driver which is yet to be released. Can we add a reference to the unplug protocol doc here too please. > + */ > + > +#define PVDRIVERS_XENSOURCE_WINDOWS_ID 0x0001 /* Citrix */ > +#define PVDRIVERS_XENSOURCE_WINDOWS_NAME "xensource-windows" > + > +#define PVDRIVERS_GPLPV_WINDOWS_ID 0x0002 /* James Harper */ > +#define PVDRIVERS_GPLPV_WINDOWS_NAME "gplpv-windows" > + > +#define PVDRIVERS_EXPERIMENTAL_ID 0xffff > +#define PVDRIVERS_EXPERIMENTAL_NAME "experimental" > + > +#endif /* _XEN_PUBLIC_PVDRIVERS_H_ */ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. 2012-09-26 12:23 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant ` (2 preceding siblings ...) 2012-09-26 12:54 ` Ian Campbell @ 2012-09-26 13:26 ` David Vrabel 3 siblings, 0 replies; 21+ messages in thread From: David Vrabel @ 2012-09-26 13:26 UTC (permalink / raw) To: Paul Durrant; +Cc: xen-devel On 26/09/12 13:23, Paul Durrant wrote: > > + * During development, you may use the product ID to ^ EXPERIMENTAL ? > + * indicate a driver which is yet to be released. David ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2012-10-02 8:34 UTC | newest] Thread overview: 21+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-26 13:50 [PATCH 0/2] PV drivers product number registration Paul Durrant 2012-09-26 13:50 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-09-28 17:54 ` Ian Jackson 2012-09-26 13:50 ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant -- strict thread matches above, loose matches on Subject: below -- 2012-10-01 16:28 [PATCH 0/2] PV drivers product number registration (v3) Paul Durrant 2012-10-01 16:28 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-10-01 16:55 ` Ian Jackson 2012-10-02 8:34 ` Paul Durrant 2012-10-01 9:41 [PATCH 0/2] PV drivers product number registration (v2) Paul Durrant 2012-10-01 9:41 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-10-01 15:12 ` Ian Jackson 2012-10-01 16:17 ` Paul Durrant 2012-09-26 12:23 [PATCH 0/2] PV drivers product number registration Paul Durrant 2012-09-26 12:23 ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant 2012-09-26 12:45 ` Jan Beulich 2012-09-26 13:16 ` Paul Durrant 2012-09-27 7:20 ` Jan Beulich 2012-09-27 7:44 ` Paul Durrant 2012-09-26 12:49 ` Konrad Rzeszutek Wilk 2012-09-26 13:05 ` Ian Campbell 2012-09-27 8:06 ` Jan Beulich 2012-09-28 17:41 ` Konrad Rzeszutek Wilk 2012-09-26 12:54 ` Ian Campbell 2012-09-26 13:26 ` David Vrabel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).