xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Paul Durrant <paul.durrant@citrix.com>
To: xen-devel@lists.xen.org
Cc: Paul Durrant <paul.durrant@citrix.com>
Subject: [PATCH] Use new Xen public header for product numbers and names
Date: Mon, 1 Oct 2012 10:43:53 +0100	[thread overview]
Message-ID: <1349084633-13186-1-git-send-email-paul.durrant@citrix.com> (raw)

xen/include/public/hvm/pvdrivers.h has been added as the
register of product numbers used by the blacklisting protocol.
Use the definitions therein rather then locally coded values.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
 xenstore.c |   23 +++++++----------------
 1 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/xenstore.c b/xenstore.c
index 1857160..4382674 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -23,6 +23,8 @@
 #include "qemu-timer.h"
 #include "qemu-xen.h"
 
+#include <xen/hvm/pvdrivers.h>
+
 struct xs_handle *xsh = NULL;
 static char *media_filename[MAX_DRIVES+1];
 static QEMUTimer *insert_timer = NULL;
@@ -960,28 +962,17 @@ xenstore_pv_driver_build_blacklisted(uint16_t product_nr,
     char *tmp;
     const char *product;
 
+#define PRODUCT(_name, _nr) case _nr: product = _name; break;
     switch (product_nr) {
-    /*
-     * In qemu-xen-unstable, this is the master registry of product
-     * numbers.  If you need a new product number allocating, please
-     * post to xen-devel@lists.xensource.com.  You should NOT use
-     * an existing product number without allocating one.
-     *
-     * If you maintain a seaparate versioning and distribution path
-     * for PV drivers you should have a separate product number so
-     * that your drivers can be separated from others'.
-     *
-     * During development, you may use the product ID 0xffff to
-     * indicate a driver which is yet to be released.
-     */
-    case 1: product = "xensource-windows";  break; /* Citrix */
-    case 2: product = "gplpv-windows";      break; /* James Harper */
-    case 0xffff: product = "experimental";  break;
+    PVDRIVERS_PRODUCT_LIST(PRODUCT)
     default:
         /* Don't know what product this is -> we can't blacklist
          * it. */
         return 0;
     }
+
+#undef  PRODUCT
+
     if (asprintf(&buf, "/mh/driver-blacklist/%s/%d", product, build_nr) < 0)
         return 0;
     tmp = xs_read(xsh, XBT_NULL, buf, NULL);
-- 
1.7.2.5

             reply	other threads:[~2012-10-01  9:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-01  9:43 Paul Durrant [this message]
2012-10-01 15:14 ` [PATCH] Use new Xen public header for product numbers and names Ian Jackson
2012-10-01 16:08   ` Paul Durrant
2012-10-01  9:41     ` [PATCH 0/2] PV drivers product number registration (v2) Paul Durrant
2012-10-01  9:41       ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers Paul Durrant
2012-10-01 15:12         ` Ian Jackson
2012-10-01 16:17           ` Paul Durrant
2012-10-01 16:27             ` [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. [and 1 more messages] Ian Jackson
2012-10-01  9:41       ` [PATCH 2/2] Register Linux PV-on-HVM drivers product number Paul Durrant
2012-10-02  9:25     ` [PATCH] Use new Xen public header for product numbers and names Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2012-09-26 13:54 Paul Durrant
2012-09-28 17:55 ` Ian Jackson
2012-10-01  8:38   ` Paul Durrant
2012-10-01 10:13     ` Ian Jackson
2012-10-01 10:28       ` Paul Durrant
2012-10-01 10:36       ` Keir Fraser
2012-09-26 12:33 Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349084633-13186-1-git-send-email-paul.durrant@citrix.com \
    --to=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).