From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Tim (Xen.org)" <tim@xen.org>
Subject: Re: [PATCH v4 4/6] xen: introduce XEN_GUEST_HANDLE_PARAM
Date: Wed, 3 Oct 2012 14:35:23 +0100 [thread overview]
Message-ID: <1349271323.650.148.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1345633688-31684-4-git-send-email-stefano.stabellini@eu.citrix.com>
On Wed, 2012-08-22 at 12:08 +0100, Stefano Stabellini wrote:
> +#define set_xen_guest_handle_raw(hnd, val) \
> + do { \
> + typeof(&(hnd)) t = &(hnd); \
> + _t->q = 0; \
> + _t->p = val; \
You have a mix of t and _t here...
Since this macro is used in the tools it would be useful to avoid any
potentially clashing names (e.g. so -Wshadow doesn't moan).
_sxghr_tmp?
next prev parent reply other threads:[~2012-10-03 13:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 11:07 [PATCH v4 0/6] ARM hypercall ABI: 64 bit ready Stefano Stabellini
2012-08-22 11:08 ` [PATCH v4 1/6] xen: improve changes to xen_add_to_physmap Stefano Stabellini
2012-09-14 12:59 ` Ian Campbell
2012-09-14 13:17 ` Ian Campbell
2012-09-14 13:47 ` Ian Campbell
2012-09-14 13:56 ` Ian Campbell
2012-09-14 14:27 ` Jan Beulich
2012-09-14 15:44 ` Stefano Stabellini
2012-09-14 15:52 ` Ian Campbell
2012-09-14 15:54 ` Stefano Stabellini
2012-09-14 23:09 ` Mukesh Rathor
2012-09-14 23:07 ` Mukesh Rathor
2012-09-17 10:54 ` Stefano Stabellini
2012-09-19 13:03 ` Ian Campbell
2012-09-19 13:09 ` Ian Campbell
2012-09-19 13:20 ` Stefano Stabellini
2012-09-19 13:50 ` Ian Campbell
2012-09-19 13:17 ` Stefano Stabellini
2012-09-19 13:55 ` Ian Campbell
2012-08-22 11:08 ` [PATCH v4 2/6] xen: xen_ulong_t substitution Stefano Stabellini
2012-08-22 11:08 ` [PATCH v4 3/6] xen: change the limit of nr_extents to UINT_MAX >> MEMOP_EXTENT_SHIFT Stefano Stabellini
2012-08-22 11:08 ` [PATCH v4 4/6] xen: introduce XEN_GUEST_HANDLE_PARAM Stefano Stabellini
2012-10-03 13:35 ` Ian Campbell [this message]
2012-10-05 9:13 ` Ian Campbell
2012-10-09 14:10 ` Stefano Stabellini
2012-08-22 11:08 ` [PATCH v4 5/6] xen: replace XEN_GUEST_HANDLE with XEN_GUEST_HANDLE_PARAM when appropriate Stefano Stabellini
2012-08-22 11:08 ` [PATCH v4 6/6] xen: more substitutions Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349271323.650.148.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).