From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [Xen-devel V2] sedf/build: Fix build when using
 -fno-inline
Date: Thu, 4 Oct 2012 15:37:16 +0200
Message-ID: <1349357836.26047.1.camel@Abyss>
References: <506C3123.5050700@citrix.com> <506C31D0.4060702@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5514455596270412557=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <506C31D0.4060702@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============5514455596270412557==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-gBXs1jJjY8P4VoO/m64V"

--=-gBXs1jJjY8P4VoO/m64V
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2012-10-03 at 13:38 +0100, Andrew Cooper wrote:
> # HG changeset patch
> # Parent 5fbdbf585f5f2ee9a3e3c75a8a9f9f2cc6eda65c
> sedf/build: Fix build when using -fno-inline
>=20
> struct task_slice.migrated is not initialised by this function, and
> subsequently returned by value, leading to the error:
>=20
> sched_sedf.c: In function 'sedf_do_extra_schedule':
> sched_sedf.c:711: error: 'ret.migrated' may be used uninitialised in
> this function
>=20
> for both gcc 4.1.2 and 4.4.3 (which are the two I have easily to hand)
> when combined with the -fno-inline compile option.
>=20
> Signed-off-by Andrew Cooper <andrew.cooper3@citrix.com>
>=20
Acked-by: Dario Faggioli <dario.faggioli@citrix.com>

> --
> This is compile tested only, but given that the sole caller of
> sedf_do_extra_schedule() unconditionally sets migrated to 0, I am
> fairly
> confident of the correctness of the fix.
>=20
Agreed, sedf does not include any task migration mechanism, so 0 is all
you can have there. :-)

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



--=-gBXs1jJjY8P4VoO/m64V
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlBtkQwACgkQk4XaBE3IOsRH8QCfW1VK2JURAjjhG9dB9kfv+p6X
lbwAmQEJNA3F90MJNR1SIp/RtSsgCaan
=cFWe
-----END PGP SIGNATURE-----

--=-gBXs1jJjY8P4VoO/m64V--


--===============5514455596270412557==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5514455596270412557==--